* addtask menuconfig after do_configure (instead of do_patch)?
@ 2009-11-10 16:25 Leon Woestenberg
2009-11-16 10:38 ` Florian Boor
2009-11-16 22:18 ` [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure' Przemyslaw Wesolek
0 siblings, 2 replies; 5+ messages in thread
From: Leon Woestenberg @ 2009-11-10 16:25 UTC (permalink / raw)
To: openembedded-devel
Hello,
as seen in another thread I think this change is desired to improve
towards expected behaviour:
classes/kernel.bbclass:
-addtask menuconfig after do_patch
+addtask menuconfig after do_configure
This will make sure the OE default configuration is used as the
default config before going into the menu.
Downside is that menuconfig will probably not work for new kernel
recipes without defconfig.
Regards.
--
Leon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: addtask menuconfig after do_configure (instead of do_patch)?
2009-11-10 16:25 addtask menuconfig after do_configure (instead of do_patch)? Leon Woestenberg
@ 2009-11-16 10:38 ` Florian Boor
2009-11-16 22:18 ` [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure' Przemyslaw Wesolek
1 sibling, 0 replies; 5+ messages in thread
From: Florian Boor @ 2009-11-16 10:38 UTC (permalink / raw)
To: openembedded-devel
Hi,
Leon Woestenberg schrieb:
> classes/kernel.bbclass:
>
> -addtask menuconfig after do_patch
> +addtask menuconfig after do_configure
>
> This will make sure the OE default configuration is used as the
> default config before going into the menu.
this might be a good idea. I guess this would be the desired starting point.
> Downside is that menuconfig will probably not work for new kernel
> recipes without defconfig.
Yes true, but to be honest: Do we really need to support this? I am willing to
learn but currently I do not see much of use in kernel recipes without defconfig.
Greetings
Florian
--
The dream of yesterday Florian Boor
is the hope of today Tel: +49 271-771091-15
and the reality of tomorrow. Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904] florian.boor@kernelconcepts.de
http://www.kernelconcepts.de/en
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure'.
2009-11-10 16:25 addtask menuconfig after do_configure (instead of do_patch)? Leon Woestenberg
2009-11-16 10:38 ` Florian Boor
@ 2009-11-16 22:18 ` Przemyslaw Wesolek
2009-11-18 10:25 ` Phil Blundell
1 sibling, 1 reply; 5+ messages in thread
From: Przemyslaw Wesolek @ 2009-11-16 22:18 UTC (permalink / raw)
To: openembedded-devel
Previously, 'menuconfig' task was being run just after 'patch' one. In
result, the most common path for unexperienced users:
bitbake virtual/kernel -c menuconfig
bitbake virtual/kernel -c build
didn't work, because the result of 'menuconfig' was later overwritten by
'configure' on the chain of 'build'.
With this patch, 'configure' is requirement for 'menuconfig',
so any manual changes to the kernel config is done just before
actual build and no overwrite occurs.
Signed-off-by: Przemyslaw Wesolek <przemyslaw.wesolek@cs.put.poznan.pl>
---
classes/kernel.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
index fe611ab..637805e 100644
--- a/classes/kernel.bbclass
+++ b/classes/kernel.bbclass
@@ -215,7 +215,7 @@ do_menuconfig() {
fi
}
do_menuconfig[nostamp] = "1"
-addtask menuconfig after do_patch
+addtask menuconfig after do_configure
pkg_postinst_kernel () {
cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure'.
2009-11-16 22:18 ` [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure' Przemyslaw Wesolek
@ 2009-11-18 10:25 ` Phil Blundell
2009-11-18 10:32 ` Koen Kooi
0 siblings, 1 reply; 5+ messages in thread
From: Phil Blundell @ 2009-11-18 10:25 UTC (permalink / raw)
To: openembedded-devel
On Mon, 2009-11-16 at 23:18 +0100, Przemyslaw Wesolek wrote:
> Previously, 'menuconfig' task was being run just after 'patch' one. In
> result, the most common path for unexperienced users:
>
> bitbake virtual/kernel -c menuconfig
> bitbake virtual/kernel -c build
>
> didn't work, because the result of 'menuconfig' was later overwritten by
> 'configure' on the chain of 'build'.
>
> With this patch, 'configure' is requirement for 'menuconfig',
> so any manual changes to the kernel config is done just before
> actual build and no overwrite occurs.
Thanks for the patch. That seems like a reasonable change and I think
it's been proposed before without anybody speaking up in favour of the
old behaviour. I checked this in.
p.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure'.
2009-11-18 10:25 ` Phil Blundell
@ 2009-11-18 10:32 ` Koen Kooi
0 siblings, 0 replies; 5+ messages in thread
From: Koen Kooi @ 2009-11-18 10:32 UTC (permalink / raw)
To: openembedded-devel
On 18-11-09 11:25, Phil Blundell wrote:
> On Mon, 2009-11-16 at 23:18 +0100, Przemyslaw Wesolek wrote:
>> Previously, 'menuconfig' task was being run just after 'patch' one. In
>> result, the most common path for unexperienced users:
>>
>> bitbake virtual/kernel -c menuconfig
>> bitbake virtual/kernel -c build
>>
>> didn't work, because the result of 'menuconfig' was later overwritten by
>> 'configure' on the chain of 'build'.
>>
>> With this patch, 'configure' is requirement for 'menuconfig',
>> so any manual changes to the kernel config is done just before
>> actual build and no overwrite occurs.
>
> Thanks for the patch. That seems like a reasonable change and I think
> it's been proposed before without anybody speaking up in favour of the
> old behaviour. I checked this in.
Could please use --author in the future when applying patches created by
other people? We aren't using cvs anymore...
regards,
Koen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-18 10:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 16:25 addtask menuconfig after do_configure (instead of do_patch)? Leon Woestenberg
2009-11-16 10:38 ` Florian Boor
2009-11-16 22:18 ` [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure' Przemyslaw Wesolek
2009-11-18 10:25 ` Phil Blundell
2009-11-18 10:32 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.