[Buildroot] [PATCH] binutils: fix makeinfo related issue

[Buildroot] [PATCH] binutils: fix makeinfo related issue

[Thomas Petazzoni]

The latest version of binutils, 2.27, added in commit
b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems
that don't have makeinfo installed. This commit therefore applies the
same fixup as the one used for binutils 2.26, which consists in
touching all the .info files, so that they don't get rebuilt.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/binutils/binutils.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
index 71ea2b0..ad3a0d8 100644
--- a/package/binutils/binutils.mk
+++ b/package/binutils/binutils.mk
@@ -33,10 +33,10 @@ BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
 HOST_BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
 endif
 
-# The .info files in the 2.26 tarball have an incorrect timestamp, so
-# binutils tries to re-generate them. In order to avoid the dependency
-# on host-texinfo, we simply update the timestamps.
-ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
+# The .info files in the >= 2.26 tarball have an incorrect timestamp,
+# so binutils tries to re-generate them. In order to avoid the
+# dependency on host-texinfo, we simply update the timestamps.
+ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)
 define BINUTILS_FIXUP_INFO_TIMESTAMPS
 	find $(@D) -name '*.info' -exec touch {} \;
 endef
-- 
2.7.4

[Buildroot] [PATCH] binutils: fix makeinfo related issue

[Romain Naour]

Hi Thomas,

Le 08/09/2016 ? 21:49, Thomas Petazzoni a ?crit :
> The latest version of binutils, 2.27, added in commit
> b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems
> that don't have makeinfo installed. This commit therefore applies the
> same fixup as the one used for binutils 2.26, which consists in
> touching all the .info files, so that they don't get rebuilt.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/binutils/binutils.mk | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index 71ea2b0..ad3a0d8 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
> @@ -33,10 +33,10 @@ BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
>  HOST_BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
>  endif
>  
> -# The .info files in the 2.26 tarball have an incorrect timestamp, so
> -# binutils tries to re-generate them. In order to avoid the dependency
> -# on host-texinfo, we simply update the timestamps.
> -ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
> +# The .info files in the >= 2.26 tarball have an incorrect timestamp,
> +# so binutils tries to re-generate them. In order to avoid the
> +# dependency on host-texinfo, we simply update the timestamps.
> +ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)

Binutils 2.28 will likely have the same issue, why not inverse the condition ?
ifneq ($(BR2_BINUTILS_VERSION_2_24_X)$(BR2_BINUTILS_VERSION_2_25_X),)

Best regards,
Romain

>  define BINUTILS_FIXUP_INFO_TIMESTAMPS
>  	find $(@D) -name '*.info' -exec touch {} \;
>  endef
> 

[Buildroot] [PATCH] binutils: fix makeinfo related issue

[Thomas Petazzoni]

Hello,

On Thu, 8 Sep 2016 22:45:00 +0200, Romain Naour wrote:

> > -# The .info files in the 2.26 tarball have an incorrect timestamp, so
> > -# binutils tries to re-generate them. In order to avoid the dependency
> > -# on host-texinfo, we simply update the timestamps.
> > -ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
> > +# The .info files in the >= 2.26 tarball have an incorrect timestamp,
> > +# so binutils tries to re-generate them. In order to avoid the
> > +# dependency on host-texinfo, we simply update the timestamps.
> > +ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)  
> 
> Binutils 2.28 will likely have the same issue, why not inverse the condition ?
> ifneq ($(BR2_BINUTILS_VERSION_2_24_X)$(BR2_BINUTILS_VERSION_2_25_X),)

Right, but maybe I could dream that someone will report the bug to the
binutils maintainers, and that the problem will be fixed in binutils
2.28 ? :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] binutils: fix makeinfo related issue

[Thomas Petazzoni]

Hello,

On Thu,  8 Sep 2016 21:49:22 +0200, Thomas Petazzoni wrote:
> The latest version of binutils, 2.27, added in commit
> b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems
> that don't have makeinfo installed. This commit therefore applies the
> same fixup as the one used for binutils 2.26, which consists in
> touching all the .info files, so that they don't get rebuilt.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/binutils/binutils.mk | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com