All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"kumar sourav" <sourav.jb1988@gmail.com>,
	qemu-trivial@nongnu.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
Date: Mon, 28 Jan 2019 09:14:03 +0100	[thread overview]
Message-ID: <c3d19d18-3269-ff31-affb-68d38de7cc3e@redhat.com> (raw)
In-Reply-To: <cc09d469-56bc-9438-acc0-0d4ccf67e6a5@redhat.com>

On 2019-01-25 17:44, Philippe Mathieu-Daudé wrote:
> On 1/25/19 4:24 PM, Thomas Huth wrote:
>> On 2019-01-25 16:14, kumar sourav wrote:
>>> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
>>> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>>>
>>> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
>>> ---
>>>  hw/input/pckbd.c | 1 +
> 
> It seems we have other potential cases:
> 
> $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c
> hw/input/adb.c
> hw/input/hid.c
> hw/input/lm832x.c
> hw/input/milkymist-softusb.c
> hw/input/pckbd.c
> hw/input/pl050.c
> hw/input/ps2.c
> hw/input/pxa2xx_keypad.c
> hw/input/stellaris_input.c
> hw/input/tsc2005.c
> hw/input/tsc210x.c
> hw/input/virtio-input-hid.c
> hw/input/virtio-input-host.c

Note that some of these are not even "qomified" yet (e.g. tsc2005),
others are not creatable by the user (pl050) as far as I can see, so it
does not make much sense to set a category for these devices yet.

 Thomas

  parent reply	other threads:[~2019-01-28  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
2019-01-25 15:24 ` Thomas Huth
2019-01-25 16:44   ` Philippe Mathieu-Daudé
2019-01-25 18:00     ` ksourav
2019-01-25 19:47       ` Michael S. Tsirkin
2019-01-28  8:14     ` Thomas Huth [this message]
2019-01-25 19:46 ` Michael S. Tsirkin
2019-01-30  9:19 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3d19d18-3269-ff31-affb-68d38de7cc3e@redhat.com \
    --to=thuth@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sourav.jb1988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.