* [PATCH] Documentation/process: mention patch changelog in review process
@ 2022-04-02 10:07 Krzysztof Kozlowski
2022-04-03 5:58 ` Bagas Sanjaya
2022-04-05 15:44 ` Jonathan Corbet
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-02 10:07 UTC (permalink / raw)
To: Jonathan Corbet, linux-doc, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
Extend the "Respond to review comments" section of "Submitting patches"
with reference to patch changelogs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/process/submitting-patches.rst | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index fb496b2ebfd3..9bb4e8c0f635 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -318,7 +318,10 @@ understands what is going on.
Be sure to tell the reviewers what changes you are making and to thank them
for their time. Code review is a tiring and time-consuming process, and
reviewers sometimes get grumpy. Even in that case, though, respond
-politely and address the problems they have pointed out.
+politely and address the problems they have pointed out. When sending a next
+version, add a ``patch changelog`` to the cover letter or to individual patches
+explaining difference aganst previous submission (see
+:ref:`the_canonical_patch_format`).
See Documentation/process/email-clients.rst for recommendations on email
clients and mailing list etiquette.
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/process: mention patch changelog in review process
2022-04-02 10:07 [PATCH] Documentation/process: mention patch changelog in review process Krzysztof Kozlowski
@ 2022-04-03 5:58 ` Bagas Sanjaya
2022-04-03 7:47 ` Krzysztof Kozlowski
2022-04-05 15:44 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2022-04-03 5:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jonathan Corbet, linux-doc, linux-kernel
Cc: Stephen Boyd
On 02/04/22 17.07, Krzysztof Kozlowski wrote:
> Extend the "Respond to review comments" section of "Submitting patches"
> with reference to patch changelogs.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/process/submitting-patches.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index fb496b2ebfd3..9bb4e8c0f635 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -318,7 +318,10 @@ understands what is going on.
> Be sure to tell the reviewers what changes you are making and to thank them
> for their time. Code review is a tiring and time-consuming process, and
> reviewers sometimes get grumpy. Even in that case, though, respond
> -politely and address the problems they have pointed out.
> +politely and address the problems they have pointed out. When sending a next
> +version, add a ``patch changelog`` to the cover letter or to individual patches
> +explaining difference aganst previous submission (see
> +:ref:`the_canonical_patch_format`).
>
> See Documentation/process/email-clients.rst for recommendations on email
> clients and mailing list etiquette.
What about range-diffs?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/process: mention patch changelog in review process
2022-04-03 5:58 ` Bagas Sanjaya
@ 2022-04-03 7:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-03 7:47 UTC (permalink / raw)
To: Bagas Sanjaya, Jonathan Corbet, linux-doc, linux-kernel; +Cc: Stephen Boyd
On 03/04/2022 07:58, Bagas Sanjaya wrote:
> On 02/04/22 17.07, Krzysztof Kozlowski wrote:
>> Extend the "Respond to review comments" section of "Submitting patches"
>> with reference to patch changelogs.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/process/submitting-patches.rst | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
>> index fb496b2ebfd3..9bb4e8c0f635 100644
>> --- a/Documentation/process/submitting-patches.rst
>> +++ b/Documentation/process/submitting-patches.rst
>> @@ -318,7 +318,10 @@ understands what is going on.
>> Be sure to tell the reviewers what changes you are making and to thank them
>> for their time. Code review is a tiring and time-consuming process, and
>> reviewers sometimes get grumpy. Even in that case, though, respond
>> -politely and address the problems they have pointed out.
>> +politely and address the problems they have pointed out. When sending a next
>> +version, add a ``patch changelog`` to the cover letter or to individual patches
>> +explaining difference aganst previous submission (see
>> +:ref:`the_canonical_patch_format`).
>>
>> See Documentation/process/email-clients.rst for recommendations on email
>> clients and mailing list etiquette.
>
> What about range-diffs?
What about it? I extend here the versioning of patches, which does not
come with range-diffs.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/process: mention patch changelog in review process
2022-04-02 10:07 [PATCH] Documentation/process: mention patch changelog in review process Krzysztof Kozlowski
2022-04-03 5:58 ` Bagas Sanjaya
@ 2022-04-05 15:44 ` Jonathan Corbet
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2022-04-05 15:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-doc, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Extend the "Respond to review comments" section of "Submitting patches"
> with reference to patch changelogs.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/process/submitting-patches.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-06 1:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-02 10:07 [PATCH] Documentation/process: mention patch changelog in review process Krzysztof Kozlowski
2022-04-03 5:58 ` Bagas Sanjaya
2022-04-03 7:47 ` Krzysztof Kozlowski
2022-04-05 15:44 ` Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.