* [PATCH 1/1] rds: remove unnecessary returned value check
@ 2017-03-03 5:44 Zhu Yanjun
[not found] ` <1488519866-24148-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Zhu Yanjun @ 2017-03-03 5:44 UTC (permalink / raw)
To: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA
The function rds_trans_register always returns 0. As such, it is not
necessary to check the returned value.
Cc: Joe Jin <joe.jin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
net/rds/ib.c | 6 +-----
net/rds/rds.h | 2 +-
net/rds/tcp.c | 6 +-----
net/rds/transport.c | 4 +---
4 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index 0f557b2..7a64c8d 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -438,16 +438,12 @@ int rds_ib_init(void)
if (ret)
goto out_sysctl;
- ret = rds_trans_register(&rds_ib_transport);
- if (ret)
- goto out_recv;
+ rds_trans_register(&rds_ib_transport);
rds_info_register_func(RDS_INFO_IB_CONNECTIONS, rds_ib_ic_info);
goto out;
-out_recv:
- rds_ib_recv_exit();
out_sysctl:
rds_ib_sysctl_exit();
out_ibreg:
diff --git a/net/rds/rds.h b/net/rds/rds.h
index 966d2ee..39518ef 100644
--- a/net/rds/rds.h
+++ b/net/rds/rds.h
@@ -903,7 +903,7 @@ void rds_connect_path_complete(struct rds_conn_path *conn, int curr);
void rds_connect_complete(struct rds_connection *conn);
/* transport.c */
-int rds_trans_register(struct rds_transport *trans);
+void rds_trans_register(struct rds_transport *trans);
void rds_trans_unregister(struct rds_transport *trans);
struct rds_transport *rds_trans_get_preferred(struct net *net, __be32 addr);
void rds_trans_put(struct rds_transport *trans);
diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index 5438f67..a973d3b 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -652,16 +652,12 @@ static int rds_tcp_init(void)
if (ret)
goto out_pernet;
- ret = rds_trans_register(&rds_tcp_transport);
- if (ret)
- goto out_recv;
+ rds_trans_register(&rds_tcp_transport);
rds_info_register_func(RDS_INFO_TCP_SOCKETS, rds_tcp_tc_info);
goto out;
-out_recv:
- rds_tcp_recv_exit();
out_pernet:
unregister_pernet_subsys(&rds_tcp_net_ops);
out_notifier:
diff --git a/net/rds/transport.c b/net/rds/transport.c
index 2ffd3e3..0b188dd 100644
--- a/net/rds/transport.c
+++ b/net/rds/transport.c
@@ -40,7 +40,7 @@
static struct rds_transport *transports[RDS_TRANS_COUNT];
static DECLARE_RWSEM(rds_trans_sem);
-int rds_trans_register(struct rds_transport *trans)
+void rds_trans_register(struct rds_transport *trans)
{
BUG_ON(strlen(trans->t_name) + 1 > TRANSNAMSIZ);
@@ -55,8 +55,6 @@ int rds_trans_register(struct rds_transport *trans)
}
up_write(&rds_trans_sem);
-
- return 0;
}
EXPORT_SYMBOL_GPL(rds_trans_register);
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rds: remove unnecessary returned value check
[not found] ` <1488519866-24148-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2017-03-03 9:55 ` Yuval Shaia
2017-03-03 16:42 ` Santosh Shilimkar
2017-03-03 17:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Yuval Shaia @ 2017-03-03 9:55 UTC (permalink / raw)
To: Zhu Yanjun
Cc: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g
On Fri, Mar 03, 2017 at 12:44:26AM -0500, Zhu Yanjun wrote:
> The function rds_trans_register always returns 0. As such, it is not
> necessary to check the returned value.
>
> Cc: Joe Jin <joe.jin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Cc: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> net/rds/ib.c | 6 +-----
> net/rds/rds.h | 2 +-
> net/rds/tcp.c | 6 +-----
> net/rds/transport.c | 4 +---
> 4 files changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/net/rds/ib.c b/net/rds/ib.c
> index 0f557b2..7a64c8d 100644
> --- a/net/rds/ib.c
> +++ b/net/rds/ib.c
> @@ -438,16 +438,12 @@ int rds_ib_init(void)
> if (ret)
> goto out_sysctl;
>
> - ret = rds_trans_register(&rds_ib_transport);
> - if (ret)
> - goto out_recv;
> + rds_trans_register(&rds_ib_transport);
>
> rds_info_register_func(RDS_INFO_IB_CONNECTIONS, rds_ib_ic_info);
>
> goto out;
>
> -out_recv:
> - rds_ib_recv_exit();
> out_sysctl:
> rds_ib_sysctl_exit();
> out_ibreg:
> diff --git a/net/rds/rds.h b/net/rds/rds.h
> index 966d2ee..39518ef 100644
> --- a/net/rds/rds.h
> +++ b/net/rds/rds.h
> @@ -903,7 +903,7 @@ void rds_connect_path_complete(struct rds_conn_path *conn, int curr);
> void rds_connect_complete(struct rds_connection *conn);
>
> /* transport.c */
> -int rds_trans_register(struct rds_transport *trans);
> +void rds_trans_register(struct rds_transport *trans);
> void rds_trans_unregister(struct rds_transport *trans);
> struct rds_transport *rds_trans_get_preferred(struct net *net, __be32 addr);
> void rds_trans_put(struct rds_transport *trans);
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index 5438f67..a973d3b 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -652,16 +652,12 @@ static int rds_tcp_init(void)
> if (ret)
> goto out_pernet;
>
> - ret = rds_trans_register(&rds_tcp_transport);
> - if (ret)
> - goto out_recv;
> + rds_trans_register(&rds_tcp_transport);
>
> rds_info_register_func(RDS_INFO_TCP_SOCKETS, rds_tcp_tc_info);
>
> goto out;
>
> -out_recv:
> - rds_tcp_recv_exit();
> out_pernet:
> unregister_pernet_subsys(&rds_tcp_net_ops);
> out_notifier:
> diff --git a/net/rds/transport.c b/net/rds/transport.c
> index 2ffd3e3..0b188dd 100644
> --- a/net/rds/transport.c
> +++ b/net/rds/transport.c
> @@ -40,7 +40,7 @@
> static struct rds_transport *transports[RDS_TRANS_COUNT];
> static DECLARE_RWSEM(rds_trans_sem);
>
> -int rds_trans_register(struct rds_transport *trans)
> +void rds_trans_register(struct rds_transport *trans)
> {
> BUG_ON(strlen(trans->t_name) + 1 > TRANSNAMSIZ);
>
> @@ -55,8 +55,6 @@ int rds_trans_register(struct rds_transport *trans)
> }
>
> up_write(&rds_trans_sem);
> -
> - return 0;
> }
> EXPORT_SYMBOL_GPL(rds_trans_register);
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rds: remove unnecessary returned value check
[not found] ` <1488519866-24148-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-03 9:55 ` Yuval Shaia
@ 2017-03-03 16:42 ` Santosh Shilimkar
2017-03-03 17:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2017-03-03 16:42 UTC (permalink / raw)
To: Zhu Yanjun, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA
On 3/2/2017 9:44 PM, Zhu Yanjun wrote:
> The function rds_trans_register always returns 0. As such, it is not
> necessary to check the returned value.
>
> Cc: Joe Jin <joe.jin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Cc: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] rds: remove unnecessary returned value check
[not found] ` <1488519866-24148-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-03 9:55 ` Yuval Shaia
2017-03-03 16:42 ` Santosh Shilimkar
@ 2017-03-03 17:51 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-03-03 17:51 UTC (permalink / raw)
To: yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA
Cc: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA
From: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Date: Fri, 3 Mar 2017 00:44:26 -0500
> The function rds_trans_register always returns 0. As such, it is not
> necessary to check the returned value.
>
> Cc: Joe Jin <joe.jin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Cc: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-03 17:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-03 5:44 [PATCH 1/1] rds: remove unnecessary returned value check Zhu Yanjun
[not found] ` <1488519866-24148-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-03 9:55 ` Yuval Shaia
2017-03-03 16:42 ` Santosh Shilimkar
2017-03-03 17:51 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.