* [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors"
@ 2020-01-03 22:24 Richard Leitner
2020-01-04 2:29 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Richard Leitner @ 2020-01-03 22:24 UTC (permalink / raw)
To: openembedded-devel; +Cc: Darcy Watkins
This reverts commit d5a8ec9e269d1f04a6cf78867ebf74a297f33258 as it broke
the build with older GCC versions.
See also https://lists.yoctoproject.org/g/yocto/message/47850
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Cc: Darcy Watkins <dwatkins@sierrawireless.com>
---
recipes-core/openjdk/openjdk-8-release-172b11-common.inc | 5 -----
1 file changed, 5 deletions(-)
diff --git a/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
b/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
index f3bbf0a..ad20585 100644
--- a/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
+++ b/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
@@ -94,11 +94,6 @@ ARM_INSTRUCTION_SET_armv4t = "ARM"
BUILD_CFLAGS_append = " -Wno-error=deprecated-declarations"
TARGET_CFLAGS_append = " -Wno-error=deprecated-declarations"
-# WORKAROUND: disable the "specified bound depends on the length of the
source argument"
-# compiler error until we update openjdk8 to a fixed version
-BUILD_CFLAGS_append = " -Wno-error=stringop-overflow"
-TARGET_CFLAGS_append = " -Wno-error=stringop-overflow"
-
# Enable zero mode for arm based builds, as normal hotspot fails to build
PACKAGECONFIG_append_armv4 = " zero"
PACKAGECONFIG_append_armv5 = " zero"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors"
2020-01-03 22:24 [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors" Richard Leitner
@ 2020-01-04 2:29 ` Khem Raj
2020-01-07 6:12 ` Richard Leitner
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2020-01-04 2:29 UTC (permalink / raw)
To: Richard Leitner; +Cc: Darcy Watkins, openembeded-devel
On Fri, Jan 3, 2020 at 2:24 PM Richard Leitner
<richard.leitner@skidata.com> wrote:
>
> This reverts commit d5a8ec9e269d1f04a6cf78867ebf74a297f33258 as it broke
> the build with older GCC versions.
>
> See also https://lists.yoctoproject.org/g/yocto/message/47850
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> Cc: Darcy Watkins <dwatkins@sierrawireless.com>
> ---
> recipes-core/openjdk/openjdk-8-release-172b11-common.inc | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
> b/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
> index f3bbf0a..ad20585 100644
> --- a/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
> +++ b/recipes-core/openjdk/openjdk-8-release-172b11-common.inc
> @@ -94,11 +94,6 @@ ARM_INSTRUCTION_SET_armv4t = "ARM"
> BUILD_CFLAGS_append = " -Wno-error=deprecated-declarations"
> TARGET_CFLAGS_append = " -Wno-error=deprecated-declarations"
>
> -# WORKAROUND: disable the "specified bound depends on the length of the
> source argument"
> -# compiler error until we update openjdk8 to a fixed version
> -BUILD_CFLAGS_append = " -Wno-error=stringop-overflow"
> -TARGET_CFLAGS_append = " -Wno-error=stringop-overflow"
> -
perhaps as distro integrator, its better for us to disable all
warning-as-error settings
which should work across all gcc versions and warnings will still be
there if someone
is interested in fixing them.
something like below might work.
BUILD_CFLAGS_append = " -Wno-error"
TARGET_CFLAGS_append = " -Wno-error"
other options is to add -Wno-unknown-warning which will not break
build when a warning is not known
> # Enable zero mode for arm based builds, as normal hotspot fails to build
> PACKAGECONFIG_append_armv4 = " zero"
> PACKAGECONFIG_append_armv5 = " zero"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors"
2020-01-04 2:29 ` Khem Raj
@ 2020-01-07 6:12 ` Richard Leitner
2020-01-07 15:30 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Richard Leitner @ 2020-01-07 6:12 UTC (permalink / raw)
To: Khem Raj; +Cc: Darcy Watkins, openembeded-devel
Hi,
On 04/01/2020 03:29, Khem Raj wrote:
> On Fri, Jan 3, 2020 at 2:24 PM Richard Leitner
...
>> -# WORKAROUND: disable the "specified bound depends on the length of the
>> source argument"
>> -# compiler error until we update openjdk8 to a fixed version
>> -BUILD_CFLAGS_append = " -Wno-error=stringop-overflow"
>> -TARGET_CFLAGS_append = " -Wno-error=stringop-overflow"
>> -
>
> perhaps as distro integrator, its better for us to disable all
> warning-as-error settings
> which should work across all gcc versions and warnings will still be
> there if someone
> is interested in fixing them.
>
> something like below might work.
>
> BUILD_CFLAGS_append = " -Wno-error"
> TARGET_CFLAGS_append = " -Wno-error"
If that's acceptable for a OE/YP layer I'll gladly do this for meta-java.
I always wondered why so much effort is put into fixing new warnings in
"old" versions of software.
Thanks & regards;rl
>
> other options is to add -Wno-unknown-warning which will not break
> build when a warning is not known
...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors"
2020-01-07 6:12 ` Richard Leitner
@ 2020-01-07 15:30 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2020-01-07 15:30 UTC (permalink / raw)
To: Richard Leitner; +Cc: Darcy Watkins, openembeded-devel
On Mon, Jan 6, 2020 at 10:12 PM Richard Leitner <richard.leitner@skidata.com>
wrote:
> Hi,
>
> On 04/01/2020 03:29, Khem Raj wrote:
> > On Fri, Jan 3, 2020 at 2:24 PM Richard Leitner
>
> ...
>
> >> -# WORKAROUND: disable the "specified bound depends on the length of the
> >> source argument"
> >> -# compiler error until we update openjdk8 to a fixed version
> >> -BUILD_CFLAGS_append = " -Wno-error=stringop-overflow"
> >> -TARGET_CFLAGS_append = " -Wno-error=stringop-overflow"
> >> -
> >
> > perhaps as distro integrator, its better for us to disable all
> > warning-as-error settings
> > which should work across all gcc versions and warnings will still be
> > there if someone
> > is interested in fixing them.
> >
> > something like below might work.
> >
> > BUILD_CFLAGS_append = " -Wno-error"
> > TARGET_CFLAGS_append = " -Wno-error"
>
> If that's acceptable for a OE/YP layer I'll gladly do this for meta-java.
> I always wondered why so much effort is put into fixing new warnings in
> "old" versions of software.
Yes it is acceptable. Fixing warnings is useful if it finds a bug which was
otherwise latent
>
>
> Thanks & regards;rl
>
> >
> > other options is to add -Wno-unknown-warning which will not break
> > build when a warning is not known
>
> ...
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-07 15:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 22:24 [meta-java][warrior][PATCH] Revert "openjdk-8: disable, stringop-overflow compiler errors" Richard Leitner
2020-01-04 2:29 ` Khem Raj
2020-01-07 6:12 ` Richard Leitner
2020-01-07 15:30 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.