* Re: [PATCH] staging: fbtft: do not allocate huge txbuf [not found] <1f3abe9aabf3fee9d01b5aa8e93859b0f7ed7142.1465484464.git.hramrach@gmail.com> @ 2016-06-09 16:20 ` Noralf Trønnes 2016-06-09 17:18 ` Michal Suchanek 0 siblings, 1 reply; 3+ messages in thread From: Noralf Trønnes @ 2016-06-09 16:20 UTC (permalink / raw) To: Michal Suchanek, Thomas Petazzoni, Greg Kroah-Hartman, devel, linux-kernel Den 09.06.2016 17:08, skrev Michal Suchanek: > txbuflen can be set to arbitrary value by user and it is also set > automagically to the maximum transfer size of the SPI master controller. AFAICT this is a result of your previous patch. Please make a new version of your previous patch with this fix in it. Also make a note in that thread that a new version is made so Greg doesn't pull it when he sees my ack. He handles a large volume of patches so let's make it as easy as we can for him. Thanks, Noralf. > Do not allocate the buffer when larger than vmem. When my SPI master > controller reports maximum transfer size 16M the probe of fbtft fails. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > --- > drivers/staging/fbtft/fbtft-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index f3bdc8f..b95cf69 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -820,6 +820,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, > /* Transmit buffer */ > if (txbuflen == -1) > txbuflen = vmem_size + 2; /* add in case startbyte is used */ > + if (txbuflen >= vmem_size + 2) > + txbuflen = 0; > > #ifdef __LITTLE_ENDIAN > if ((!txbuflen) && (bpp > 8)) ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: do not allocate huge txbuf 2016-06-09 16:20 ` [PATCH] staging: fbtft: do not allocate huge txbuf Noralf Trønnes @ 2016-06-09 17:18 ` Michal Suchanek 2016-06-09 18:42 ` Noralf Trønnes 0 siblings, 1 reply; 3+ messages in thread From: Michal Suchanek @ 2016-06-09 17:18 UTC (permalink / raw) To: Noralf Trønnes Cc: Thomas Petazzoni, Greg Kroah-Hartman, devel, Linux Kernel Mailing List Hello, On 9 June 2016 at 18:20, Noralf Trønnes <noralf@tronnes.org> wrote: > > Den 09.06.2016 17:08, skrev Michal Suchanek: >> >> txbuflen can be set to arbitrary value by user and it is also set >> automagically to the maximum transfer size of the SPI master controller. > > > AFAICT this is a result of your previous patch. Please make a new version of > your previous patch with this fix in it. Also make a note in that thread > that That patch is pretty much independent and just exposes this problem under different circumstances. The txbuflen can be also set by the user. > a new version is made so Greg doesn't pull it when he sees my ack. He > handles a large volume of patches so let's make it as easy as we can for > him. Which would be letting in the patches separately imho. Thanks Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: do not allocate huge txbuf 2016-06-09 17:18 ` Michal Suchanek @ 2016-06-09 18:42 ` Noralf Trønnes 0 siblings, 0 replies; 3+ messages in thread From: Noralf Trønnes @ 2016-06-09 18:42 UTC (permalink / raw) To: Michal Suchanek Cc: Thomas Petazzoni, Greg Kroah-Hartman, devel, Linux Kernel Mailing List [resending got rejected on the list for html format] Den 09.06.2016 19:18, skrev Michal Suchanek: > Hello, > > On 9 June 2016 at 18:20, Noralf Trønnes <noralf@tronnes.org> wrote: >> Den 09.06.2016 17:08, skrev Michal Suchanek: >>> txbuflen can be set to arbitrary value by user and it is also set >>> automagically to the maximum transfer size of the SPI master controller. >> >> AFAICT this is a result of your previous patch. Please make a new version of >> your previous patch with this fix in it. Also make a note in that thread >> that > That patch is pretty much independent and just exposes this problem > under different circumstances. The txbuflen can be also set by the > user. > >> a new version is made so Greg doesn't pull it when he sees my ack. He >> handles a large volume of patches so let's make it as easy as we can for >> him. > Which would be letting in the patches separately imho. Ok, Acked-by: Noralf Trønnes <noralf@tronnes.org> > Thanks > > Michal > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-09 18:42 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1f3abe9aabf3fee9d01b5aa8e93859b0f7ed7142.1465484464.git.hramrach@gmail.com> 2016-06-09 16:20 ` [PATCH] staging: fbtft: do not allocate huge txbuf Noralf Trønnes 2016-06-09 17:18 ` Michal Suchanek 2016-06-09 18:42 ` Noralf Trønnes
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.