* [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
@ 2021-10-12 13:25 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2021-10-12 13:25 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Thomas Hellström, Matthew Auld, intel-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of pointer backup_bo dereferences pointer backup before
backup is null checked, this could lead to a null pointer dereference
issue. Fix this by only assigning backup_bo after backup has been null
checked.
Addresses-Coverity: ("Dereference before null check")
Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 3b6d14b5c604..4ec6c557083a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -149,7 +149,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
struct i915_gem_ttm_pm_apply *pm_apply =
container_of(apply, typeof(*pm_apply), base);
struct drm_i915_gem_object *backup = obj->ttm.backup;
- struct ttm_buffer_object *backup_bo = i915_gem_to_ttm(backup);
+ struct ttm_buffer_object *backup_bo;
struct ttm_operation_ctx ctx = {};
int err;
@@ -163,6 +163,8 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
if (err)
return err;
+ backup_bo = i915_gem_to_ttm(backup);
+
/* Content may have been swapped. */
err = ttm_tt_populate(backup_bo->bdev, backup_bo->ttm, &ctx);
if (!err) {
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
@ 2021-10-12 13:25 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2021-10-12 13:25 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Thomas Hellström, Matthew Auld, intel-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of pointer backup_bo dereferences pointer backup before
backup is null checked, this could lead to a null pointer dereference
issue. Fix this by only assigning backup_bo after backup has been null
checked.
Addresses-Coverity: ("Dereference before null check")
Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 3b6d14b5c604..4ec6c557083a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -149,7 +149,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
struct i915_gem_ttm_pm_apply *pm_apply =
container_of(apply, typeof(*pm_apply), base);
struct drm_i915_gem_object *backup = obj->ttm.backup;
- struct ttm_buffer_object *backup_bo = i915_gem_to_ttm(backup);
+ struct ttm_buffer_object *backup_bo;
struct ttm_operation_ctx ctx = {};
int err;
@@ -163,6 +163,8 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
if (err)
return err;
+ backup_bo = i915_gem_to_ttm(backup);
+
/* Content may have been swapped. */
err = ttm_tt_populate(backup_bo->bdev, backup_bo->ttm, &ctx);
if (!err) {
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix dereference of pointer backup before it is null checked
2021-10-12 13:25 ` [Intel-gfx] " Colin King
(?)
@ 2021-10-12 14:17 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-10-12 14:17 UTC (permalink / raw)
To: Colin King; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9393 bytes --]
== Series Details ==
Series: drm/i915: Fix dereference of pointer backup before it is null checked
URL : https://patchwork.freedesktop.org/series/95723/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10723 -> Patchwork_21319
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/index.html
Known issues
------------
Here are the changes found in Patchwork_21319 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-x1275: NOTRUN -> [SKIP][3] ([fdo#109271]) +28 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-x1275/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@amdgpu/amd_prime@i915-to-amd:
- fi-snb-2520m: NOTRUN -> [SKIP][4] ([fdo#109271]) +37 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-snb-2520m/igt@amdgpu/amd_prime@i915-to-amd.html
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][5] -> [INCOMPLETE][6] ([i915#4221])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
- fi-tgl-1115g4: NOTRUN -> [FAIL][7] ([i915#1888])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-x1275: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-x1275/igt@gem_huc_copy@huc-copy.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][9] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#1155])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-bdw-5557u/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][12] ([fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-skl-guc: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
- fi-bdw-5557u: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-x1275: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-x1275/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-snb-2520m: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][17] ([fdo#109271]) +28 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][18] ([i915#4103]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-x1275: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#533])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-guc: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#533])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][22] ([i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][23] ([i915#3301])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][24] ([i915#3303]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][26] ([i915#2868]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_flip@basic-plain-flip@c-dp1:
- fi-cfl-8109u: [FAIL][28] ([i915#4165]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][30] ([i915#295]) -> [PASS][31] +14 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165
[i915#4221]: https://gitlab.freedesktop.org/drm/intel/issues/4221
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (35 -> 38)
------------------------------
Additional (4): fi-kbl-x1275 fi-skl-guc fi-tgl-1115g4 fi-snb-2520m
Missing (1): fi-bsw-cyan
Build changes
-------------
* Linux: CI_DRM_10723 -> Patchwork_21319
CI-20190529: 20190529
CI_DRM_10723: 574b5d6571aa7e24cde19c5e953a7b1a666267b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6242: 721fd85ee95225ed5df322f7182bdfa9b86a3e68 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21319: 987b61acdd8ca5bc15a5c2d07adab7cd5d9a7b22 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
987b61acdd8c drm/i915: Fix dereference of pointer backup before it is null checked
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/index.html
[-- Attachment #2: Type: text/html, Size: 11760 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
2021-10-12 13:25 ` [Intel-gfx] " Colin King
@ 2021-10-12 14:47 ` Thomas Hellström
-1 siblings, 0 replies; 8+ messages in thread
From: Thomas Hellström @ 2021-10-12 14:47 UTC (permalink / raw)
To: Colin King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Matthew Auld, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Hi,
On 10/12/21 15:25, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of pointer backup_bo dereferences pointer backup before
> backup is null checked, this could lead to a null pointer dereference
> issue. Fix this by only assigning backup_bo after backup has been null
> checked.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
There's not really a pointer dereference here, just pointer arithmetics,
so the code should be safe (but admittedly fragile), so to keep Coverity
happy,
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> index 3b6d14b5c604..4ec6c557083a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> @@ -149,7 +149,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
> struct i915_gem_ttm_pm_apply *pm_apply =
> container_of(apply, typeof(*pm_apply), base);
> struct drm_i915_gem_object *backup = obj->ttm.backup;
> - struct ttm_buffer_object *backup_bo = i915_gem_to_ttm(backup);
> + struct ttm_buffer_object *backup_bo;
> struct ttm_operation_ctx ctx = {};
> int err;
>
> @@ -163,6 +163,8 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
> if (err)
> return err;
>
> + backup_bo = i915_gem_to_ttm(backup);
> +
> /* Content may have been swapped. */
> err = ttm_tt_populate(backup_bo->bdev, backup_bo->ttm, &ctx);
> if (!err) {
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
@ 2021-10-12 14:47 ` Thomas Hellström
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Hellström @ 2021-10-12 14:47 UTC (permalink / raw)
To: Colin King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Matthew Auld, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Hi,
On 10/12/21 15:25, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of pointer backup_bo dereferences pointer backup before
> backup is null checked, this could lead to a null pointer dereference
> issue. Fix this by only assigning backup_bo after backup has been null
> checked.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
There's not really a pointer dereference here, just pointer arithmetics,
so the code should be safe (but admittedly fragile), so to keep Coverity
happy,
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> index 3b6d14b5c604..4ec6c557083a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> @@ -149,7 +149,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
> struct i915_gem_ttm_pm_apply *pm_apply =
> container_of(apply, typeof(*pm_apply), base);
> struct drm_i915_gem_object *backup = obj->ttm.backup;
> - struct ttm_buffer_object *backup_bo = i915_gem_to_ttm(backup);
> + struct ttm_buffer_object *backup_bo;
> struct ttm_operation_ctx ctx = {};
> int err;
>
> @@ -163,6 +163,8 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
> if (err)
> return err;
>
> + backup_bo = i915_gem_to_ttm(backup);
> +
> /* Content may have been swapped. */
> err = ttm_tt_populate(backup_bo->bdev, backup_bo->ttm, &ctx);
> if (!err) {
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
2021-10-12 14:47 ` [Intel-gfx] " Thomas Hellström
@ 2021-10-12 15:12 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2021-10-12 15:12 UTC (permalink / raw)
To: Thomas Hellström
Cc: Colin King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Matthew Auld, intel-gfx, dri-devel,
kernel-janitors, linux-kernel
On Tue, Oct 12, 2021 at 04:47:24PM +0200, Thomas Hellström wrote:
> Hi,
>
> On 10/12/21 15:25, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The assignment of pointer backup_bo dereferences pointer backup before
> > backup is null checked, this could lead to a null pointer dereference
> > issue. Fix this by only assigning backup_bo after backup has been null
> > checked.
> >
> > Addresses-Coverity: ("Dereference before null check")
> > Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> There's not really a pointer dereference here, just pointer arithmetics, so
> the code should be safe (but admittedly fragile), so to keep Coverity happy,
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Yeah. I kind of feel like we shouldn't work around static checker bugs.
But when we do then there shouldn't be a Fixes tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked
@ 2021-10-12 15:12 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2021-10-12 15:12 UTC (permalink / raw)
To: Thomas Hellström
Cc: Colin King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Matthew Auld, intel-gfx, dri-devel,
kernel-janitors, linux-kernel
On Tue, Oct 12, 2021 at 04:47:24PM +0200, Thomas Hellström wrote:
> Hi,
>
> On 10/12/21 15:25, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The assignment of pointer backup_bo dereferences pointer backup before
> > backup is null checked, this could lead to a null pointer dereference
> > issue. Fix this by only assigning backup_bo after backup has been null
> > checked.
> >
> > Addresses-Coverity: ("Dereference before null check")
> > Fixes: c56ce9565374 ("drm/i915 Implement LMEM backup and restore for suspend / resume")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> There's not really a pointer dereference here, just pointer arithmetics, so
> the code should be safe (but admittedly fragile), so to keep Coverity happy,
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Yeah. I kind of feel like we shouldn't work around static checker bugs.
But when we do then there shouldn't be a Fixes tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix dereference of pointer backup before it is null checked
2021-10-12 13:25 ` [Intel-gfx] " Colin King
` (2 preceding siblings ...)
(?)
@ 2021-10-12 19:18 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-10-12 19:18 UTC (permalink / raw)
To: Colin King; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30292 bytes --]
== Series Details ==
Series: drm/i915: Fix dereference of pointer backup before it is null checked
URL : https://patchwork.freedesktop.org/series/95723/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10723_full -> Patchwork_21319_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21319_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21319_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21319_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
Known issues
------------
Here are the changes found in Patchwork_21319_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][4] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@gem_exec_fair@basic-deadline.html
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk2/igt@gem_exec_fair@basic-deadline.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-tglb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][12] -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271]) +220 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-snb2/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#644])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl9/igt@gem_ppgtt@flink-and-close-vma-leak.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl7/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_userptr_blits@input-checking:
- shard-snb: NOTRUN -> [DMESG-WARN][19] ([i915#3002])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-snb6/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][20] ([i915#3318])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#454])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#1902])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@i915_pm_lpsp@screens-disabled.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#111614])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3777])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3777]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#3722]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3886]) +13 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3689] / [i915#3886]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_chamelium@dp-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +11 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-snb6/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl3/igt@kms_color@pipe-c-ctm-0-25.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl8/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +19 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109284] / [fdo#111827])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][38] ([i915#1319])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@legacy:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111828])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3359])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_cursor_crc@pipe-a-cursor-max-size-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([i915#456])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109279] / [i915#3359])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-tglb: [PASS][44] -> [INCOMPLETE][45] ([i915#2411] / [i915#4211])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][46] -> [FAIL][47] ([i915#2346] / [i915#533])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][49] -> [FAIL][50] ([i915#79]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#79])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][53] -> [DMESG-WARN][54] ([i915#180]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [PASS][55] -> [INCOMPLETE][56] ([i915#198]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl7/igt@kms_flip@flip-vs-suspend@b-edp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl1/igt@kms_flip@flip-vs-suspend@b-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][57] -> [DMESG-WARN][58] ([i915#180]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@modeset-vs-vblank-race@c-hdmi-a1:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#407])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk2/igt@kms_flip@modeset-vs-vblank-race@c-hdmi-a1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk9/igt@kms_flip@modeset-vs-vblank-race@c-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-iclb: [PASS][61] -> [SKIP][62] ([i915#3701])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2672])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271]) +23 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#111825]) +5 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271]) +23 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +5 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][72] -> [SKIP][73] ([fdo#109441]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_writeback@writeback-check-output:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#2437])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2437])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl2/igt@kms_writeback@writeback-invalid-parameters.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +271 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl6/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2994])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@sysfs_clients@busy.html
* igt@sysfs_clients@fair-1:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2994])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-skl: [TIMEOUT][80] ([i915#2369] / [i915#3063]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl3/igt@gem_eio@unwedge-stress.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl8/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][82] ([i915#2846]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [SKIP][84] ([fdo#109271]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][86] ([i915#2842]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [FAIL][88] ([i915#2842]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [DMESG-WARN][90] ([i915#118]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk6/igt@gem_exec_whisper@basic-fds-forked.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk7/igt@gem_exec_whisper@basic-fds-forked.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][92] ([i915#180]) -> [PASS][93] +3 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl3/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][94] ([i915#1436] / [i915#716]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@gen9_exec_parse@allowed-single.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][96] ([i915#454]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][98] ([i915#180]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][100] ([i915#79]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][102] ([i915#79]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [INCOMPLETE][104] ([i915#2411] / [i915#456]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-tglb2/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate@c-dp1:
- shard-kbl: [FAIL][106] ([i915#2122]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl7/igt@kms_flip@plain-flip-fb-recreate@c-dp1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl7/igt@kms_flip@plain-flip-fb-recreate@c-dp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][108] ([i915#1188]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][110] ([fdo#108145] / [i915#265]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][112] ([fdo#109441]) -> [PASS][113] +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][114] ([i915#1542]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@perf@polling-parameterized.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl9/igt@perf@polling-parameterized.html
- shard-kbl: [FAIL][116] ([i915#1542]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-kbl1/igt@perf@polling-parameterized.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-kbl4/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][118] ([i915#1804] / [i915#2684]) -> [WARN][119] ([i915#2684])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][120] ([i915#2920]) -> [SKIP][121] ([i915#658]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-iclb: [SKIP][122] ([i915#658]) -> [SKIP][123] ([i915#2920])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@runner@aborted:
- shard-apl: ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#1610] / [i915#180] / [i915#3002] / [i915#3363])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl6/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl8/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl8/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl2/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl6/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl8/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-apl2/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl2/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl1/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl6/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-apl8/igt@runner@aborted.html
- shard-skl: ([FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1436] / [i915#3002] / [i915#3363]) -> ([FAIL][140], [FAIL][141]) ([i915#3002] / [i915#3363])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl3/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10723/shard-skl5/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl8/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/shard-skl4/igt@runner@aborted.html
### Piglit changes ###
#### Issues hit ####
* spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2 with gl_texture_2d_multisample_array:
- pig-skl-6260u: NOTRUN -> [WARN][142] ([mesa#1797]) +1 similar issue
[142]: None
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#111828]: https://bugs.freedesktop.org/show_bug.cgi?id=111828
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1902]: https://gitlab.freedeskto
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21319/index.html
[-- Attachment #2: Type: text/html, Size: 36059 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-10-12 19:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 13:25 [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked Colin King
2021-10-12 13:25 ` [Intel-gfx] " Colin King
2021-10-12 14:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-12 14:47 ` [PATCH][next] " Thomas Hellström
2021-10-12 14:47 ` [Intel-gfx] " Thomas Hellström
2021-10-12 15:12 ` Dan Carpenter
2021-10-12 15:12 ` [Intel-gfx] " Dan Carpenter
2021-10-12 19:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.