All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jon Mason <jon.mason@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support
Date: Sat, 5 Nov 2016 13:33:31 +0300	[thread overview]
Message-ID: <c4a1b943-dce9-805d-30d4-4858b4a6ef23@cogentembedded.com> (raw)
In-Reply-To: <20161104163024.GA6128@broadcom.com>

On 11/4/2016 7:30 PM, Jon Mason wrote:

>>> Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
>>> tree
>>>
>>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>>> ---
>>> arch/arm64/boot/dts/broadcom/ns2-svk.dts |  5 +++++
>>> arch/arm64/boot/dts/broadcom/ns2.dtsi    | 12 ++++++++++++
>>> 2 files changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> index b09f3bc..c4d5442 100644
>>> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> @@ -56,6 +56,10 @@
>>> 	};
>>> };
>>>
>>> +&enet {
>>> +	status = "ok";
>>
>>    The spec dictates it should be "okay" (although "ok" is also recognized).
>
> The rest of the file uses "ok".  So, the addition above is consistent
> with the other entries.
>
> Perhaps a patch outside this series to convert the entire file from
> "ok" to "okay" would be acceptable to you.

    OK, it would...

>
> Thanks,
> Jon

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support
Date: Sat, 5 Nov 2016 13:33:31 +0300	[thread overview]
Message-ID: <c4a1b943-dce9-805d-30d4-4858b4a6ef23@cogentembedded.com> (raw)
In-Reply-To: <20161104163024.GA6128@broadcom.com>

On 11/4/2016 7:30 PM, Jon Mason wrote:

>>> Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
>>> tree
>>>
>>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>>> ---
>>> arch/arm64/boot/dts/broadcom/ns2-svk.dts |  5 +++++
>>> arch/arm64/boot/dts/broadcom/ns2.dtsi    | 12 ++++++++++++
>>> 2 files changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> index b09f3bc..c4d5442 100644
>>> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
>>> @@ -56,6 +56,10 @@
>>> 	};
>>> };
>>>
>>> +&enet {
>>> +	status = "ok";
>>
>>    The spec dictates it should be "okay" (although "ok" is also recognized).
>
> The rest of the file uses "ok".  So, the addition above is consistent
> with the other entries.
>
> Perhaps a patch outside this series to convert the entire file from
> "ok" to "okay" would be acceptable to you.

    OK, it would...

>
> Thanks,
> Jon

MBR, Sergei

  reply	other threads:[~2016-11-05 10:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  5:10 [PATCH v6 0/7] add NS2 support to bgmac Jon Mason
2016-11-04  5:10 ` Jon Mason
2016-11-04  5:10 ` Jon Mason
2016-11-04  5:10 ` [PATCH v6 1/7] net: phy: broadcom: add bcm54xx_auxctl_read Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10 ` [PATCH v6 2/7] Documentation: devicetree: add PHY lane swap binding Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10 ` [PATCH v6 3/7] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10 ` [PATCH v6 4/7] Documentation: devicetree: net: add NS2 bindings to amac Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:10   ` Jon Mason
2016-11-04  5:11 ` [PATCH v6 5/7] net: ethernet: bgmac: device tree phy enablement Jon Mason
2016-11-04  5:11   ` Jon Mason
2016-11-04  6:43   ` Rafal Milecki
2016-11-04  6:43     ` Rafal Milecki
2016-11-04  7:06   ` Rafał Miłecki
2016-11-04  7:06     ` Rafał Miłecki
2016-11-04  7:06     ` Rafał Miłecki
2016-11-04  5:11 ` [PATCH v6 6/7] net: ethernet: bgmac: add NS2 support Jon Mason
2016-11-04  5:11   ` Jon Mason
2016-11-04  5:11   ` Jon Mason
2016-11-04  6:48   ` Rafal Milecki
2016-11-04  6:48     ` Rafal Milecki
2016-11-04  7:07   ` Rafał Miłecki
2016-11-04  7:07     ` Rafał Miłecki
2016-11-04  7:07     ` Rafał Miłecki
2016-11-04  5:11 ` [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support Jon Mason
2016-11-04  5:11   ` Jon Mason
2016-11-04 13:31   ` Sergei Shtylyov
2016-11-04 13:31     ` Sergei Shtylyov
2016-11-04 13:31     ` Sergei Shtylyov
2016-11-04 16:30     ` Jon Mason
2016-11-04 16:30       ` Jon Mason
2016-11-05 10:33       ` Sergei Shtylyov [this message]
2016-11-05 10:33         ` Sergei Shtylyov
2016-11-07 18:11 ` [PATCH v6 0/7] add NS2 support to bgmac David Miller
2016-11-07 18:11   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a1b943-dce9-805d-30d4-4858b4a6ef23@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jon.mason@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.