From: Saeed Mahameed <saeed@kernel.org>
To: Shannon Nelson <snelson@pensando.io>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2 net-next 3/8] ionic: add lif quiesce
Date: Fri, 06 Nov 2020 13:07:23 -0800 [thread overview]
Message-ID: <c4b1c48fc3d6d80f062ff56495a022b83fafd994.camel@kernel.org> (raw)
In-Reply-To: <20201106001220.68130-4-snelson@pensando.io>
On Thu, 2020-11-05 at 16:12 -0800, Shannon Nelson wrote:
> After the queues are stopped, expressly quiesce the lif.
> This assures that even if the queues were in an odd state,
> the firmware will close up everything cleanly.
>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> ---
> .../net/ethernet/pensando/ionic/ionic_lif.c | 24
> +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 519d544821af..990bd9ce93c2 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1625,6 +1625,28 @@ static void ionic_lif_rss_deinit(struct
> ionic_lif *lif)
> ionic_lif_rss_config(lif, 0x0, NULL, NULL);
> }
>
> +static int ionic_lif_quiesce(struct ionic_lif *lif)
Sorry maybe i wasn't clear before,
i mean make this function return a void
static void ionic_lif_quiesce(struct ionic_lif *lif)
> + (void)ionic_lif_quiesce(lif);
I didn't mean to typecast the return value here :)
next prev parent reply other threads:[~2020-11-06 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:12 [PATCH v2 net-next 0/8] ionic updates Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 1/8] ionic: start queues before announcing link up Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 2/8] ionic: check for link after netdev registration Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 3/8] ionic: add lif quiesce Shannon Nelson
2020-11-06 21:07 ` Saeed Mahameed [this message]
2020-11-06 0:12 ` [PATCH v2 net-next 4/8] ionic: batch rx buffer refilling Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 5/8] ionic: use mc sync for multicast filters Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 6/8] ionic: flatten calls to ionic_lif_rx_mode Shannon Nelson
2020-11-06 17:03 ` Jakub Kicinski
2020-11-06 17:17 ` Shannon Nelson
2020-11-06 21:33 ` Saeed Mahameed
2020-11-07 1:17 ` Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 7/8] ionic: change set_rx_mode from_ndo to can_sleep Shannon Nelson
2020-11-06 0:12 ` [PATCH v2 net-next 8/8] ionic: useful names for booleans Shannon Nelson
2020-11-06 21:36 ` [PATCH v2 net-next 0/8] ionic updates Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b1c48fc3d6d80f062ff56495a022b83fafd994.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.