* [PATCH] Input: spear-keyboard - Simplify resource management
@ 2022-01-30 8:20 Christophe JAILLET
2022-01-31 16:15 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-01-30 8:20 UTC (permalink / raw)
To: Dmitry Torokhov, Viresh Kumar
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-input
Since the commit in the Fixes tag below, 'kbd->input' is a managed resource
that doesn't need to be explicitly unregistered or freed (see
devm_input_allocate_device() documentation)
So, remove a unless line of code to slightly simplify it.
Fixes: 6102752eb354 ("Input: spear-keyboard - switch to using managed resources")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
drivers/input/keyboard/spear-keyboard.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index 9838c79cb288..c36836159fb3 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -278,7 +278,6 @@ static int spear_kbd_remove(struct platform_device *pdev)
{
struct spear_kbd *kbd = platform_get_drvdata(pdev);
- input_unregister_device(kbd->input);
clk_unprepare(kbd->clk);
return 0;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: spear-keyboard - Simplify resource management
2022-01-30 8:20 [PATCH] Input: spear-keyboard - Simplify resource management Christophe JAILLET
@ 2022-01-31 16:15 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-01-31 16:15 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Viresh Kumar, linux-kernel, kernel-janitors, linux-input
On Sun, Jan 30, 2022 at 09:20:44AM +0100, Christophe JAILLET wrote:
> Since the commit in the Fixes tag below, 'kbd->input' is a managed resource
> that doesn't need to be explicitly unregistered or freed (see
> devm_input_allocate_device() documentation)
>
> So, remove a unless line of code to slightly simplify it.
>
> Fixes: 6102752eb354 ("Input: spear-keyboard - switch to using managed resources")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/input/keyboard/spear-keyboard.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> index 9838c79cb288..c36836159fb3 100644
> --- a/drivers/input/keyboard/spear-keyboard.c
> +++ b/drivers/input/keyboard/spear-keyboard.c
> @@ -278,7 +278,6 @@ static int spear_kbd_remove(struct platform_device *pdev)
> {
> struct spear_kbd *kbd = platform_get_drvdata(pdev);
>
> - input_unregister_device(kbd->input);
> clk_unprepare(kbd->clk);
This is wrong for the same reason as the other patch: it changes the
order of operations.
>
> return 0;
> --
> 2.32.0
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-31 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 8:20 [PATCH] Input: spear-keyboard - Simplify resource management Christophe JAILLET
2022-01-31 16:15 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.