From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Chao Leng <lengchao@huawei.com>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme-multipath: don't block on blk_queue_enter of the underlying device
Date: Tue, 23 Mar 2021 12:00:34 -0700 [thread overview]
Message-ID: <c4ceed19-cdc5-aeca-0c4b-ebed088e8b82@grimberg.me> (raw)
In-Reply-To: <20210323182244.GA16649@lst.de>
>> The deadlock in this patchset reproduces upstream. It is not possible to
>> update the kernel in the env in the original report.
>>
>> So IFF we assume that this does not reproduce in upstream (pending
>> proof), is there something that we can do with stable fixes? This will
>> probably go back to everything that is before 5.8...
>
> The direct_make_request removal should be pretty easily backportable.
Umm, the direct_make_request removal is based on the submit_bio_noacct
rework you've done. Are you suggesting that we replace it with
generic_make_request for these kernels?
> In old kernels without the streamlined normal path it might cause minor
> performance degradations, but the actual change should be trivial.
That is better than getting stuck in I/O failover...
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Chao Leng <lengchao@huawei.com>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme-multipath: don't block on blk_queue_enter of the underlying device
Date: Tue, 23 Mar 2021 12:00:34 -0700 [thread overview]
Message-ID: <c4ceed19-cdc5-aeca-0c4b-ebed088e8b82@grimberg.me> (raw)
In-Reply-To: <20210323182244.GA16649@lst.de>
>> The deadlock in this patchset reproduces upstream. It is not possible to
>> update the kernel in the env in the original report.
>>
>> So IFF we assume that this does not reproduce in upstream (pending
>> proof), is there something that we can do with stable fixes? This will
>> probably go back to everything that is before 5.8...
>
> The direct_make_request removal should be pretty easily backportable.
Umm, the direct_make_request removal is based on the submit_bio_noacct
rework you've done. Are you suggesting that we replace it with
generic_make_request for these kernels?
> In old kernels without the streamlined normal path it might cause minor
> performance degradations, but the actual change should be trivial.
That is better than getting stuck in I/O failover...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-23 19:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 7:37 fix nvme-tcp and nvme-rdma controller reset hangs when using multipath Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 7:37 ` [PATCH 1/2] blk-mq: add a blk_mq_submit_bio_direct API Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 11:23 ` Hannes Reinecke
2021-03-22 11:23 ` Hannes Reinecke
2021-03-22 15:30 ` Keith Busch
2021-03-22 15:30 ` Keith Busch
2021-03-22 7:37 ` [PATCH 2/2] nvme-multipath: don't block on blk_queue_enter of the underlying device Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 11:22 ` Hannes Reinecke
2021-03-22 11:22 ` Hannes Reinecke
2021-03-22 15:31 ` Keith Busch
2021-03-22 15:31 ` Keith Busch
2021-03-23 2:57 ` Sagi Grimberg
2021-03-23 2:57 ` Sagi Grimberg
2021-03-23 3:23 ` Sagi Grimberg
2021-03-23 3:23 ` Sagi Grimberg
2021-03-23 7:04 ` Chao Leng
2021-03-23 7:04 ` Chao Leng
2021-03-23 7:36 ` Sagi Grimberg
2021-03-23 7:36 ` Sagi Grimberg
2021-03-23 8:13 ` Chao Leng
2021-03-23 8:13 ` Chao Leng
2021-03-23 16:17 ` Christoph Hellwig
2021-03-23 16:17 ` Christoph Hellwig
2021-03-23 16:15 ` Christoph Hellwig
2021-03-23 16:15 ` Christoph Hellwig
2021-03-23 18:13 ` Sagi Grimberg
2021-03-23 18:13 ` Sagi Grimberg
2021-03-23 18:22 ` Christoph Hellwig
2021-03-23 18:22 ` Christoph Hellwig
2021-03-23 19:00 ` Sagi Grimberg [this message]
2021-03-23 19:00 ` Sagi Grimberg
2021-03-23 19:01 ` Christoph Hellwig
2021-03-23 19:01 ` Christoph Hellwig
2021-03-23 19:10 ` Sagi Grimberg
2021-03-23 19:10 ` Sagi Grimberg
2021-03-23 7:28 ` Hannes Reinecke
2021-03-23 7:28 ` Hannes Reinecke
2021-03-23 7:31 ` Sagi Grimberg
2021-03-23 7:31 ` Sagi Grimberg
2021-03-23 8:36 ` Hannes Reinecke
2021-03-23 8:36 ` Hannes Reinecke
2021-03-23 14:53 ` Keith Busch
2021-03-23 14:53 ` Keith Busch
2021-03-23 16:19 ` Christoph Hellwig
2021-03-23 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ceed19-cdc5-aeca-0c4b-ebed088e8b82@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.