All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Dave Young <dyoung@redhat.com>, Andrew Jones <drjones@redhat.com>,
	bhe@redhat.com, qemu-devel@nongnu.org, qiaonuohan@cn.fujitsu.com,
	anderson@redhat.com
Subject: Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support
Date: Mon, 14 Nov 2016 12:08:34 +0100	[thread overview]
Message-ID: <c4ea81a5-5044-48ca-8537-40eda63f014a@redhat.com> (raw)
In-Reply-To: <20161114103342.GI8314@redhat.com>

On 11/14/16 11:33, Daniel P. Berrange wrote:
> On Mon, Nov 14, 2016 at 11:28:04AM +0100, Paolo Bonzini wrote:
>>
>>
>> On 14/11/2016 11:10, Daniel P. Berrange wrote:
>>> There's already patches posted to create a virtio-pstore device for
>>> QEMU, which is what led me to suggest this as an option:
>>>
>>>   https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg00381.html
>>
>> It's also possible to use UEFI as a pstore backend.
> 
> Presumably that'll also require some QEMU patches to provide storage
> for UEFI's pstore ?

Using UEFI non-volatile variables as a pstore backend is a guest kernel
feature, and it already works transparently with OVMF utilizing QEMU's
pflash device. If memory serves, the data to be written are broken into
1KB chunks, and saved as separate UEFI variables under a dedicated
namespace GUID.

https://bugzilla.redhat.com/show_bug.cgi?id=828497

(Private BZ -- I apologize to the non-RedHatter subscribers that read this.)

(Also, not everyone has been enthusiastic about this feature:
<https://bugzilla.redhat.com/show_bug.cgi?id=919485>.)

Anyway, when I say "it works", I mean it works for the direct purpose of
storing data (like saving dmesg at panic), and for retrieving data, from
within the guest. (At a subsequent guest boot, possibly.) This is the
scope of pstore in general, AIUI (see "Documentation/ABI/testing/pstore").

However, host-side insight into the OVMF/edk2 varstore format remains
something we don't, and shouldn't, implement. In this regard, the UEFI
variables that happen to contain pstore data are no different from other
kinds of UEFI variables; they are equally opaque from the host side.
(Unless we want to implement and maintain a large utility that reflects
and tracks the multi-layer variable driver stack in edk2. "Unless" is
rhetorical, we don't want that.)

If host-side access is needed to the guest's phys-base / virt-base, then
my first preference would be the guest agent (interrogated at guest
startup), and my second preference would be virtio-pstore. I reckon
virtio-pstore will take a new guest driver, and I suppose the host-side
on-disk format is being designed for easy parsing.

Thanks
Laszlo

  reply	other threads:[~2016-11-14 11:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  3:01 [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support Dave Young
2016-11-09  3:17 ` Dave Young
2016-11-09  3:58   ` Wen Congyang
2016-11-09  5:02     ` Dave Young
2016-11-09  7:42       ` Wen Congyang
2016-11-09  8:25         ` Dave Young
2016-11-09 14:36       ` Dave Anderson
2016-11-09 14:42         ` Daniel P. Berrange
2016-11-09 10:40 ` Andrew Jones
2016-11-09 11:26   ` Laszlo Ersek
2016-11-09 11:37     ` Daniel P. Berrange
2016-11-09 11:48       ` Andrew Jones
2016-11-09 11:58         ` Daniel P. Berrange
2016-11-09 12:20           ` Andrew Jones
2016-11-09 14:47             ` Daniel P. Berrange
2016-11-09 15:38               ` Laszlo Ersek
2016-11-09 16:01                 ` Daniel P. Berrange
2016-11-14 10:27                   ` Paolo Bonzini
2016-11-14  5:32                 ` Dave Young
2016-11-14  9:47                   ` Andrew Jones
2016-11-16  2:48                     ` Dave Young
2016-11-14 10:10                   ` Daniel P. Berrange
2016-11-14 10:28                     ` Paolo Bonzini
2016-11-14 10:33                       ` Daniel P. Berrange
2016-11-14 11:08                         ` Laszlo Ersek [this message]
2016-11-14 11:55                         ` Paolo Bonzini
2016-11-09 15:28   ` Dave Anderson
2016-11-14 10:41     ` Paolo Bonzini
2016-11-15 14:41       ` Dave Anderson
2016-11-09 14:32 ` Dave Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4ea81a5-5044-48ca-8537-40eda63f014a@redhat.com \
    --to=lersek@redhat.com \
    --cc=anderson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bhe@redhat.com \
    --cc=drjones@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qiaonuohan@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.