[meta-qt5] [PATCH] qtxmlpatterns: add ptest

[meta-qt5] [PATCH] qtxmlpatterns: add ptest

[Huang Qiyu]

Add ptest for qtxmlpatterns by using provided testsuite.

Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
---
 recipes-qt/qt5/qtxmlpatterns/run-ptest |  5 +++++
 recipes-qt/qt5/qtxmlpatterns_git.bb    | 24 ++++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 recipes-qt/qt5/qtxmlpatterns/run-ptest

diff --git a/recipes-qt/qt5/qtxmlpatterns/run-ptest b/recipes-qt/qt5/qtxmlpatterns/run-ptest
new file mode 100644
index 0000000..6c3f522
--- /dev/null
+++ b/recipes-qt/qt5/qtxmlpatterns/run-ptest
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+for x in ` awk '{print $1}' tst_list `;do
+    ./${x};
+done
diff --git a/recipes-qt/qt5/qtxmlpatterns_git.bb b/recipes-qt/qt5/qtxmlpatterns_git.bb
index c7efaf3..bc863de 100644
--- a/recipes-qt/qt5/qtxmlpatterns_git.bb
+++ b/recipes-qt/qt5/qtxmlpatterns_git.bb
@@ -14,8 +14,32 @@ LIC_FILES_CHKSUM = " \
     file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
 "
 
+inherit ptest
+
 DEPENDS += "qtbase"
 
 SRCREV = "9f7e01b582b1bd83cc6b8a854c510871335e2e74"
 
 BBCLASSEXTEND =+ "native nativesdk"
+
+addtask do_populate_sysroot after do_install before do_compile_ptest_base
+deltask do_compile_ptest_base
+addtask do_compile_ptest_base after do_populate_sysroot before do_install_ptest
+addtask do_install_ptest after do_compile_ptest_base before do_package
+
+do_compile_ptest() {
+    cd ${S}/tests
+    qmake -o Makefile tests.pro
+    oe_runmake
+}
+
+fakeroot do_install_ptest() {
+    mkdir -p ${D}${PTEST_PATH}
+    t=${D}${PTEST_PATH}
+    for var in ` find ${S}/tests/auto/ -name tst_*`; do
+        if [ not ` echo ${var##*/} | grep '\.'` ]; then
+            echo ${var##*/} >> ${t}/tst_list
+            install -m 0644 ${var} ${t}
+        fi
+    done
+}
-- 
2.7.4

Re: [meta-qt5] [PATCH] qtxmlpatterns: add ptest

[Samuli Piippo]

Since the code seems to be copy-pasted as is to several modules, it 
really should be moved to a new .bbclass or .inc and inherited/included 
in the modules that support it.

-samuli

On 22.05.2017 08:25, Huang Qiyu wrote:
> Add ptest for qtxmlpatterns by using provided testsuite.
> 
> Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
> ---
>   recipes-qt/qt5/qtxmlpatterns/run-ptest |  5 +++++
>   recipes-qt/qt5/qtxmlpatterns_git.bb    | 24 ++++++++++++++++++++++++
>   2 files changed, 29 insertions(+)
>   create mode 100644 recipes-qt/qt5/qtxmlpatterns/run-ptest
> 
> diff --git a/recipes-qt/qt5/qtxmlpatterns/run-ptest b/recipes-qt/qt5/qtxmlpatterns/run-ptest
> new file mode 100644
> index 0000000..6c3f522
> --- /dev/null
> +++ b/recipes-qt/qt5/qtxmlpatterns/run-ptest
> @@ -0,0 +1,5 @@
> +#!/bin/sh
> +
> +for x in ` awk '{print $1}' tst_list `;do
> +    ./${x};
> +done
> diff --git a/recipes-qt/qt5/qtxmlpatterns_git.bb b/recipes-qt/qt5/qtxmlpatterns_git.bb
> index c7efaf3..bc863de 100644
> --- a/recipes-qt/qt5/qtxmlpatterns_git.bb
> +++ b/recipes-qt/qt5/qtxmlpatterns_git.bb
> @@ -14,8 +14,32 @@ LIC_FILES_CHKSUM = " \
>       file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
>   "
>   
> +inherit ptest
> +
>   DEPENDS += "qtbase"
>   
>   SRCREV = "9f7e01b582b1bd83cc6b8a854c510871335e2e74"
>   
>   BBCLASSEXTEND =+ "native nativesdk"
> +
> +addtask do_populate_sysroot after do_install before do_compile_ptest_base
> +deltask do_compile_ptest_base
> +addtask do_compile_ptest_base after do_populate_sysroot before do_install_ptest
> +addtask do_install_ptest after do_compile_ptest_base before do_package
> +
> +do_compile_ptest() {
> +    cd ${S}/tests
> +    qmake -o Makefile tests.pro
> +    oe_runmake
> +}
> +
> +fakeroot do_install_ptest() {
> +    mkdir -p ${D}${PTEST_PATH}
> +    t=${D}${PTEST_PATH}
> +    for var in ` find ${S}/tests/auto/ -name tst_*`; do
> +        if [ not ` echo ${var##*/} | grep '\.'` ]; then
> +            echo ${var##*/} >> ${t}/tst_list
> +            install -m 0644 ${var} ${t}
> +        fi
> +    done
> +}
> 

Re: [meta-qt5] [PATCH] qtxmlpatterns: add ptest

[Martin Jansa]

Also all 3 fail to build:
http://errors.yoctoproject.org/Errors/Details/143047/
http://errors.yoctoproject.org/Errors/Details/143045/
http://errors.yoctoproject.org/Errors/Details/143044/

On Mon, May 22, 2017 at 8:40 AM, Samuli Piippo <samuli.piippo@gmail.com>
wrote:

> Since the code seems to be copy-pasted as is to several modules, it really
> should be moved to a new .bbclass or .inc and inherited/included in the
> modules that support it.
>
> -samuli
>
>
> On 22.05.2017 08:25, Huang Qiyu wrote:
>
>> Add ptest for qtxmlpatterns by using provided testsuite.
>>
>> Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
>> ---
>>   recipes-qt/qt5/qtxmlpatterns/run-ptest |  5 +++++
>>   recipes-qt/qt5/qtxmlpatterns_git.bb    | 24 ++++++++++++++++++++++++
>>   2 files changed, 29 insertions(+)
>>   create mode 100644 recipes-qt/qt5/qtxmlpatterns/run-ptest
>>
>> diff --git a/recipes-qt/qt5/qtxmlpatterns/run-ptest
>> b/recipes-qt/qt5/qtxmlpatterns/run-ptest
>> new file mode 100644
>> index 0000000..6c3f522
>> --- /dev/null
>> +++ b/recipes-qt/qt5/qtxmlpatterns/run-ptest
>> @@ -0,0 +1,5 @@
>> +#!/bin/sh
>> +
>> +for x in ` awk '{print $1}' tst_list `;do
>> +    ./${x};
>> +done
>> diff --git a/recipes-qt/qt5/qtxmlpatterns_git.bb b/recipes-qt/qt5/
>> qtxmlpatterns_git.bb
>> index c7efaf3..bc863de 100644
>> --- a/recipes-qt/qt5/qtxmlpatterns_git.bb
>> +++ b/recipes-qt/qt5/qtxmlpatterns_git.bb
>> @@ -14,8 +14,32 @@ LIC_FILES_CHKSUM = " \
>>       file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
>>   "
>>   +inherit ptest
>> +
>>   DEPENDS += "qtbase"
>>     SRCREV = "9f7e01b582b1bd83cc6b8a854c510871335e2e74"
>>     BBCLASSEXTEND =+ "native nativesdk"
>> +
>> +addtask do_populate_sysroot after do_install before do_compile_ptest_base
>> +deltask do_compile_ptest_base
>> +addtask do_compile_ptest_base after do_populate_sysroot before
>> do_install_ptest
>> +addtask do_install_ptest after do_compile_ptest_base before do_package
>> +
>> +do_compile_ptest() {
>> +    cd ${S}/tests
>> +    qmake -o Makefile tests.pro
>> +    oe_runmake
>> +}
>> +
>> +fakeroot do_install_ptest() {
>> +    mkdir -p ${D}${PTEST_PATH}
>> +    t=${D}${PTEST_PATH}
>> +    for var in ` find ${S}/tests/auto/ -name tst_*`; do
>> +        if [ not ` echo ${var##*/} | grep '\.'` ]; then
>> +            echo ${var##*/} >> ${t}/tst_list
>> +            install -m 0644 ${var} ${t}
>> +        fi
>> +    done
>> +}
>>
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-qt5] [PATCH] qtxmlpatterns: add ptest

[Huang, Qiyu]

Thanks for your feedback.I will try to reproduce these error and fix them.

huangqy

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Martin Jansa
> Sent: Wednesday, May 24, 2017 5:44 AM
> To: Samuli Piippo <samuli.piippo@gmail.com>
> Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-qt5] [PATCH] qtxmlpatterns: add ptest
> 
> Also all 3 fail to build:
> http://errors.yoctoproject.org/Errors/Details/143047/
> http://errors.yoctoproject.org/Errors/Details/143045/
> http://errors.yoctoproject.org/Errors/Details/143044/
> 
> On Mon, May 22, 2017 at 8:40 AM, Samuli Piippo <samuli.piippo@gmail.com>
> wrote:
> 
> > Since the code seems to be copy-pasted as is to several modules, it
> > really should be moved to a new .bbclass or .inc and
> > inherited/included in the modules that support it.
> >
> > -samuli
> >
> >
> > On 22.05.2017 08:25, Huang Qiyu wrote:
> >
> >> Add ptest for qtxmlpatterns by using provided testsuite.
> >>
> >> Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
> >> ---
> >>   recipes-qt/qt5/qtxmlpatterns/run-ptest |  5 +++++
> >>   recipes-qt/qt5/qtxmlpatterns_git.bb    | 24
> ++++++++++++++++++++++++
> >>   2 files changed, 29 insertions(+)
> >>   create mode 100644 recipes-qt/qt5/qtxmlpatterns/run-ptest
> >>
> >> diff --git a/recipes-qt/qt5/qtxmlpatterns/run-ptest
> >> b/recipes-qt/qt5/qtxmlpatterns/run-ptest
> >> new file mode 100644
> >> index 0000000..6c3f522
> >> --- /dev/null
> >> +++ b/recipes-qt/qt5/qtxmlpatterns/run-ptest
> >> @@ -0,0 +1,5 @@
> >> +#!/bin/sh
> >> +
> >> +for x in ` awk '{print $1}' tst_list `;do
> >> +    ./${x};
> >> +done
> >> diff --git a/recipes-qt/qt5/qtxmlpatterns_git.bb b/recipes-qt/qt5/
> >> qtxmlpatterns_git.bb index c7efaf3..bc863de 100644
> >> --- a/recipes-qt/qt5/qtxmlpatterns_git.bb
> >> +++ b/recipes-qt/qt5/qtxmlpatterns_git.bb
> >> @@ -14,8 +14,32 @@ LIC_FILES_CHKSUM = " \
> >>       file://LICENSE.FDL;md5=6d9f2a9af4c8b8c3c769f6cc1b6aaf7e \
> >>   "
> >>   +inherit ptest
> >> +
> >>   DEPENDS += "qtbase"
> >>     SRCREV = "9f7e01b582b1bd83cc6b8a854c510871335e2e74"
> >>     BBCLASSEXTEND =+ "native nativesdk"
> >> +
> >> +addtask do_populate_sysroot after do_install before
> >> +do_compile_ptest_base deltask do_compile_ptest_base addtask
> >> +do_compile_ptest_base after do_populate_sysroot before
> >> do_install_ptest
> >> +addtask do_install_ptest after do_compile_ptest_base before
> >> +do_package
> >> +
> >> +do_compile_ptest() {
> >> +    cd ${S}/tests
> >> +    qmake -o Makefile tests.pro
> >> +    oe_runmake
> >> +}
> >> +
> >> +fakeroot do_install_ptest() {
> >> +    mkdir -p ${D}${PTEST_PATH}
> >> +    t=${D}${PTEST_PATH}
> >> +    for var in ` find ${S}/tests/auto/ -name tst_*`; do
> >> +        if [ not ` echo ${var##*/} | grep '\.'` ]; then
> >> +            echo ${var##*/} >> ${t}/tst_list
> >> +            install -m 0644 ${var} ${t}
> >> +        fi
> >> +    done
> >> +}
> >>
> >>
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>