All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
@ 2022-09-27 13:26 ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-27 13:26 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Russell King, Linus Walleij, Ard Biesheuvel, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel,
	Geert Uytterhoeven

On older platforms that boot an image with an appended DTB, or where
the boot loader has no support for updating chosen/bootargs, it is
common to rely on CMDLINE_FORCE.

While a fixed command line can make the kernel unbootable on other
platforms, it is not guaranteed to cause that.  E.g. all Renesas boards
use the same chosen/bootargs in upstream DTS, which works fine if your
DHCP server hands out proper nfsroot parameters.

Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 22f62ad919bfd831..ea8adbf25651438a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND
 
 config CMDLINE_FORCE
 	bool "Always use the default kernel command string"
-	depends on !ARCH_MULTIPLATFORM
 	help
 	  Always use the default kernel command string, even if the boot
 	  loader passes other arguments to the kernel.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
@ 2022-09-27 13:26 ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-27 13:26 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Russell King, Linus Walleij, Ard Biesheuvel, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel,
	Geert Uytterhoeven

On older platforms that boot an image with an appended DTB, or where
the boot loader has no support for updating chosen/bootargs, it is
common to rely on CMDLINE_FORCE.

While a fixed command line can make the kernel unbootable on other
platforms, it is not guaranteed to cause that.  E.g. all Renesas boards
use the same chosen/bootargs in upstream DTS, which works fine if your
DHCP server hands out proper nfsroot parameters.

Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 22f62ad919bfd831..ea8adbf25651438a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND
 
 config CMDLINE_FORCE
 	bool "Always use the default kernel command string"
-	depends on !ARCH_MULTIPLATFORM
 	help
 	  Always use the default kernel command string, even if the boot
 	  loader passes other arguments to the kernel.
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
  2022-09-27 13:26 ` Geert Uytterhoeven
@ 2022-09-27 13:35   ` Ard Biesheuvel
  -1 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2022-09-27 13:35 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Arnd Bergmann, Russell King, Linus Walleij, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel

On Tue, 27 Sept 2022 at 15:26, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> On older platforms that boot an image with an appended DTB, or where
> the boot loader has no support for updating chosen/bootargs, it is
> common to rely on CMDLINE_FORCE.
>
> While a fixed command line can make the kernel unbootable on other
> platforms, it is not guaranteed to cause that.  E.g. all Renesas boards
> use the same chosen/bootargs in upstream DTS, which works fine if your
> DHCP server hands out proper nfsroot parameters.
>
> Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 22f62ad919bfd831..ea8adbf25651438a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND
>
>  config CMDLINE_FORCE
>         bool "Always use the default kernel command string"
> -       depends on !ARCH_MULTIPLATFORM
>         help
>           Always use the default kernel command string, even if the boot
>           loader passes other arguments to the kernel.
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
@ 2022-09-27 13:35   ` Ard Biesheuvel
  0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2022-09-27 13:35 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Arnd Bergmann, Russell King, Linus Walleij, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel

On Tue, 27 Sept 2022 at 15:26, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> On older platforms that boot an image with an appended DTB, or where
> the boot loader has no support for updating chosen/bootargs, it is
> common to rely on CMDLINE_FORCE.
>
> While a fixed command line can make the kernel unbootable on other
> platforms, it is not guaranteed to cause that.  E.g. all Renesas boards
> use the same chosen/bootargs in upstream DTS, which works fine if your
> DHCP server hands out proper nfsroot parameters.
>
> Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 22f62ad919bfd831..ea8adbf25651438a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND
>
>  config CMDLINE_FORCE
>         bool "Always use the default kernel command string"
> -       depends on !ARCH_MULTIPLATFORM
>         help
>           Always use the default kernel command string, even if the boot
>           loader passes other arguments to the kernel.
> --
> 2.25.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
  2022-09-27 13:26 ` Geert Uytterhoeven
  (?)
  (?)
@ 2022-09-28 21:00 ` patchwork-bot+linux-soc
  -1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-soc @ 2022-09-28 21:00 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Tue, 27 Sep 2022 15:26:26 +0200 you wrote:
> On older platforms that boot an image with an appended DTB, or where
> the boot loader has no support for updating chosen/bootargs, it is
> common to rely on CMDLINE_FORCE.
> 
> While a fixed command line can make the kernel unbootable on other
> platforms, it is not guaranteed to cause that.  E.g. all Renesas boards
> use the same chosen/bootargs in upstream DTS, which works fine if your
> DHCP server hands out proper nfsroot parameters.
> 
> [...]

Here is the summary with links:
  - ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM
    https://git.kernel.org/soc/soc/c/502647105a1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-28 21:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 13:26 [PATCH] ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM Geert Uytterhoeven
2022-09-27 13:26 ` Geert Uytterhoeven
2022-09-27 13:35 ` Ard Biesheuvel
2022-09-27 13:35   ` Ard Biesheuvel
2022-09-28 21:00 ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.