* [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE
@ 2018-01-28 14:49 Fabio Estevam
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-01-28 14:49 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
Selecting CONFIG_USB_FUNCTION_MASS_STORAGE=y in the defconfig leads to
the following error:
cmd/built-in.o: In function `do_usb_mass_storage':
cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
CONFIG_USB_FUNCTION_MASS_STORAGE option is built only for
the non-SPL case as per the logic in drivers/usb/gadget/Makefile,
so remove the incorrect CONFIG_SPL ifdefery to fix the build
failure.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
include/configs/mx6sabre_common.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index f083dc8..42e650a 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -208,10 +208,8 @@
#define CONFIG_IMX_HDMI
#define CONFIG_IMX_VIDEO_SKIP
-#ifndef CONFIG_SPL
#define CONFIG_USBD_HS
#define CONFIG_USB_FUNCTION_MASS_STORAGE
-#endif
#endif /* __MX6QSABRE_COMMON_CONFIG_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE
2018-01-28 14:49 [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Fabio Estevam
@ 2018-01-28 14:49 ` Fabio Estevam
2018-02-04 10:15 ` Stefano Babic
2018-01-29 1:56 ` [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Shawn Guo
2018-02-04 10:15 ` Stefano Babic
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2018-01-28 14:49 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
Select CONFIG_CMD_USB_MASS_STORAGE so that the 'ums' can be used.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
configs/mx6sabresd_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
index 3e4c13c..f6a53d6 100644
--- a/configs/mx6sabresd_defconfig
+++ b/configs/mx6sabresd_defconfig
@@ -32,6 +32,7 @@ CONFIG_CMD_PCI=y
CONFIG_CMD_SF=y
CONFIG_CMD_USB=y
CONFIG_CMD_USB_SDP=y
+CONFIG_CMD_USB_MASS_STORAGE=y
CONFIG_CMD_DHCP=y
CONFIG_CMD_MII=y
CONFIG_CMD_PING=y
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE
2018-01-28 14:49 [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Fabio Estevam
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
@ 2018-01-29 1:56 ` Shawn Guo
2018-02-04 10:15 ` Stefano Babic
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2018-01-29 1:56 UTC (permalink / raw)
To: u-boot
On Sun, Jan 28, 2018 at 12:49:02PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Selecting CONFIG_USB_FUNCTION_MASS_STORAGE=y in the defconfig leads to
> the following error:
>
> cmd/built-in.o: In function `do_usb_mass_storage':
> cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
> cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
>
> CONFIG_USB_FUNCTION_MASS_STORAGE option is built only for
> the non-SPL case as per the logic in drivers/usb/gadget/Makefile,
> so remove the incorrect CONFIG_SPL ifdefery to fix the build
> failure.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
For both patches on imx6q-sabresd board,
Tested-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE
2018-01-28 14:49 [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Fabio Estevam
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
2018-01-29 1:56 ` [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Shawn Guo
@ 2018-02-04 10:15 ` Stefano Babic
2 siblings, 0 replies; 5+ messages in thread
From: Stefano Babic @ 2018-02-04 10:15 UTC (permalink / raw)
To: u-boot
On 28/01/2018 15:49, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Selecting CONFIG_USB_FUNCTION_MASS_STORAGE=y in the defconfig leads to
> the following error:
>
> cmd/built-in.o: In function `do_usb_mass_storage':
> cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
> cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
>
> CONFIG_USB_FUNCTION_MASS_STORAGE option is built only for
> the non-SPL case as per the logic in drivers/usb/gadget/Makefile,
> so remove the incorrect CONFIG_SPL ifdefery to fix the build
> failure.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> include/configs/mx6sabre_common.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
> index f083dc8..42e650a 100644
> --- a/include/configs/mx6sabre_common.h
> +++ b/include/configs/mx6sabre_common.h
> @@ -208,10 +208,8 @@
> #define CONFIG_IMX_HDMI
> #define CONFIG_IMX_VIDEO_SKIP
>
> -#ifndef CONFIG_SPL
> #define CONFIG_USBD_HS
>
> #define CONFIG_USB_FUNCTION_MASS_STORAGE
> -#endif
>
> #endif /* __MX6QSABRE_COMMON_CONFIG_H */
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
@ 2018-02-04 10:15 ` Stefano Babic
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Babic @ 2018-02-04 10:15 UTC (permalink / raw)
To: u-boot
On 28/01/2018 15:49, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Select CONFIG_CMD_USB_MASS_STORAGE so that the 'ums' can be used.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> configs/mx6sabresd_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
> index 3e4c13c..f6a53d6 100644
> --- a/configs/mx6sabresd_defconfig
> +++ b/configs/mx6sabresd_defconfig
> @@ -32,6 +32,7 @@ CONFIG_CMD_PCI=y
> CONFIG_CMD_SF=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_USB_SDP=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
> CONFIG_CMD_DHCP=y
> CONFIG_CMD_MII=y
> CONFIG_CMD_PING=y
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-04 10:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-28 14:49 [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Fabio Estevam
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
2018-02-04 10:15 ` Stefano Babic
2018-01-29 1:56 ` [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Shawn Guo
2018-02-04 10:15 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.