* [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
@ 2020-04-21 2:41 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-04-21 2:41 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, andrey.grodzovsky
Cc: amd-gfx, dri-devel, linux-kernel, YueHaibing
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
left behind this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 35c381ec0423..47207188c569 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
void *owner, struct dma_fence **f)
{
- enum drm_sched_priority priority;
int r;
if (!f)
@@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
*f = dma_fence_get(&job->base.s_fence->finished);
amdgpu_job_free_resources(job);
- priority = job->base.s_priority;
drm_sched_entity_push_job(&job->base, entity);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
@ 2020-04-21 2:41 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-04-21 2:41 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, andrey.grodzovsky
Cc: YueHaibing, dri-devel, amd-gfx, linux-kernel
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
left behind this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 35c381ec0423..47207188c569 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
void *owner, struct dma_fence **f)
{
- enum drm_sched_priority priority;
int r;
if (!f)
@@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
*f = dma_fence_get(&job->base.s_fence->finished);
amdgpu_job_free_resources(job);
- priority = job->base.s_priority;
drm_sched_entity_push_job(&job->base, entity);
return 0;
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
@ 2020-04-21 2:41 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-04-21 2:41 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, David1.Zhou, airlied,
daniel, andrey.grodzovsky
Cc: YueHaibing, dri-devel, amd-gfx, linux-kernel
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
left behind this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 35c381ec0423..47207188c569 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
void *owner, struct dma_fence **f)
{
- enum drm_sched_priority priority;
int r;
if (!f)
@@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
*f = dma_fence_get(&job->base.s_fence->finished);
amdgpu_job_free_resources(job);
- priority = job->base.s_priority;
drm_sched_entity_push_job(&job->base, entity);
return 0;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
2020-04-21 2:41 ` YueHaibing
(?)
@ 2020-04-21 7:14 ` Christian König
-1 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2020-04-21 7:14 UTC (permalink / raw)
To: YueHaibing, alexander.deucher, David1.Zhou, airlied, daniel,
andrey.grodzovsky
Cc: amd-gfx, dri-devel, linux-kernel
Am 21.04.20 um 04:41 schrieb YueHaibing:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
>
> commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 35c381ec0423..47207188c569 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
> int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
> void *owner, struct dma_fence **f)
> {
> - enum drm_sched_priority priority;
> int r;
>
> if (!f)
> @@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
>
> *f = dma_fence_get(&job->base.s_fence->finished);
> amdgpu_job_free_resources(job);
> - priority = job->base.s_priority;
> drm_sched_entity_push_job(&job->base, entity);
>
> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
@ 2020-04-21 7:14 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2020-04-21 7:14 UTC (permalink / raw)
To: YueHaibing, alexander.deucher, David1.Zhou, airlied, daniel,
andrey.grodzovsky
Cc: dri-devel, amd-gfx, linux-kernel
Am 21.04.20 um 04:41 schrieb YueHaibing:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
>
> commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 35c381ec0423..47207188c569 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
> int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
> void *owner, struct dma_fence **f)
> {
> - enum drm_sched_priority priority;
> int r;
>
> if (!f)
> @@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
>
> *f = dma_fence_get(&job->base.s_fence->finished);
> amdgpu_job_free_resources(job);
> - priority = job->base.s_priority;
> drm_sched_entity_push_job(&job->base, entity);
>
> return 0;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'
@ 2020-04-21 7:14 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2020-04-21 7:14 UTC (permalink / raw)
To: YueHaibing, alexander.deucher, David1.Zhou, airlied, daniel,
andrey.grodzovsky
Cc: dri-devel, amd-gfx, linux-kernel
Am 21.04.20 um 04:41 schrieb YueHaibing:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
>
> commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 35c381ec0423..47207188c569 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
> int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
> void *owner, struct dma_fence **f)
> {
> - enum drm_sched_priority priority;
> int r;
>
> if (!f)
> @@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
>
> *f = dma_fence_get(&job->base.s_fence->finished);
> amdgpu_job_free_resources(job);
> - priority = job->base.s_priority;
> drm_sched_entity_push_job(&job->base, entity);
>
> return 0;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-21 7:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 2:41 [PATCH -next] drm/amdgpu: remove set but not used variable 'priority' YueHaibing
2020-04-21 2:41 ` YueHaibing
2020-04-21 2:41 ` YueHaibing
2020-04-21 7:14 ` Christian König
2020-04-21 7:14 ` Christian König
2020-04-21 7:14 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.