Re: [PATCH v3 4/6] xen: Switch to byteswap

From: Julien Grall <julien@xen.org>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: "Lin Liu （刘林）" <lin.liu@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Andrew Cooper" <Andrew.Cooper3@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>, "Wei Liu" <wl@xen.org>
Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap
Date: Wed, 11 May 2022 13:39:27 +0100	[thread overview]
Message-ID: <c61e4d5c-ef97-09f8-b57f-e874302291a4@xen.org> (raw)
In-Reply-To: <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com>

Hi George,

On 11/05/2022 13:11, George Dunlap wrote:
>>> Google told me __force is used in linux kernel to suppress warning in sparse,
>>> https://stackoverflow.com/questions/53120610/what-does-the-attribute-force-do
>>> Is sparse also used in xen?
>>
>> I am not aware of any use of Sparse in Xen, but it would technically be possible.
>>
>> However, my point here is more that this change seems to be unrelated to what the patch is meant to do (i.e. switching to byteswap). So if it is unnecessary, then it should be dropped from this patch.
> 
> I think making people pull little changes like this out into separate patches is asking too much.  It’s a lot of extra effort on the part of the submitter for basically no value.  We commonly do little clean-ups like this in patches, and just require a comment at the bottom, like this:

I suggested to drop from the patch because I don't think we should 
remove the __force. In fact, I have contemplated a few times in the past 
to use sparse in Xen.

Sorry I should have been clearer.

Cheers,

-- 
Julien Grall