[PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol includes mouse support

[PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol includes mouse support

[George Dunlap]

s/fo/fo; while we're here.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
This is a candidate for backport to 4.10.

CC: Ian Jackson <ian.jackson@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Konrad Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
CC: Anthony Perard <anthony.perard@citrix.com>
CC: Paul Durrant <paul.durrant@citrix.com>
CC: Lars Kurth <lars.kurth@citrix.com>
---
 SUPPORT.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index a1810b8046..87d07129b4 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -380,7 +380,8 @@ Guest-side driver capable of speaking the Xen PV console protocol
 
     Status, Linux (xen-kbdfront): Supported
 
-Guest-side driver capable of speaking the Xen PV keyboard protocol
+Guest-side driver capable of speaking the Xen PV keyboard protocol.
+Note that the "keyboard protocol" includes mouse / pointer support as well.
 
 ### PV USB (frontend)
 
@@ -451,7 +452,8 @@ Host-side implementation of the Xen PV console protocol
 
     Status, QEMU: Supported
 
-Host-side implementation fo the Xen PV keyboard protocol
+Host-side implementation of the Xen PV keyboard protocol.
+Note that the "keyboard protocol" includes mouse / pointer support as well.
 
 ### PV USB (backend)
 
-- 
2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 2/3] SUPPORT.md: Specify support for various image formats

[George Dunlap]

QEMU supports various image formats, but we only provide security
support for raw, qcow, qcow2, and vhd formats.

Rather than duplicate this information under the "x86/Emulated
storage" section, just refer to the "Blkback" section.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
This is a candidate for backport to 4.10.

Other option I explored was giving each format its own entry, like
this:

#### Image format: Raw

    Status, Linux (xen-blkback): Supported
    Status, QEMU (xen_disk): Supported
    Status, FreeBSD (blkback): Supported, Security support external
    Status, NetBSD (xbdback): Supported, security support external
    Status, Blktap2: Deprecated

But that led to a lot of duplication (Everything is listed as
"supported" once under "Blkback", and once under "Image format: Raw").

CC: Ian Jackson <ian.jackson@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Konrad Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>
CC: Lars Kurth <lars.kurth@citrix.com>
---
 SUPPORT.md | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 87d07129b4..ee65d45b24 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -421,12 +421,17 @@ unless otherwise noted.
 ### Blkback
 
     Status, Linux (xen-blkback): Supported
-    Status, QEMU (xen_disk): Supported
+    Status, QEMU (xen_disk), raw format: Supported
+    Status, QEMU (xen_disk), qcow format: Supported
+    Status, QEMU (xen_disk), qcow2 format: Supported
+    Status, QEMU (xen_disk), vhd format: Supported
     Status, FreeBSD (blkback): Supported, Security support external
     Status, NetBSD (xbdback): Supported, security support external
-    Status, Blktap2: Deprecated
+    Status, Blktap2, raw format: Deprecated
+    Status, Blktap2, vhd format: Deprecated
 
-Host-side implementations of the Xen PV block protocol
+Host-side implementations of the Xen PV block protocol.
+Backends only support raw format unless otherwise specified.
 
 ### Netback
 
@@ -634,6 +639,8 @@ Note that other devices are available but not security supported.
 
     Status, piix3 ide: Supported
     Status, ahci: Supported
+	
+See the section **Blkback** for image formats supported by QEMU.
 
 ### x86/Emulated graphics (QEMU):
 
-- 
2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 3/3] docs: Remove redundant qemu-xen-security document

[George Dunlap]

All this information is now covered in SUPPORT.md.

Most of the emulated hardware is obvious a couple of the items are
worth pointing out specifically.

"xen_disk" is listed under "Blkback"

"...the PCI host bridge and the PIIX3 chipset...": This statement is
redundant -- the PCI host bridge is a part of the piix3 chipset, which
is listed as supported.

xenfb: The "graphics" side of "xenfb" is listed under "PV Framebuffer
(backend)", and the "input" side of "xenfb" (including both keyboard
and mouse) is listed under "PV Keyboard (backend)".

Backing storage image format is listed in the "Blkback" section.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Konrad Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
CC: Anthony Perard <anthony.perard@citrix.com>
CC: Lars Kurth <lars.kurth@citrix.com>
---
 docs/misc/qemu-xen-security | 21 ---------------------
 1 file changed, 21 deletions(-)
 delete mode 100644 docs/misc/qemu-xen-security

diff --git a/docs/misc/qemu-xen-security b/docs/misc/qemu-xen-security
deleted file mode 100644
index 496f7eee7a..0000000000
--- a/docs/misc/qemu-xen-security
+++ /dev/null
@@ -1,21 +0,0 @@
-qemu-xen (git://xenbits.xen.org/qemu-xen.git) is only supported for
-security fixes when used together with the Xen hypervisor and only with
-a subset of all the possible QEMU emulators. Specifically:
-
-- network: e1000, rtl8139, virtio-net
-- storage: piix3 ide, ahci, xen_disk
-- backing storage image format: raw, qcow, qcow2, vhd
-- graphics: cirris-vga, stdvga and xenfb
-- audio: sb16, es1370, ac97
-- input: Xen PV keyboard and mouse (part of xenfb), USB and PS/2
-         keyboard and mouse
-- serial cards: UART 16550A
-
-Core components, such as the PCI host bridge and the PIIX3 chipset, are
-supported. All devices of one the above classes, which are not explicitly
-mentioned, are not supported. For example the ne2000 network card is not
-supported. 
-
-If you think that a specific emulated device should be supported, please
-contact the QEMU UPSTREAM maintainer and the Xen Security Team
-(security@xenproject.org).
-- 
2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol includes mouse support

[Paul Durrant]

> -----Original Message-----
> From: George Dunlap [mailto:george.dunlap@citrix.com]
> Sent: 09 March 2018 18:04
> To: xen-devel@lists.xenproject.org
> Cc: George Dunlap <George.Dunlap@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; Jan Beulich <jbeulich@suse.com>; Tim
> (Xen.org) <tim@xen.org>; Konrad Wilk <konrad.wilk@oracle.com>; Stefano
> Stabellini <sstabellini@kernel.org>; Julien Grall <julien.grall@arm.com>;
> Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Lars Kurth <lars.kurth@citrix.com>
> Subject: [PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol
> includes mouse support
> 
> s/fo/fo; while we're here.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

> ---
> This is a candidate for backport to 4.10.
> 
> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Konrad Wilk <konrad.wilk@oracle.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Anthony Perard <anthony.perard@citrix.com>
> CC: Paul Durrant <paul.durrant@citrix.com>
> CC: Lars Kurth <lars.kurth@citrix.com>
> ---
>  SUPPORT.md | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index a1810b8046..87d07129b4 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -380,7 +380,8 @@ Guest-side driver capable of speaking the Xen PV
> console protocol
> 
>      Status, Linux (xen-kbdfront): Supported
> 
> -Guest-side driver capable of speaking the Xen PV keyboard protocol
> +Guest-side driver capable of speaking the Xen PV keyboard protocol.
> +Note that the "keyboard protocol" includes mouse / pointer support as
> well.
> 
>  ### PV USB (frontend)
> 
> @@ -451,7 +452,8 @@ Host-side implementation of the Xen PV console
> protocol
> 
>      Status, QEMU: Supported
> 
> -Host-side implementation fo the Xen PV keyboard protocol
> +Host-side implementation of the Xen PV keyboard protocol.
> +Note that the "keyboard protocol" includes mouse / pointer support as
> well.
> 
>  ### PV USB (backend)
> 
> --
> 2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/3] docs: Remove redundant qemu-xen-security document

[Stefano Stabellini]

On Fri, 9 Mar 2018, George Dunlap wrote:
> All this information is now covered in SUPPORT.md.
> 
> Most of the emulated hardware is obvious a couple of the items are
> worth pointing out specifically.
> 
> "xen_disk" is listed under "Blkback"
> 
> "...the PCI host bridge and the PIIX3 chipset...": This statement is
> redundant -- the PCI host bridge is a part of the piix3 chipset, which
> is listed as supported.
> 
> xenfb: The "graphics" side of "xenfb" is listed under "PV Framebuffer
> (backend)", and the "input" side of "xenfb" (including both keyboard
> and mouse) is listed under "PV Keyboard (backend)".
> 
> Backing storage image format is listed in the "Blkback" section.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

One thing: stdvga is still mispelled in SUPPORT.md.
Anything else is fine.



> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Konrad Wilk <konrad.wilk@oracle.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Anthony Perard <anthony.perard@citrix.com>
> CC: Lars Kurth <lars.kurth@citrix.com>
> ---
>  docs/misc/qemu-xen-security | 21 ---------------------
>  1 file changed, 21 deletions(-)
>  delete mode 100644 docs/misc/qemu-xen-security
> 
> diff --git a/docs/misc/qemu-xen-security b/docs/misc/qemu-xen-security
> deleted file mode 100644
> index 496f7eee7a..0000000000
> --- a/docs/misc/qemu-xen-security
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -qemu-xen (git://xenbits.xen.org/qemu-xen.git) is only supported for
> -security fixes when used together with the Xen hypervisor and only with
> -a subset of all the possible QEMU emulators. Specifically:
> -
> -- network: e1000, rtl8139, virtio-net
> -- storage: piix3 ide, ahci, xen_disk
> -- backing storage image format: raw, qcow, qcow2, vhd
> -- graphics: cirris-vga, stdvga and xenfb
> -- audio: sb16, es1370, ac97
> -- input: Xen PV keyboard and mouse (part of xenfb), USB and PS/2
> -         keyboard and mouse
> -- serial cards: UART 16550A
> -
> -Core components, such as the PCI host bridge and the PIIX3 chipset, are
> -supported. All devices of one the above classes, which are not explicitly
> -mentioned, are not supported. For example the ne2000 network card is not
> -supported. 
> -
> -If you think that a specific emulated device should be supported, please
> -contact the QEMU UPSTREAM maintainer and the Xen Security Team
> -(security@xenproject.org).
> -- 
> 2.16.2
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/3] docs: Remove redundant qemu-xen-security document

[George Dunlap]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On 03/11/2018 08:29 PM, Stefano Stabellini wrote:
> On Fri, 9 Mar 2018, George Dunlap wrote:
>> All this information is now covered in SUPPORT.md.
>>
>> Most of the emulated hardware is obvious a couple of the items are
>> worth pointing out specifically.
>>
>> "xen_disk" is listed under "Blkback"
>>
>> "...the PCI host bridge and the PIIX3 chipset...": This statement is
>> redundant -- the PCI host bridge is a part of the piix3 chipset, which
>> is listed as supported.
>>
>> xenfb: The "graphics" side of "xenfb" is listed under "PV Framebuffer
>> (backend)", and the "input" side of "xenfb" (including both keyboard
>> and mouse) is listed under "PV Keyboard (backend)".
>>
>> Backing storage image format is listed in the "Blkback" section.
>>
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> One thing: stdvga is still mispelled in SUPPORT.md.
> Anything else is fine.

So it is.  What about the attached?

 -George

[-- Attachment #2: 0001-docs-Remove-redundant-qemu-xen-security-document.patch --]
[-- Type: text/x-patch, Size: 3065 bytes --]

>From 6b41d5c33b95f55fd16b259f58a3852a6cce13f9 Mon Sep 17 00:00:00 2001
From: George Dunlap <george.dunlap@citrix.com>
Date: Fri, 9 Mar 2018 11:04:18 +0000
Subject: [PATCH] docs: Remove redundant qemu-xen-security document

All this information is now covered in SUPPORT.md.

Most of the emulated hardware is obvious a couple of the items are
worth pointing out specifically.

"xen_disk" is listed under "Blkback"

"...the PCI host bridge and the PIIX3 chipset...": This statement is
redundant -- the PCI host bridge is a part of the piix3 chipset, which
is listed as supported.

xenfb: The "graphics" side of "xenfb" is listed under "PV Framebuffer
(backend)", and the "input" side of "xenfb" (including both keyboard
and mouse) is listed under "PV Keyboard (backend)".

Backing storage image format is listed in the "Blkback" section.

Fix 'stdvga' spelling while we're here.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
v2:
- Fix stdvgga spelling.

CC: Ian Jackson <ian.jackson@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Konrad Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
CC: Anthony Perard <anthony.perard@citrix.com>
CC: Lars Kurth <lars.kurth@citrix.com>
---
 SUPPORT.md                  |  2 +-
 docs/misc/qemu-xen-security | 21 ---------------------
 2 files changed, 1 insertion(+), 22 deletions(-)
 delete mode 100644 docs/misc/qemu-xen-security

diff --git a/SUPPORT.md b/SUPPORT.md
index ee65d45b24..9ac1a40036 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -645,7 +645,7 @@ See the section **Blkback** for image formats supported by QEMU.
 ### x86/Emulated graphics (QEMU):
 
     Status, cirrus-vga: Supported
-    Status, stgvga: Supported
+    Status, stdvga: Supported
 
 ### x86/Emulated audio (QEMU):
 
diff --git a/docs/misc/qemu-xen-security b/docs/misc/qemu-xen-security
deleted file mode 100644
index 496f7eee7a..0000000000
--- a/docs/misc/qemu-xen-security
+++ /dev/null
@@ -1,21 +0,0 @@
-qemu-xen (git://xenbits.xen.org/qemu-xen.git) is only supported for
-security fixes when used together with the Xen hypervisor and only with
-a subset of all the possible QEMU emulators. Specifically:
-
-- network: e1000, rtl8139, virtio-net
-- storage: piix3 ide, ahci, xen_disk
-- backing storage image format: raw, qcow, qcow2, vhd
-- graphics: cirris-vga, stdvga and xenfb
-- audio: sb16, es1370, ac97
-- input: Xen PV keyboard and mouse (part of xenfb), USB and PS/2
-         keyboard and mouse
-- serial cards: UART 16550A
-
-Core components, such as the PCI host bridge and the PIIX3 chipset, are
-supported. All devices of one the above classes, which are not explicitly
-mentioned, are not supported. For example the ne2000 network card is not
-supported. 
-
-If you think that a specific emulated device should be supported, please
-contact the QEMU UPSTREAM maintainer and the Xen Security Team
-(security@xenproject.org).
-- 
2.16.2


[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol includes mouse support

[Jan Beulich]

>>> On 11.03.18 at 16:26, <Paul.Durrant@citrix.com> wrote:
>>  -----Original Message-----
>> From: George Dunlap [mailto:george.dunlap@citrix.com]
>> Sent: 09 March 2018 18:04
>> To: xen-devel@lists.xenproject.org 
>> Cc: George Dunlap <George.Dunlap@citrix.com>; Ian Jackson
>> <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Andrew Cooper
>> <Andrew.Cooper3@citrix.com>; Jan Beulich <jbeulich@suse.com>; Tim
>> (Xen.org) <tim@xen.org>; Konrad Wilk <konrad.wilk@oracle.com>; Stefano
>> Stabellini <sstabellini@kernel.org>; Julien Grall <julien.grall@arm.com>;
>> Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
>> <Paul.Durrant@citrix.com>; Lars Kurth <lars.kurth@citrix.com>
>> Subject: [PATCH 1/3] SUPPORT.md: Clarify that the PV keyboard protocol
>> includes mouse support
>> 
>> s/fo/fo; while we're here.
>> 
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 2/3] SUPPORT.md: Specify support for various image formats

[Jan Beulich]

>>> On 09.03.18 at 19:03, <george.dunlap@citrix.com> wrote:
> QEMU supports various image formats, but we only provide security
> support for raw, qcow, qcow2, and vhd formats.
> 
> Rather than duplicate this information under the "x86/Emulated
> storage" section, just refer to the "Blkback" section.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> ---
> This is a candidate for backport to 4.10.
> 
> Other option I explored was giving each format its own entry, like
> this:
> 
> #### Image format: Raw
> 
>     Status, Linux (xen-blkback): Supported
>     Status, QEMU (xen_disk): Supported
>     Status, FreeBSD (blkback): Supported, Security support external
>     Status, NetBSD (xbdback): Supported, security support external
>     Status, Blktap2: Deprecated
> 
> But that led to a lot of duplication (Everything is listed as
> "supported" once under "Blkback", and once under "Image format: Raw").

I agree - the way you've put it all necessary information is there
without much redundancy.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/3] docs: Remove redundant qemu-xen-security document

[Jan Beulich]

>>> On 12.03.18 at 13:09, <george.dunlap@citrix.com> wrote:
> On 03/11/2018 08:29 PM, Stefano Stabellini wrote:
>> On Fri, 9 Mar 2018, George Dunlap wrote:
>>> All this information is now covered in SUPPORT.md.
>>>
>>> Most of the emulated hardware is obvious a couple of the items are
>>> worth pointing out specifically.
>>>
>>> "xen_disk" is listed under "Blkback"
>>>
>>> "...the PCI host bridge and the PIIX3 chipset...": This statement is
>>> redundant -- the PCI host bridge is a part of the piix3 chipset, which
>>> is listed as supported.
>>>
>>> xenfb: The "graphics" side of "xenfb" is listed under "PV Framebuffer
>>> (backend)", and the "input" side of "xenfb" (including both keyboard
>>> and mouse) is listed under "PV Keyboard (backend)".
>>>
>>> Backing storage image format is listed in the "Blkback" section.
>>>
>>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
>> 
>> One thing: stdvga is still mispelled in SUPPORT.md.
>> Anything else is fine.
> 
> So it is.  What about the attached?

Acked-by: Jan Beulich <jbeulich@suse.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel