[PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rashika Kheria]

Marks the function acpi_table_checksum() as static in osl.c
because it is not used outside this file.

This eliminates the following warning in osl.c:
drivers/acpi/osl.c:547:11: warning: no previous prototype for
‘acpi_table_checksum’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/osl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 54a20ff..1f4c104 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
 static int all_tables_size;
 
 /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
-u8 __init acpi_table_checksum(u8 *buffer, u32 length)
+static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
 {
 	u8 sum = 0;
 	u8 *end = buffer + length;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rashika Kheria]

Marks the function acpi_table_checksum() as static in osl.c
because it is not used outside this file.

This eliminates the following warning in osl.c:
drivers/acpi/osl.c:547:11: warning: no previous prototype for ‘acpi_table_checksum’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/osl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 54a20ff..1f4c104 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
 static int all_tables_size;
 
 /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
-u8 __init acpi_table_checksum(u8 *buffer, u32 length)
+static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
 {
 	u8 sum = 0;
 	u8 *end = buffer + length;
-- 
1.7.9.5

Re: [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 02:43:05 PM Rashika Kheria wrote:
> Marks the function acpi_table_checksum() as static in osl.c
> because it is not used outside this file.
> 
> This eliminates the following warning in osl.c:
> drivers/acpi/osl.c:547:11: warning: no previous prototype for
> ‘acpi_table_checksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I've queued up patches [1-4/11] and [7-10/11] for 3.14.

I've skipped patches [5-6/11], because the general rule for ACPICA material is
that it should go through ACPICA upstream, so please submit those patches to
Bob/Lv.

I'll send a reply to patch [11/11] in a while.

Thanks!

> ---
>  drivers/acpi/osl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 54a20ff..1f4c104 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
>  static int all_tables_size;
>  
>  /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
> -u8 __init acpi_table_checksum(u8 *buffer, u32 length)
> +static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
>  {
>  	u8 sum = 0;
>  	u8 *end = buffer + length;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 02:43:05 PM Rashika Kheria wrote:
> Marks the function acpi_table_checksum() as static in osl.c
> because it is not used outside this file.
> 
> This eliminates the following warning in osl.c:
> drivers/acpi/osl.c:547:11: warning: no previous prototype for
> ‘acpi_table_checksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I've queued up patches [1-4/11] and [7-10/11] for 3.14.

I've skipped patches [5-6/11], because the general rule for ACPICA material is
that it should go through ACPICA upstream, so please submit those patches to
Bob/Lv.

I'll send a reply to patch [11/11] in a while.

Thanks!

> ---
>  drivers/acpi/osl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 54a20ff..1f4c104 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
>  static int all_tables_size;
>  
>  /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
> -u8 __init acpi_table_checksum(u8 *buffer, u32 length)
> +static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
>  {
>  	u8 sum = 0;
>  	u8 *end = buffer + length;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.