[PATCH -next resend] fpga: zynq: Switch to use dev_err_probe() helper

[PATCH -next resend] fpga: zynq: Switch to use dev_err_probe() helper

[Yang Yingliang]

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
Resend for adding SoB.
---
 drivers/fpga/zynq-fpga.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 426aa34c6a0d..ae0da361e6c6 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev)
 		return priv->irq;
 
 	priv->clk = devm_clk_get(dev, "ref_clk");
-	if (IS_ERR(priv->clk)) {
-		if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
-			dev_err(dev, "input clock not found\n");
-		return PTR_ERR(priv->clk);
-	}
+	if (IS_ERR(priv->clk))
+		return dev_err_probe(dev, PTR_ERR(priv->clk),
+				     "input clock not found\n");
 
 	err = clk_prepare_enable(priv->clk);
 	if (err) {
-- 
2.25.1

Re: [PATCH -next resend] fpga: zynq: Switch to use dev_err_probe() helper

[Russ Weight]

On 9/26/22 07:17, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> ---
> Resend for adding SoB.
> ---
>  drivers/fpga/zynq-fpga.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 426aa34c6a0d..ae0da361e6c6 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>  		return priv->irq;
>  
>  	priv->clk = devm_clk_get(dev, "ref_clk");
> -	if (IS_ERR(priv->clk)) {
> -		if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> -			dev_err(dev, "input clock not found\n");
> -		return PTR_ERR(priv->clk);
> -	}
> +	if (IS_ERR(priv->clk))
> +		return dev_err_probe(dev, PTR_ERR(priv->clk),
> +				     "input clock not found\n");
>  
>  	err = clk_prepare_enable(priv->clk);
>  	if (err) {

Re: [PATCH -next resend] fpga: zynq: Switch to use dev_err_probe() helper

[Xu Yilun]

On 2022-09-26 at 09:09:37 -0700, Russ Weight wrote:
> 
> 
> On 9/26/22 07:17, Yang Yingliang wrote:
> > In the probe path, dev_err() can be replaced with dev_err_probe()
> > which will check if error code is -EPROBE_DEFER and prints the
> > error name. It also sets the defer probe reason which can be
> > checked later through debugfs. It's more simple in error path.
> >
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

> > ---
> > Resend for adding SoB.
> > ---
> >  drivers/fpga/zynq-fpga.c | 8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> > index 426aa34c6a0d..ae0da361e6c6 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -582,11 +582,9 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> >  		return priv->irq;
> >  
> >  	priv->clk = devm_clk_get(dev, "ref_clk");
> > -	if (IS_ERR(priv->clk)) {
> > -		if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> > -			dev_err(dev, "input clock not found\n");
> > -		return PTR_ERR(priv->clk);
> > -	}
> > +	if (IS_ERR(priv->clk))
> > +		return dev_err_probe(dev, PTR_ERR(priv->clk),
> > +				     "input clock not found\n");
> >  
> >  	err = clk_prepare_enable(priv->clk);
> >  	if (err) {
>