All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
@ 2021-03-29  1:45 ` Huang Guobin
  0 siblings, 0 replies; 6+ messages in thread
From: Huang Guobin @ 2021-03-29  1:45 UTC (permalink / raw)
  To: huangguobin4, Radhey Shyam Pandey, David S. Miller,
	Jakub Kicinski, Michal Simek
  Cc: netdev, linux-arm-kernel, linux-kernel

From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 5d677db0aee5..f77a794540fc 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev)
 	ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	lp->regs = devm_ioremap_resource(&pdev->dev, ethres);
 	if (IS_ERR(lp->regs)) {
-		dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n");
 		ret = PTR_ERR(lp->regs);
 		goto cleanup_clk;
 	}


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
@ 2021-03-29  1:45 ` Huang Guobin
  0 siblings, 0 replies; 6+ messages in thread
From: Huang Guobin @ 2021-03-29  1:45 UTC (permalink / raw)
  To: huangguobin4, Radhey Shyam Pandey, David S. Miller,
	Jakub Kicinski, Michal Simek
  Cc: netdev, linux-arm-kernel, linux-kernel

From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 5d677db0aee5..f77a794540fc 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev)
 	ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	lp->regs = devm_ioremap_resource(&pdev->dev, ethres);
 	if (IS_ERR(lp->regs)) {
-		dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n");
 		ret = PTR_ERR(lp->regs);
 		goto cleanup_clk;
 	}


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
  2021-03-29  1:45 ` Huang Guobin
@ 2021-03-29  7:45   ` Michal Simek
  -1 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2021-03-29  7:45 UTC (permalink / raw)
  To: Huang Guobin, Radhey Shyam Pandey, David S. Miller,
	Jakub Kicinski, Michal Simek
  Cc: netdev, linux-arm-kernel, linux-kernel



On 3/29/21 3:45 AM, Huang Guobin wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 5d677db0aee5..f77a794540fc 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev)
>  	ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	lp->regs = devm_ioremap_resource(&pdev->dev, ethres);
>  	if (IS_ERR(lp->regs)) {
> -		dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n");
>  		ret = PTR_ERR(lp->regs);
>  		goto cleanup_clk;
>  	}
> 

I have already reviewed v1 and I can't see any v2 description what has
changed. Why am I getting this v2? Where is my tag?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
@ 2021-03-29  7:45   ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2021-03-29  7:45 UTC (permalink / raw)
  To: Huang Guobin, Radhey Shyam Pandey, David S. Miller,
	Jakub Kicinski, Michal Simek
  Cc: netdev, linux-arm-kernel, linux-kernel



On 3/29/21 3:45 AM, Huang Guobin wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 5d677db0aee5..f77a794540fc 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev)
>  	ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	lp->regs = devm_ioremap_resource(&pdev->dev, ethres);
>  	if (IS_ERR(lp->regs)) {
> -		dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n");
>  		ret = PTR_ERR(lp->regs);
>  		goto cleanup_clk;
>  	}
> 

I have already reviewed v1 and I can't see any v2 description what has
changed. Why am I getting this v2? Where is my tag?

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
  2021-03-29  1:45 ` Huang Guobin
@ 2021-03-29 20:20   ` patchwork-bot+netdevbpf
  -1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29 20:20 UTC (permalink / raw)
  To: Huang Guobin
  Cc: radhey.shyam.pandey, davem, kuba, michal.simek, netdev,
	linux-arm-kernel, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 29 Mar 2021 09:45:13 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: axienet: Remove redundant dev_err call in axienet_probe()
    https://git.kernel.org/netdev/net-next/c/a956b21596f3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()
@ 2021-03-29 20:20   ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29 20:20 UTC (permalink / raw)
  To: Huang Guobin
  Cc: radhey.shyam.pandey, davem, kuba, michal.simek, netdev,
	linux-arm-kernel, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 29 Mar 2021 09:45:13 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: axienet: Remove redundant dev_err call in axienet_probe()
    https://git.kernel.org/netdev/net-next/c/a956b21596f3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-30  0:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  1:45 [PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe() Huang Guobin
2021-03-29  1:45 ` Huang Guobin
2021-03-29  7:45 ` Michal Simek
2021-03-29  7:45   ` Michal Simek
2021-03-29 20:20 ` patchwork-bot+netdevbpf
2021-03-29 20:20   ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.