* [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
@ 2022-05-16 12:25 ` Furkan Kardame
0 siblings, 0 replies; 6+ messages in thread
From: Furkan Kardame @ 2022-05-16 12:25 UTC (permalink / raw)
To: narmstrong; +Cc: khilman, linux-arm-kernel, linux-amlogic, Furkan Kardame
GS-King-X has a single speed GPIO fan which is always-on by default. If
we add controls for the fan and a trip point, the fan stays off most of
the time, reducing background noise from the unit.
Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
---
.../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
index 6c7bfacba..243410913 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
@@ -19,6 +19,15 @@ aliases {
rtc0 = &rtc;
rtc1 = &vrtc;
};
+
+ gpio_fan: gpio-fan {
+ compatible = "gpio-fan";
+ gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
+ /* Using Dummy Speed */
+ gpio-fan,speed-map = <0 0
+ 1 1>;
+ #cooling-cells = <2>;
+ };
gpio-keys-polled {
compatible = "gpio-keys-polled";
@@ -131,3 +140,20 @@ &tdmout_a {
&tohdmitx {
status = "okay";
};
+
+&cpu_thermal {
+ trips {
+ cpu_active: cpu-active
+ temperature = <60000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "active";
+ };
+ };
+
+ cooling-maps {
+ map {
+ trip = <&cpu_active>;
+ cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
+ };
+ };
+};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
@ 2022-05-16 12:25 ` Furkan Kardame
0 siblings, 0 replies; 6+ messages in thread
From: Furkan Kardame @ 2022-05-16 12:25 UTC (permalink / raw)
To: narmstrong; +Cc: khilman, linux-arm-kernel, linux-amlogic, Furkan Kardame
GS-King-X has a single speed GPIO fan which is always-on by default. If
we add controls for the fan and a trip point, the fan stays off most of
the time, reducing background noise from the unit.
Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
---
.../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
index 6c7bfacba..243410913 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
@@ -19,6 +19,15 @@ aliases {
rtc0 = &rtc;
rtc1 = &vrtc;
};
+
+ gpio_fan: gpio-fan {
+ compatible = "gpio-fan";
+ gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
+ /* Using Dummy Speed */
+ gpio-fan,speed-map = <0 0
+ 1 1>;
+ #cooling-cells = <2>;
+ };
gpio-keys-polled {
compatible = "gpio-keys-polled";
@@ -131,3 +140,20 @@ &tdmout_a {
&tohdmitx {
status = "okay";
};
+
+&cpu_thermal {
+ trips {
+ cpu_active: cpu-active
+ temperature = <60000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "active";
+ };
+ };
+
+ cooling-maps {
+ map {
+ trip = <&cpu_active>;
+ cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
+ };
+ };
+};
--
2.35.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
2022-05-16 12:25 ` Furkan Kardame
@ 2022-06-10 6:42 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-06-10 6:42 UTC (permalink / raw)
To: Furkan Kardame; +Cc: khilman, linux-arm-kernel, linux-amlogic
On 16/05/2022 14:25, Furkan Kardame wrote:
> GS-King-X has a single speed GPIO fan which is always-on by default. If
> we add controls for the fan and a trip point, the fan stays off most of
> the time, reducing background noise from the unit.
>
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> ---
> .../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> index 6c7bfacba..243410913 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> @@ -19,6 +19,15 @@ aliases {
> rtc0 = &rtc;
> rtc1 = &vrtc;
> };
> +
> + gpio_fan: gpio-fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> + /* Using Dummy Speed */
> + gpio-fan,speed-map = <0 0
> + 1 1>;
The speed-map is not correctly indented, it should be:
gpio-fan,speed-map = <0 0>, <1 1>;
> + #cooling-cells = <2>;
> + };
This bracked is not correctly aligned
>
> gpio-keys-polled {
> compatible = "gpio-keys-polled";
> @@ -131,3 +140,20 @@ &tdmout_a {
> &tohdmitx {
> status = "okay";
> };
> +
> +&cpu_thermal {
> + trips {
> + cpu_active: cpu-active
> + temperature = <60000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&cpu_active>;
> + cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
This should be: cooling-device = <&gpio_fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> +};
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
@ 2022-06-10 6:42 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2022-06-10 6:42 UTC (permalink / raw)
To: Furkan Kardame; +Cc: khilman, linux-arm-kernel, linux-amlogic
On 16/05/2022 14:25, Furkan Kardame wrote:
> GS-King-X has a single speed GPIO fan which is always-on by default. If
> we add controls for the fan and a trip point, the fan stays off most of
> the time, reducing background noise from the unit.
>
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> ---
> .../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> index 6c7bfacba..243410913 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> @@ -19,6 +19,15 @@ aliases {
> rtc0 = &rtc;
> rtc1 = &vrtc;
> };
> +
> + gpio_fan: gpio-fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> + /* Using Dummy Speed */
> + gpio-fan,speed-map = <0 0
> + 1 1>;
The speed-map is not correctly indented, it should be:
gpio-fan,speed-map = <0 0>, <1 1>;
> + #cooling-cells = <2>;
> + };
This bracked is not correctly aligned
>
> gpio-keys-polled {
> compatible = "gpio-keys-polled";
> @@ -131,3 +140,20 @@ &tdmout_a {
> &tohdmitx {
> status = "okay";
> };
> +
> +&cpu_thermal {
> + trips {
> + cpu_active: cpu-active
> + temperature = <60000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&cpu_active>;
> + cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
This should be: cooling-device = <&gpio_fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> +};
Thanks,
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
2022-06-10 6:42 ` Neil Armstrong
@ 2022-06-10 12:28 ` Furkan Kardame
-1 siblings, 0 replies; 6+ messages in thread
From: Furkan Kardame @ 2022-06-10 12:28 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-arm-kernel, linux-amlogic
Hello Neil,
Thank you for reviewing it.
I have sent out v3 with the following changes:
* Fixed speed-map indentation,
* Aligned bracket
* Sorted cpu_thermal node in alphabetical order.
* Changed cooling-device
* Increased temperature to 70°C
I hope that is fine.
On Friday 10 June 2022 09:42:02 (+03:00), Neil Armstrong wrote:
> On 16/05/2022 14:25, Furkan Kardame wrote:
> > GS-King-X has a single speed GPIO fan which is always-on by default. If
> > we add controls for the fan and a trip point, the fan stays off most of
> > the time, reducing background noise from the unit.
> > Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> > ---
> > .../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > index 6c7bfacba..243410913 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > @@ -19,6 +19,15 @@ aliases {
> > rtc0 = &rtc;
> > rtc1 = &vrtc;
> > };
> > +
> > + gpio_fan: gpio-fan {
> > + compatible = "gpio-fan";
> > + gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> > + /* Using Dummy Speed */
> > + gpio-fan,speed-map = <0 0
> > + 1 1>;
>
> The speed-map is not correctly indented, it should be:
>
> gpio-fan,speed-map = <0 0>, <1 1>;
>
> > + #cooling-cells = <2>;
> > + };
>
> This bracked is not correctly aligned
>
> > gpio-keys-polled {
> > compatible = "gpio-keys-polled";
> > @@ -131,3 +140,20 @@ &tdmout_a {
> > &tohdmitx {
> > status = "okay";
> > };
> > +
> > +&cpu_thermal {
> > + trips {
> > + cpu_active: cpu-active
> > + temperature = <60000>; /* millicelsius */
> > + hysteresis = <2000>; /* millicelsius */
> > + type = "active";
> > + };
> > + };
> > +
> > + cooling-maps {
> > + map {
> > + trip = <&cpu_active>;
> > + cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
>
> This should be: cooling-device = <&gpio_fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>
> > + };
> > + };
> > +};
>
> Thanks,
> Neil
>
--
Furkan K.
Manjaro Linux
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X
@ 2022-06-10 12:28 ` Furkan Kardame
0 siblings, 0 replies; 6+ messages in thread
From: Furkan Kardame @ 2022-06-10 12:28 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-arm-kernel, linux-amlogic
Hello Neil,
Thank you for reviewing it.
I have sent out v3 with the following changes:
* Fixed speed-map indentation,
* Aligned bracket
* Sorted cpu_thermal node in alphabetical order.
* Changed cooling-device
* Increased temperature to 70°C
I hope that is fine.
On Friday 10 June 2022 09:42:02 (+03:00), Neil Armstrong wrote:
> On 16/05/2022 14:25, Furkan Kardame wrote:
> > GS-King-X has a single speed GPIO fan which is always-on by default. If
> > we add controls for the fan and a trip point, the fan stays off most of
> > the time, reducing background noise from the unit.
> > Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> > ---
> > .../boot/dts/amlogic/meson-g12b-gsking-x.dts | 26 +++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > index 6c7bfacba..243410913 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dts
> > @@ -19,6 +19,15 @@ aliases {
> > rtc0 = &rtc;
> > rtc1 = &vrtc;
> > };
> > +
> > + gpio_fan: gpio-fan {
> > + compatible = "gpio-fan";
> > + gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> > + /* Using Dummy Speed */
> > + gpio-fan,speed-map = <0 0
> > + 1 1>;
>
> The speed-map is not correctly indented, it should be:
>
> gpio-fan,speed-map = <0 0>, <1 1>;
>
> > + #cooling-cells = <2>;
> > + };
>
> This bracked is not correctly aligned
>
> > gpio-keys-polled {
> > compatible = "gpio-keys-polled";
> > @@ -131,3 +140,20 @@ &tdmout_a {
> > &tohdmitx {
> > status = "okay";
> > };
> > +
> > +&cpu_thermal {
> > + trips {
> > + cpu_active: cpu-active
> > + temperature = <60000>; /* millicelsius */
> > + hysteresis = <2000>; /* millicelsius */
> > + type = "active";
> > + };
> > + };
> > +
> > + cooling-maps {
> > + map {
> > + trip = <&cpu_active>;
> > + cooling-device = <&gpio_fan 1 THERMAL_NO_LIMIT>;
>
> This should be: cooling-device = <&gpio_fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>
> > + };
> > + };
> > +};
>
> Thanks,
> Neil
>
--
Furkan K.
Manjaro Linux
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-10 12:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 12:25 [PATCH v2 1/1] arm64: dts: meson: add gpio-fan control to GS-King-X Furkan Kardame
2022-05-16 12:25 ` Furkan Kardame
2022-06-10 6:42 ` Neil Armstrong
2022-06-10 6:42 ` Neil Armstrong
2022-06-10 12:28 ` Furkan Kardame
2022-06-10 12:28 ` Furkan Kardame
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.