From: "Alex G." <mr.nuke.me@gmail.com> To: Bjorn Helgaas <helgaas@kernel.org>, Rajat Jain <rajatja@google.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, Jonathan Corbet <corbet@lwn.net>, Philippe Ombredanne <pombredanne@nexb.com>, Kate Stewart <kstewart@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Frederick Lawler <fred@fredlawl.com>, Oza Pawandeep <poza@codeaurora.org>, Keith Busch <keith.busch@intel.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, Thomas Tai <thomas.tai@oracle.com>, "Steven Rostedt (VMware)" <rostedt@goodmis.org>, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jes Sorensen <jsorensen@fb.com>, Kyle McMartin <jkkm@fb.com>, rajatxjain@gmail.com Subject: Re: [PATCH v2 0/5] Expose PCIe AER stats via sysfs Date: Tue, 19 Jun 2018 17:20:28 -0500 [thread overview] Message-ID: <c6a5f1ca-a3da-4dd8-1178-a017d6d771c6@gmail.com> (raw) In-Reply-To: <20180619221651.GH33049@bhelgaas-glaptop.roam.corp.google.com> On 06/19/2018 05:16 PM, Bjorn Helgaas wrote: > On Wed, May 23, 2018 at 10:58:03AM -0700, Rajat Jain wrote: >> This patchset exposes the AER stats via the sysfs attributes. >> >> Patchset v2 has minor changes to v1 based on the review comments, >> no functional change. >> Primarily: >> * Fix license header >> * Use tabs instead of spaces >> * Remove use on unlikely() etc >> * Move documentation to Documentation/ABI/ >> >> Rajat Jain (5): >> PCI/AER: Define and allocate aer_stats structure for AER capable >> devices >> PCI/AER: Add sysfs stats for AER capable devices >> PCI/AER: Add sysfs attributes to provide breakdown of AERs >> PCI/AER: Add sysfs attributes for rootport cumulative stats >> Documentation/ABI: Add details of PCI AER statistics >> >> .../testing/sysfs-bus-pci-devices-aer_stats | 103 ++++++++++ >> Documentation/PCI/pcieaer-howto.txt | 5 + >> drivers/pci/pci-sysfs.c | 3 + >> drivers/pci/pci.h | 4 +- >> drivers/pci/pcie/aer/Makefile | 2 +- >> drivers/pci/pcie/aer/aerdrv.h | 15 ++ >> drivers/pci/pcie/aer/aerdrv_core.c | 11 + >> drivers/pci/pcie/aer/aerdrv_errprint.c | 7 +- >> drivers/pci/pcie/aer/aerdrv_stats.c | 192 ++++++++++++++++++ >> drivers/pci/probe.c | 1 + >> include/linux/pci.h | 3 + >> 11 files changed, 342 insertions(+), 4 deletions(-) >> create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats >> create mode 100644 drivers/pci/pcie/aer/aerdrv_stats.c > > I broke this by putting all the AER code in one file in v4.18-rc1, I see the next phoronix headline: "Linux maintainer breaks things and watches in amusement as contributors rush to the fix" ;) Alex > sorry! Would you mind rebasing these on top of that? > > Since everything AER-related is now in aer.c, I'd suggest putting the > stats code there, too. >
WARNING: multiple messages have this Message-ID (diff)
From: "Alex G." <mr.nuke.me@gmail.com> To: Bjorn Helgaas <helgaas@kernel.org>, Rajat Jain <rajatja@google.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, Jonathan Corbet <corbet@lwn.net>, Philippe Ombredanne <pombredanne@nexb.com>, Kate Stewart <kstewart@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Frederick Lawler <fred@fredlawl.com>, Oza Pawandeep <poza@codeaurora.org>, Keith Busch <keith.busch@intel.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, Thomas Tai <thomas.tai@oracle.com>, "Steven Rostedt (VMware)" <rostedt@goodmis.org>, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jes Sorensen <jsorensen@fb.com>, Kyle McMartin <jkkm@fb.com>, rajatxjain@gmail.com Subject: Re: [PATCH v2 0/5] Expose PCIe AER stats via sysfs Date: Tue, 19 Jun 2018 17:20:28 -0500 [thread overview] Message-ID: <c6a5f1ca-a3da-4dd8-1178-a017d6d771c6@gmail.com> (raw) In-Reply-To: <20180619221651.GH33049@bhelgaas-glaptop.roam.corp.google.com> On 06/19/2018 05:16 PM, Bjorn Helgaas wrote: > On Wed, May 23, 2018 at 10:58:03AM -0700, Rajat Jain wrote: >> This patchset exposes the AER stats via the sysfs attributes. >> >> Patchset v2 has minor changes to v1 based on the review comments, >> no functional change. >> Primarily: >> * Fix license header >> * Use tabs instead of spaces >> * Remove use on unlikely() etc >> * Move documentation to Documentation/ABI/ >> >> Rajat Jain (5): >> PCI/AER: Define and allocate aer_stats structure for AER capable >> devices >> PCI/AER: Add sysfs stats for AER capable devices >> PCI/AER: Add sysfs attributes to provide breakdown of AERs >> PCI/AER: Add sysfs attributes for rootport cumulative stats >> Documentation/ABI: Add details of PCI AER statistics >> >> .../testing/sysfs-bus-pci-devices-aer_stats | 103 ++++++++++ >> Documentation/PCI/pcieaer-howto.txt | 5 + >> drivers/pci/pci-sysfs.c | 3 + >> drivers/pci/pci.h | 4 +- >> drivers/pci/pcie/aer/Makefile | 2 +- >> drivers/pci/pcie/aer/aerdrv.h | 15 ++ >> drivers/pci/pcie/aer/aerdrv_core.c | 11 + >> drivers/pci/pcie/aer/aerdrv_errprint.c | 7 +- >> drivers/pci/pcie/aer/aerdrv_stats.c | 192 ++++++++++++++++++ >> drivers/pci/probe.c | 1 + >> include/linux/pci.h | 3 + >> 11 files changed, 342 insertions(+), 4 deletions(-) >> create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats >> create mode 100644 drivers/pci/pcie/aer/aerdrv_stats.c > > I broke this by putting all the AER code in one file in v4.18-rc1, I see the next phoronix headline: "Linux maintainer breaks things and watches in amusement as contributors rush to the fix" ;) Alex > sorry! Would you mind rebasing these on top of that? > > Since everything AER-related is now in aer.c, I'd suggest putting the > stats code there, too. > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-19 22:20 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 22:28 [PATCH 0/5] Expose PCIe AER stats via sysfs Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:28 ` [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-23 8:27 ` Greg Kroah-Hartman 2018-05-23 8:27 ` Greg Kroah-Hartman 2018-05-23 14:20 ` Jes Sorensen 2018-05-23 14:20 ` Jes Sorensen 2018-05-23 14:26 ` Alex G. 2018-05-23 14:26 ` Alex G. 2018-05-23 14:28 ` Jes Sorensen 2018-05-23 14:28 ` Jes Sorensen 2018-05-23 14:26 ` Matthew Wilcox 2018-05-23 14:26 ` Matthew Wilcox 2018-05-23 14:32 ` Jes Sorensen 2018-05-23 14:32 ` Jes Sorensen 2018-05-23 14:33 ` Alex G. 2018-05-23 14:33 ` Alex G. 2018-05-23 14:46 ` Steven Rostedt 2018-05-23 14:46 ` Steven Rostedt 2018-05-22 22:28 ` [PATCH 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:50 ` Alex G. 2018-05-22 22:50 ` Alex G. 2018-05-22 23:27 ` Rajat Jain 2018-05-22 23:27 ` Rajat Jain 2018-05-22 23:30 ` Sinan Kaya 2018-05-22 23:30 ` Sinan Kaya 2018-05-23 8:22 ` Greg Kroah-Hartman 2018-05-23 8:22 ` Greg Kroah-Hartman 2018-05-23 8:24 ` Greg Kroah-Hartman 2018-05-23 8:24 ` Greg Kroah-Hartman 2018-05-22 22:28 ` [PATCH 3/5] PCP/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-23 8:25 ` Greg Kroah-Hartman 2018-05-23 8:25 ` Greg Kroah-Hartman 2018-05-22 22:28 ` [PATCH 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:28 ` [PATCH 5/5] Documentation/PCI: Add details of PCI AER statistics Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:52 ` Alex G. 2018-05-22 22:52 ` Alex G. 2018-05-22 23:18 ` Rajat Jain 2018-05-22 23:18 ` Rajat Jain 2018-05-23 8:23 ` Greg Kroah-Hartman 2018-05-23 8:23 ` Greg Kroah-Hartman 2018-05-23 17:58 ` [PATCH v2 0/5] Expose PCIe AER stats via sysfs Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-24 6:08 ` Greg Kroah-Hartman 2018-05-24 6:08 ` Greg Kroah-Hartman 2018-05-23 17:58 ` [PATCH v2 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-06-17 5:24 ` poza 2018-06-17 5:24 ` poza 2018-06-19 0:11 ` Rajat Jain 2018-06-19 0:11 ` Rajat Jain 2018-06-19 0:32 ` Rajat Jain 2018-06-19 0:32 ` Rajat Jain 2018-06-19 6:03 ` poza 2018-06-19 6:03 ` poza 2018-06-19 16:31 ` Rajat Jain 2018-06-19 16:31 ` Rajat Jain 2018-06-21 9:19 ` poza 2018-06-21 9:19 ` poza 2018-06-22 0:45 ` Rajat Jain 2018-06-22 0:45 ` Rajat Jain 2018-06-19 22:16 ` [PATCH v2 0/5] Expose PCIe AER stats via sysfs Bjorn Helgaas 2018-06-19 22:16 ` Bjorn Helgaas 2018-06-19 22:17 ` Rajat Jain 2018-06-19 22:17 ` Rajat Jain 2018-06-19 22:20 ` Alex G. [this message] 2018-06-19 22:20 ` Alex G. 2018-06-19 22:25 ` Steven Rostedt 2018-06-19 22:25 ` Steven Rostedt 2018-06-19 22:29 ` Alex G. 2018-06-19 22:29 ` Alex G. 2018-06-20 1:12 ` [PATCH v3 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 3:13 ` kbuild test robot 2018-06-20 3:13 ` kbuild test robot 2018-06-20 1:12 ` [PATCH v3 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 23:28 ` [PATCH v4 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-06-20 23:28 ` Rajat Jain 2018-06-20 23:28 ` [PATCH v4 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 23:28 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 1/5] PCI/AER: Define and allocate aer_stats structure " Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-21 18:48 ` Bjorn Helgaas 2018-06-21 18:48 ` Bjorn Helgaas 2018-06-21 21:25 ` Rajat Jain 2018-06-21 21:25 ` Rajat Jain 2018-06-22 16:38 ` Tyler Baicar 2018-06-22 16:38 ` Tyler Baicar 2018-06-22 17:27 ` Bjorn Helgaas 2018-06-22 17:27 ` Bjorn Helgaas 2018-06-20 23:41 ` [PATCH v5 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-21 13:17 ` [PATCH v5 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Bjorn Helgaas 2018-06-21 13:17 ` Bjorn Helgaas 2018-06-21 20:41 ` Rajat Jain 2018-06-21 20:41 ` Rajat Jain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c6a5f1ca-a3da-4dd8-1178-a017d6d771c6@gmail.com \ --to=mr.nuke.me@gmail.com \ --cc=bhelgaas@google.com \ --cc=corbet@lwn.net \ --cc=fred@fredlawl.com \ --cc=gabriele.paoloni@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=helgaas@kernel.org \ --cc=jkkm@fb.com \ --cc=jsorensen@fb.com \ --cc=keith.busch@intel.com \ --cc=kstewart@linuxfoundation.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=pombredanne@nexb.com \ --cc=poza@codeaurora.org \ --cc=rajatja@google.com \ --cc=rajatxjain@gmail.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=thomas.tai@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.