* [PATCH V3] lightnvm: if LUNs are already allocated fix return
@ 2017-06-27 11:55 Rakesh Pandit
2017-06-27 11:57 ` Frans Klaver
2017-06-27 14:22 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Rakesh Pandit @ 2017-06-27 11:55 UTC (permalink / raw)
To: Jens Axboe, Matias Bjørling
Cc: linux-block, linux-kernel, Matias Bjørling, Frans Klaver,
Javier González
While creating new device with NVM_DEV_CREATE if LUNs are already
allocated ioctl would return -ENOMEM which is wrong. This patch
propagates -EBUSY from nvm_reserve_luns which is correct response.
Fixes: ade69e243 ("lightnvm: merge gennvm with core")
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
V3: Propagate return value from nvm_reserve_luns instead of hard-coding (Frans)
V2: return error code directly instead of using ret variable (Frans)
drivers/lightnvm/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index b8f82f5..ddae430 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -252,8 +252,9 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
}
mutex_unlock(&dev->mlock);
- if (nvm_reserve_luns(dev, s->lun_begin, s->lun_end))
- return -ENOMEM;
+ ret = nvm_reserve_luns(dev, s->lun_begin, s->lun_end);
+ if (ret)
+ return ret;
t = kmalloc(sizeof(struct nvm_target), GFP_KERNEL);
if (!t) {
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] lightnvm: if LUNs are already allocated fix return
2017-06-27 11:55 [PATCH V3] lightnvm: if LUNs are already allocated fix return Rakesh Pandit
@ 2017-06-27 11:57 ` Frans Klaver
2017-06-27 14:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Frans Klaver @ 2017-06-27 11:57 UTC (permalink / raw)
To: Rakesh Pandit
Cc: Jens Axboe, Matias Bjørling, linux-block, linux-kernel,
Matias Bjørling, Javier González
On Tue, Jun 27, 2017 at 1:55 PM, Rakesh Pandit <rakesh@tuxera.com> wrote:
> While creating new device with NVM_DEV_CREATE if LUNs are already
> allocated ioctl would return -ENOMEM which is wrong. This patch
> propagates -EBUSY from nvm_reserve_luns which is correct response.
>
> Fixes: ade69e243 ("lightnvm: merge gennvm with core")
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Reviewed-by: Frans Klaver <fransklaver@gmail.com>
> ---
>
> V3: Propagate return value from nvm_reserve_luns instead of hard-coding (Frans)
> V2: return error code directly instead of using ret variable (Frans)
>
> drivers/lightnvm/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index b8f82f5..ddae430 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -252,8 +252,9 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
> }
> mutex_unlock(&dev->mlock);
>
> - if (nvm_reserve_luns(dev, s->lun_begin, s->lun_end))
> - return -ENOMEM;
> + ret = nvm_reserve_luns(dev, s->lun_begin, s->lun_end);
> + if (ret)
> + return ret;
>
> t = kmalloc(sizeof(struct nvm_target), GFP_KERNEL);
> if (!t) {
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] lightnvm: if LUNs are already allocated fix return
2017-06-27 11:55 [PATCH V3] lightnvm: if LUNs are already allocated fix return Rakesh Pandit
2017-06-27 11:57 ` Frans Klaver
@ 2017-06-27 14:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2017-06-27 14:22 UTC (permalink / raw)
To: Rakesh Pandit, Matias Bjørling
Cc: linux-block, linux-kernel, Matias Bjørling, Frans Klaver,
Javier González
On 06/27/2017 05:55 AM, Rakesh Pandit wrote:
> While creating new device with NVM_DEV_CREATE if LUNs are already
> allocated ioctl would return -ENOMEM which is wrong. This patch
> propagates -EBUSY from nvm_reserve_luns which is correct response.
Thanks, applied for 4.13.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-27 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 11:55 [PATCH V3] lightnvm: if LUNs are already allocated fix return Rakesh Pandit
2017-06-27 11:57 ` Frans Klaver
2017-06-27 14:22 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.