All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Alexandre Torgue <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	arnd@arndb.de, robh+dt@kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, patrice.chotard@st.com,
	lee.jones@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Enable DMA on STM32 MCU based on cortex-M7
Date: Wed, 28 Feb 2018 13:22:51 +0000	[thread overview]
Message-ID: <c6e0906d-a181-720c-d2ef-73e1d517232a@arm.com> (raw)
In-Reply-To: <1519823458-27734-1-git-send-email-alexandre.torgue@st.com>

On 28/02/18 13:10, Alexandre Torgue wrote:
> This series enable DMA on several STM32 MCU based on cortex-M7.
> To make it possible, a dedicated dma pool memory area has to be
> created. This patchset activate also ARM_MPU flag which will configure 
> MPU (Memory Protection Unit) according to devicetree information (mem
> and dma-pool). Note that on cortex-M7 DMA has to use a NO cache-able 
> memory region.
> 
> 
> v2:
> -select ARM_MPU in mach-stm32 Kconfig instead of add it in stm32 defconfig
> -Remove XIP configuration from stm32_defconfig: ARM_MPU flag imposes XIP image
> to be aligned on 1MB. It is currently not the case. I had choice to either
> modify current XIP start address to be aligned on 1MB or to remove global
> configuration. I make choice to remove XIP configuration. Indeed, SD card
> support has been recently added for most of STM32 MCU boards (except for
> stm32f429-disco). As kernel is growing up for stm32 it will be more and more
> difficult to flash it in embeded flash (max size: 2MB).

It is sad we are loosing XIP configuration - it used to uncover some bugs
in a past. Probably, you might consider to have stm32 tiny (+xip) defconfig
for those who do not want/need all-in-one kernel.

Cheers
Vladimir

> -fix typo in commit message
> 
> Regards
> Alex
> 
> Alexandre Torgue (4):
>   ARM: dts: stm32: add DMA memory pool on MCU which embed a cortex-M7
>   ARM: configs: stm32: remove XIP configuration
>   ARM: stm32: Select ARM_MPU for cortex-M7 machines
>   ARM: dts: stm32: enable dma on MCU which embed a cortex-M7
> 
>  arch/arm/boot/dts/stm32746g-eval.dts   | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32f769-disco.dts  | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32h743i-disco.dts | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32h743i-eval.dts  | 21 +++++++++++++++++++++
>  arch/arm/configs/stm32_defconfig       |  2 --
>  arch/arm/mach-stm32/Kconfig            |  3 +++
>  6 files changed, 87 insertions(+), 2 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] Enable DMA on STM32 MCU based on cortex-M7
Date: Wed, 28 Feb 2018 13:22:51 +0000	[thread overview]
Message-ID: <c6e0906d-a181-720c-d2ef-73e1d517232a@arm.com> (raw)
In-Reply-To: <1519823458-27734-1-git-send-email-alexandre.torgue@st.com>

On 28/02/18 13:10, Alexandre Torgue wrote:
> This series enable DMA on several STM32 MCU based on cortex-M7.
> To make it possible, a dedicated dma pool memory area has to be
> created. This patchset activate also ARM_MPU flag which will configure 
> MPU (Memory Protection Unit) according to devicetree information (mem
> and dma-pool). Note that on cortex-M7 DMA has to use a NO cache-able 
> memory region.
> 
> 
> v2:
> -select ARM_MPU in mach-stm32 Kconfig instead of add it in stm32 defconfig
> -Remove XIP configuration from stm32_defconfig: ARM_MPU flag imposes XIP image
> to be aligned on 1MB. It is currently not the case. I had choice to either
> modify current XIP start address to be aligned on 1MB or to remove global
> configuration. I make choice to remove XIP configuration. Indeed, SD card
> support has been recently added for most of STM32 MCU boards (except for
> stm32f429-disco). As kernel is growing up for stm32 it will be more and more
> difficult to flash it in embeded flash (max size: 2MB).

It is sad we are loosing XIP configuration - it used to uncover some bugs
in a past. Probably, you might consider to have stm32 tiny (+xip) defconfig
for those who do not want/need all-in-one kernel.

Cheers
Vladimir

> -fix typo in commit message
> 
> Regards
> Alex
> 
> Alexandre Torgue (4):
>   ARM: dts: stm32: add DMA memory pool on MCU which embed a cortex-M7
>   ARM: configs: stm32: remove XIP configuration
>   ARM: stm32: Select ARM_MPU for cortex-M7 machines
>   ARM: dts: stm32: enable dma on MCU which embed a cortex-M7
> 
>  arch/arm/boot/dts/stm32746g-eval.dts   | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32f769-disco.dts  | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32h743i-disco.dts | 21 +++++++++++++++++++++
>  arch/arm/boot/dts/stm32h743i-eval.dts  | 21 +++++++++++++++++++++
>  arch/arm/configs/stm32_defconfig       |  2 --
>  arch/arm/mach-stm32/Kconfig            |  3 +++
>  6 files changed, 87 insertions(+), 2 deletions(-)
> 

  parent reply	other threads:[~2018-02-28 13:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 13:10 [PATCH v2 0/4] Enable DMA on STM32 MCU based on cortex-M7 Alexandre Torgue
2018-02-28 13:10 ` Alexandre Torgue
2018-02-28 13:10 ` [PATCH v2 1/4] ARM: dts: stm32: add DMA memory pool on MCU which embed a cortex-M7 Alexandre Torgue
2018-02-28 13:10   ` Alexandre Torgue
2018-02-28 13:10 ` [PATCH v2 2/4] ARM: configs: stm32: remove XIP configuration Alexandre Torgue
2018-02-28 13:10   ` Alexandre Torgue
2018-02-28 13:10 ` [PATCH v2 3/4] ARM: stm32: Select ARM_MPU for cortex-M7 machines Alexandre Torgue
2018-02-28 13:10   ` Alexandre Torgue
2018-02-28 13:10 ` [PATCH v2 4/4] ARM: dts: stm32: enable dma on MCU which embed a cortex-M7 Alexandre Torgue
2018-02-28 13:10   ` Alexandre Torgue
2018-02-28 13:22 ` Vladimir Murzin [this message]
2018-02-28 13:22   ` [PATCH v2 0/4] Enable DMA on STM32 MCU based on cortex-M7 Vladimir Murzin
2018-02-28 13:42   ` Alexandre Torgue
2018-02-28 13:42     ` Alexandre Torgue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6e0906d-a181-720c-d2ef-73e1d517232a@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=alexandre.torgue@st.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=patrice.chotard@st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.