All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>,
	Yunfei Dong <Yunfei.Dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	Irui Wang <irui.wang@mediatek.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register bases from DT
Date: Fri, 30 Jul 2021 12:09:35 +0200	[thread overview]
Message-ID: <c6ecd39b-a756-b1b7-3191-6d9536f72b87@collabora.com> (raw)
In-Reply-To: <CA+Px+wUXmpT6TBOvD9J6ircLQ_X5D=bByOotfk+L7U+sXev3nQ@mail.gmail.com>



On 30.07.21 11:31, Tzung-Bi Shih wrote:
> On Tue, Jul 27, 2021 at 06:10:37PM +0800, Yunfei Dong wrote:
>> +static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev)
>> +{
>> +     struct platform_device *pdev = dev->plat_dev;
>> +     int reg_num, i, ret = 0;
> ret don't need to be initialized.
> 
>> +     for (i = 0; i < reg_num; i++) {
>> +             dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i);
>> +             if (IS_ERR((__force void *)dev->reg_base[i])) {
>> +                     return PTR_ERR((__force void *)dev->reg_base[i]);
>> +             }
> { } can be removed.

I think that also the "__fore void*" can be removed

thanks,
Dafna

> 

WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>,
	Yunfei Dong <Yunfei.Dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	Irui Wang <irui.wang@mediatek.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register bases from DT
Date: Fri, 30 Jul 2021 12:09:35 +0200	[thread overview]
Message-ID: <c6ecd39b-a756-b1b7-3191-6d9536f72b87@collabora.com> (raw)
In-Reply-To: <CA+Px+wUXmpT6TBOvD9J6ircLQ_X5D=bByOotfk+L7U+sXev3nQ@mail.gmail.com>



On 30.07.21 11:31, Tzung-Bi Shih wrote:
> On Tue, Jul 27, 2021 at 06:10:37PM +0800, Yunfei Dong wrote:
>> +static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev)
>> +{
>> +     struct platform_device *pdev = dev->plat_dev;
>> +     int reg_num, i, ret = 0;
> ret don't need to be initialized.
> 
>> +     for (i = 0; i < reg_num; i++) {
>> +             dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i);
>> +             if (IS_ERR((__force void *)dev->reg_base[i])) {
>> +                     return PTR_ERR((__force void *)dev->reg_base[i]);
>> +             }
> { } can be removed.

I think that also the "__fore void*" can be removed

thanks,
Dafna

> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>,
	Yunfei Dong <Yunfei.Dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	Irui Wang <irui.wang@mediatek.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register bases from DT
Date: Fri, 30 Jul 2021 12:09:35 +0200	[thread overview]
Message-ID: <c6ecd39b-a756-b1b7-3191-6d9536f72b87@collabora.com> (raw)
In-Reply-To: <CA+Px+wUXmpT6TBOvD9J6ircLQ_X5D=bByOotfk+L7U+sXev3nQ@mail.gmail.com>



On 30.07.21 11:31, Tzung-Bi Shih wrote:
> On Tue, Jul 27, 2021 at 06:10:37PM +0800, Yunfei Dong wrote:
>> +static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev)
>> +{
>> +     struct platform_device *pdev = dev->plat_dev;
>> +     int reg_num, i, ret = 0;
> ret don't need to be initialized.
> 
>> +     for (i = 0; i < reg_num; i++) {
>> +             dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i);
>> +             if (IS_ERR((__force void *)dev->reg_base[i])) {
>> +                     return PTR_ERR((__force void *)dev->reg_base[i]);
>> +             }
> { } can be removed.

I think that also the "__fore void*" can be removed

thanks,
Dafna

> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-30 10:09 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 10:10 [PATCH v3, 00/15] Using component framework to support multi hardware decode Yunfei Dong
2021-07-27 10:10 ` Yunfei Dong
2021-07-27 10:10 ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-30  9:31   ` Tzung-Bi Shih
2021-07-30  9:31     ` Tzung-Bi Shih
2021-07-30  9:31     ` Tzung-Bi Shih
2021-07-30 10:09     ` Dafna Hirschfeld [this message]
2021-07-30 10:09       ` Dafna Hirschfeld
2021-07-30 10:09       ` Dafna Hirschfeld
2021-07-27 10:10 ` [PATCH v3, 02/15] media: mtk-vcodec: Align vcodec wake up interrupt interface Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-30  9:31   ` Tzung-Bi Shih
2021-07-30  9:31     ` Tzung-Bi Shih
2021-07-30  9:31     ` Tzung-Bi Shih
2021-07-27 10:10 ` [PATCH v3, 03/15] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-30  9:32   ` Tzung-Bi Shih
2021-07-30  9:32     ` Tzung-Bi Shih
2021-07-30  9:32     ` Tzung-Bi Shih
2021-07-27 10:10 ` [PATCH v3, 04/15] media: mtk-vcodec: Use component framework to manage each hardware information Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-30  9:32   ` Tzung-Bi Shih
2021-07-30  9:32     ` Tzung-Bi Shih
2021-07-30  9:32     ` Tzung-Bi Shih
2021-07-27 10:10 ` [PATCH v3, 05/15] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-08-02 20:09   ` Rob Herring
2021-08-02 20:09     ` Rob Herring
2021-08-02 20:09     ` Rob Herring
2021-07-27 10:10 ` [PATCH v3, 06/15] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 07/15] media: mtk-vcodec: Add irq interface for multi hardware Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 08/15] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 09/15] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 10/15] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 11/15] media: mtk-vcodec: Add core thread Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 13/15] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 18:26   ` Rob Herring
2021-07-27 18:26     ` Rob Herring
2021-07-27 18:26     ` Rob Herring
2021-07-27 10:10 ` [PATCH v3, 14/15] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10 ` [PATCH v3, 15/15] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:10   ` Yunfei Dong
2021-07-27 10:55 ` [PATCH v3, 00/15] Using component framework to support multi hardware decode Dafna Hirschfeld
2021-07-27 10:55   ` Dafna Hirschfeld
2021-07-27 10:55   ` Dafna Hirschfeld
2021-07-29  8:08   ` yunfei dong
2021-07-29  8:08     ` yunfei dong
2021-07-29  8:08     ` yunfei dong
2021-07-30 10:02     ` Dafna Hirschfeld
2021-07-30 10:02       ` Dafna Hirschfeld
2021-07-30 10:02       ` Dafna Hirschfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6ecd39b-a756-b1b7-3191-6d9536f72b87@collabora.com \
    --to=dafna.hirschfeld@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Yunfei.Dong@mediatek.com \
    --cc=acourbot@chromium.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frkoenig@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=irui.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@google.com \
    --cc=tiffany.lin@mediatek.com \
    --cc=tzungbi@chromium.org \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.