From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
<linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<Ramiro.Oliveira@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
<CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH] i2c: core: helper function to detect slave mode
Date: Fri, 6 Jan 2017 17:46:33 +0000 [thread overview]
Message-ID: <c73ee9ab-64a1-0419-314d-21d4575ca7bf@synopsys.com> (raw)
In-Reply-To: <CAHp75Vdv3daVnkFmGc7gXWoqcy+CNgyqdtRXkvTJQpjyJX3eDg@mail.gmail.com>
On 06-Jan-17 17:17, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 7:15 PM, Luis Oliveira
> <Luis.Oliveira@synopsys.com> wrote:
>> On 06-Jan-17 16:29, Andy Shevchenko wrote:
>>> On Thu, Jan 5, 2017 at 7:24 PM, Luis Oliveira
>
>>> Please, add kernel doc description here, important thing is to explain
>>> return codes in Return: section of it.
>>>
>>>> +int i2c_slave_mode_detect(struct device *dev)
>
> Just to make sure you didn't miss this one.
>
>
Yes, I saw it. You were talking of something like this, right?
/**
* i2c_slave_mode_detect - detect operation mode
* @dev: The device owning the bus
*
* This checks the device nodes for a I2C slave by checking the address
* used.
*
* Returns true if a I2C slave is detected, otherwise returns false.
*/
WARNING: multiple messages have this Message-ID (diff)
From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ramiro.Oliveira@synopsys.com,
Joao Pinto <Joao.Pinto@synopsys.com>,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH] i2c: core: helper function to detect slave mode
Date: Fri, 6 Jan 2017 17:46:33 +0000 [thread overview]
Message-ID: <c73ee9ab-64a1-0419-314d-21d4575ca7bf@synopsys.com> (raw)
In-Reply-To: <CAHp75Vdv3daVnkFmGc7gXWoqcy+CNgyqdtRXkvTJQpjyJX3eDg@mail.gmail.com>
On 06-Jan-17 17:17, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 7:15 PM, Luis Oliveira
> <Luis.Oliveira@synopsys.com> wrote:
>> On 06-Jan-17 16:29, Andy Shevchenko wrote:
>>> On Thu, Jan 5, 2017 at 7:24 PM, Luis Oliveira
>
>>> Please, add kernel doc description here, important thing is to explain
>>> return codes in Return: section of it.
>>>
>>>> +int i2c_slave_mode_detect(struct device *dev)
>
> Just to make sure you didn't miss this one.
>
>
Yes, I saw it. You were talking of something like this, right?
/**
* i2c_slave_mode_detect - detect operation mode
* @dev: The device owning the bus
*
* This checks the device nodes for a I2C slave by checking the address
* used.
*
* Returns true if a I2C slave is detected, otherwise returns false.
*/
next prev parent reply other threads:[~2017-01-06 17:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 17:24 [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira
2017-01-05 17:24 ` Luis Oliveira
2017-01-06 16:29 ` Andy Shevchenko
2017-01-06 17:15 ` Luis Oliveira
2017-01-06 17:15 ` Luis Oliveira
2017-01-06 17:17 ` Andy Shevchenko
2017-01-06 17:17 ` Andy Shevchenko
2017-01-06 17:46 ` Luis Oliveira [this message]
2017-01-06 17:46 ` Luis Oliveira
2017-01-06 21:32 ` Andy Shevchenko
2017-01-06 21:32 ` Andy Shevchenko
2017-01-06 16:35 ` Rob Herring
2017-01-06 17:12 ` Luis Oliveira
2017-01-06 17:12 ` Luis Oliveira
2017-01-06 21:46 ` Vladimir Zapolskiy
2017-01-06 21:46 ` Vladimir Zapolskiy
2017-01-06 22:45 ` Andy Shevchenko
2017-01-06 22:45 ` Andy Shevchenko
2017-01-06 23:43 ` Vladimir Zapolskiy
2017-01-07 0:19 ` Andy Shevchenko
2017-01-07 0:19 ` Andy Shevchenko
2017-01-07 1:24 ` Vladimir Zapolskiy
2017-01-07 1:24 ` Vladimir Zapolskiy
2017-01-12 17:01 ` Andy Shevchenko
2017-01-16 10:32 ` Luis Oliveira
2017-01-16 10:32 ` Luis Oliveira
2017-01-16 23:14 ` Vladimir Zapolskiy
2017-01-16 23:14 ` Vladimir Zapolskiy
2017-01-18 10:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c73ee9ab-64a1-0419-314d-21d4575ca7bf@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.