[PATCH] lg-laptop: Recognize more models

[PATCH] lg-laptop: Recognize more models

[Matan Ziv-Av]

LG uses 5 instead of 0 in the third digit (second digit after 2019) 
of the year string to indicate newer models in the same year. Handle 
this case as well.

Signed-off-by: Matan Ziv-Av <matan@svgalib.org>
---
  drivers/platform/x86/lg-laptop.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
index ae9293024c77..a91847a551a7 100644
--- a/drivers/platform/x86/lg-laptop.c
+++ b/drivers/platform/x86/lg-laptop.c
@@ -657,6 +657,18 @@ static int acpi_add(struct acpi_device *device)
  	if (product && strlen(product) > 4)
  		switch (product[4]) {
  		case '5':
+			if (strlen(product) > 5)
+				switch (product[5]) {
+				case 'N':
+					year = 2021;
+					break;
+				case '0':
+					year = 2016;
+					break;
+				default:
+					year = 2022;
+				}
+			break;
  		case '6':
  			year = 2016;
  			break;



-- 
Matan.

Re: [PATCH] lg-laptop: Recognize more models

[Andy Shevchenko]

On Wed, Nov 24, 2021 at 1:27 AM Matan Ziv-Av <matan@svgalib.org> wrote:

> LG uses 5 instead of 0 in the third digit (second digit after 2019)
> of the year string to indicate newer models in the same year. Handle
> this case as well.

>         if (product && strlen(product) > 4)
>                 switch (product[4]) {
>                 case '5':
> +                       if (strlen(product) > 5)
> +                               switch (product[5]) {
> +                               case 'N':
> +                                       year = 2021;
> +                                       break;
> +                               case '0':
> +                                       year = 2016;
> +                                       break;
> +                               default:
> +                                       year = 2022;
> +                               }
> +                       break;
>                 case '6':
>                         year = 2016;
>                         break;

Actually you may replace all those `if (strlen(product) > $X) {}` and
accompanied indentation level by adding corresponding
  case '\0':
    break;
into the switches, but this is out of scope here as it should be a
separate change, if any.



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] lg-laptop: Recognize more models

[Hans de Goede]

Hi,

On 11/23/21 21:14, Matan Ziv-Av wrote:
> 
> LG uses 5 instead of 0 in the third digit (second digit after 2019) of the year string to indicate newer models in the same year. Handle this case as well.
> 
> Signed-off-by: Matan Ziv-Av <matan@svgalib.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/lg-laptop.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index ae9293024c77..a91847a551a7 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -657,6 +657,18 @@ static int acpi_add(struct acpi_device *device)
>      if (product && strlen(product) > 4)
>          switch (product[4]) {
>          case '5':
> +            if (strlen(product) > 5)
> +                switch (product[5]) {
> +                case 'N':
> +                    year = 2021;
> +                    break;
> +                case '0':
> +                    year = 2016;
> +                    break;
> +                default:
> +                    year = 2022;
> +                }
> +            break;
>          case '6':
>              year = 2016;
>              break;
> 
> 
>