From: "Baicar, Tyler" <tbaicar@codeaurora.org>
To: Punit Agrawal <punit.agrawal@arm.com>, James Morse <james.morse@arm.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Subject: Re: [PATCH] arm64: kconfig: allow support for memory failure handling
Date: Fri, 24 Mar 2017 10:36:16 -0600 [thread overview]
Message-ID: <c76008af-4061-f44c-5643-77070406364e@codeaurora.org> (raw)
In-Reply-To: <1dc99ff7-65ac-4858-6008-8ee8d0f6f336@arm.com>
On 3/23/2017 10:12 AM, Punit Agrawal wrote:
>
>
> On 23/03/17 14:33, James Morse wrote:
>> Hi Punit,
>>
>> On 01/02/17 21:38, Tyler Baicar wrote:
>>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>>>
>>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>>> when such memory failure is reported through ACPI APEI. APEI
>>> (ACPI Platform Error Interfaces) provides a means for the
>>> platform to convey error information to the kernel.
>>>
>>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>>> memory failure recovery attempt.
>>
>> Am I right in thinking we should wait for the hugepage issue you
>> found with
>> hwpoison [0] to be fixed before arm64 can have
>> ARCH_SUPPORTS_MEMORY_FAILURE?
>
> We should at the least fix the huge_pte_offset() issue discovered in [0]
> before we enable memory failure handling. Earlier today I posted a
> RFC[1] fix for it based on Catalin's suggestion.
>
>>
>> (If so, can this patch become part of that series to they are
>> obviously related!)
>
> Good point - I can include the patches enabling memory failure handling
> on ARM64 if Tyler's fine with it.
That's fine with me!
Thanks,
Tyler
>
> Thanks,
> Punit
>
> [1] https://lkml.org/lkml/2017/3/23/293
>
>>
>> Thanks,
>>
>> James
>>
>> [0] https://www.spinics.net/lists/arm-kernel/msg568995.html
>>
>>
>>
>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index f92778d..4cd12a0 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -15,6 +15,8 @@ config ARM64
>>> select ARCH_HAS_SG_CHAIN
>>> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>>> select ARCH_USE_CMPXCHG_LOCKREF
>>> + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>>> + select ARCH_SUPPORTS_MEMORY_FAILURE
>>> select ARCH_SUPPORTS_ATOMIC_RMW
>>> select ARCH_SUPPORTS_NUMA_BALANCING
>>> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
>>>
>>
>>
>>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: tbaicar@codeaurora.org (Baicar, Tyler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: kconfig: allow support for memory failure handling
Date: Fri, 24 Mar 2017 10:36:16 -0600 [thread overview]
Message-ID: <c76008af-4061-f44c-5643-77070406364e@codeaurora.org> (raw)
In-Reply-To: <1dc99ff7-65ac-4858-6008-8ee8d0f6f336@arm.com>
On 3/23/2017 10:12 AM, Punit Agrawal wrote:
>
>
> On 23/03/17 14:33, James Morse wrote:
>> Hi Punit,
>>
>> On 01/02/17 21:38, Tyler Baicar wrote:
>>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>>>
>>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>>> when such memory failure is reported through ACPI APEI. APEI
>>> (ACPI Platform Error Interfaces) provides a means for the
>>> platform to convey error information to the kernel.
>>>
>>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>>> memory failure recovery attempt.
>>
>> Am I right in thinking we should wait for the hugepage issue you
>> found with
>> hwpoison [0] to be fixed before arm64 can have
>> ARCH_SUPPORTS_MEMORY_FAILURE?
>
> We should at the least fix the huge_pte_offset() issue discovered in [0]
> before we enable memory failure handling. Earlier today I posted a
> RFC[1] fix for it based on Catalin's suggestion.
>
>>
>> (If so, can this patch become part of that series to they are
>> obviously related!)
>
> Good point - I can include the patches enabling memory failure handling
> on ARM64 if Tyler's fine with it.
That's fine with me!
Thanks,
Tyler
>
> Thanks,
> Punit
>
> [1] https://lkml.org/lkml/2017/3/23/293
>
>>
>> Thanks,
>>
>> James
>>
>> [0] https://www.spinics.net/lists/arm-kernel/msg568995.html
>>
>>
>>
>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index f92778d..4cd12a0 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -15,6 +15,8 @@ config ARM64
>>> select ARCH_HAS_SG_CHAIN
>>> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>>> select ARCH_USE_CMPXCHG_LOCKREF
>>> + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>>> + select ARCH_SUPPORTS_MEMORY_FAILURE
>>> select ARCH_SUPPORTS_ATOMIC_RMW
>>> select ARCH_SUPPORTS_NUMA_BALANCING
>>> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
>>>
>>
>>
>>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-03-24 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 21:38 [PATCH] arm64: kconfig: allow support for memory failure handling Tyler Baicar
2017-02-01 21:38 ` Tyler Baicar
2017-02-03 16:27 ` Punit Agrawal
2017-02-03 16:27 ` Punit Agrawal
2017-02-06 22:26 ` Baicar, Tyler
2017-02-06 22:26 ` Baicar, Tyler
2017-02-07 12:03 ` Punit Agrawal
2017-02-07 12:03 ` Punit Agrawal
2017-03-23 14:33 ` James Morse
2017-03-23 14:33 ` James Morse
2017-03-23 16:12 ` Punit Agrawal
2017-03-23 16:12 ` Punit Agrawal
2017-03-24 16:36 ` Baicar, Tyler [this message]
2017-03-24 16:36 ` Baicar, Tyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76008af-4061-f44c-5643-77070406364e@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=will.deacon@arm.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.