Re: [RFC 11/16] irq: skip action avalability check for guest's IRQ

From: Andrii Anisov <andrii.anisov@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [RFC 11/16] irq: skip action avalability check for guest's IRQ
Date: Wed, 12 Dec 2018 13:30:14 +0200	[thread overview]
Message-ID: <c7678ede-86c5-f742-e749-acc4841d7481@gmail.com> (raw)
In-Reply-To: <3be90d82-cdcd-b3d5-c734-6da90ecd7344@arm.com>

On 11.12.18 16:48, Julien Grall wrote:
> And you can't see any potential race in that code happening in the future?
It is protected with `desc->lock` so far. If one decided to get it from under the lock, the race is possible with `release_irq()`.

>> Also getting an unknown
>> interrupt is very unlikely on a non-debug platform.
> 
> I am tempted to keep the code at the same place but protect with an #ifndef NDEBUG. What do you think?
Well, I think about a correspondent ASSERT for the guest IRQ. Like following:

>>       if ( test_bit(_IRQ_GUEST, &desc->status) )
>>       {>>           struct irq_guest *info = irq_get_guest_info(desc);
+            ASSERT( desc->action != NULL );

What would you prefer?

-- 
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel