From: Dietmar Eggemann <dietmar.eggemann@arm.com> To: Juri Lelli <juri.lelli@redhat.com>, Waiman Long <longman@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>, Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>, Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, cgroups@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>, Quentin Perret <qperret@google.com>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Sudeep Holla <sudeep.holla@arm.com> Subject: Re: [RFC PATCH 2/3] sched/cpuset: Keep track of SCHED_DEADLINE tasks in cpusets Date: Wed, 22 Mar 2023 14:18:47 +0100 [thread overview] Message-ID: <c77bc281-b6e1-1653-6bed-0249f85b7e94@arm.com> (raw) In-Reply-To: <ZBH9E7lCEXcFDBG4@localhost.localdomain> On 15/03/2023 18:14, Juri Lelli wrote: > On 15/03/23 11:46, Waiman Long wrote: >> >> On 3/15/23 08:18, Juri Lelli wrote: [...] >>> @@ -2472,6 +2492,11 @@ static int cpuset_can_attach(struct cgroup_taskset *tset) >>> ret = security_task_setscheduler(task); >>> if (ret) >>> goto out_unlock; >>> + >>> + if (dl_task(task)) { >>> + cs->nr_deadline_tasks++; >>> + cpuset_attach_old_cs->nr_deadline_tasks--; >>> + } >>> } >> >> Any one of the tasks in the cpuset can cause the test to fail and abort the >> attachment. I would suggest that you keep a deadline task transfer count in >> the loop and then update cs and cpouset_attach_old_cs only after all the >> tasks have been iterated successfully. > > Right, Dietmar I think commented pointing out something along these > lines. Think though we already have this problem with current > task_can_attach -> dl_cpu_busy which reserves bandwidth for each tasks > in the destination cs. Will need to look into that. Do you know which > sort of operation would move multiple tasks at once? Moving the process instead of the individual tasks makes cpuset_can_attach() have to deal with multiple tasks. # ps2 | grep DLN 1614 1615 140 0 - DLN thread0-0 1614 1616 140 0 - DLN thread0-1 1614 1617 140 0 - DLN thread0-2 # echo 1614 > /sys/fs/cgroup/cpuset/cs2/cgroup.procs
WARNING: multiple messages have this Message-ID (diff)
From: Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org> To: Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Qais Yousef <qyousef-wp2msK0BRk8tq7phqP6ubQ@public.gmane.org>, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Hao Luo <haoluo-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org, tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vincent Guittot <vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Wei Wang <wvw-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Rick Yiu <rickyiu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Quentin Perret <qperret-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Heiko Carstens <hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>, Vasily Gorbik <gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>, Alexander Gordeev <agordeev-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>, Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> Subject: Re: [RFC PATCH 2/3] sched/cpuset: Keep track of SCHED_DEADLINE tasks in cpusets Date: Wed, 22 Mar 2023 14:18:47 +0100 [thread overview] Message-ID: <c77bc281-b6e1-1653-6bed-0249f85b7e94@arm.com> (raw) In-Reply-To: <ZBH9E7lCEXcFDBG4-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> On 15/03/2023 18:14, Juri Lelli wrote: > On 15/03/23 11:46, Waiman Long wrote: >> >> On 3/15/23 08:18, Juri Lelli wrote: [...] >>> @@ -2472,6 +2492,11 @@ static int cpuset_can_attach(struct cgroup_taskset *tset) >>> ret = security_task_setscheduler(task); >>> if (ret) >>> goto out_unlock; >>> + >>> + if (dl_task(task)) { >>> + cs->nr_deadline_tasks++; >>> + cpuset_attach_old_cs->nr_deadline_tasks--; >>> + } >>> } >> >> Any one of the tasks in the cpuset can cause the test to fail and abort the >> attachment. I would suggest that you keep a deadline task transfer count in >> the loop and then update cs and cpouset_attach_old_cs only after all the >> tasks have been iterated successfully. > > Right, Dietmar I think commented pointing out something along these > lines. Think though we already have this problem with current > task_can_attach -> dl_cpu_busy which reserves bandwidth for each tasks > in the destination cs. Will need to look into that. Do you know which > sort of operation would move multiple tasks at once? Moving the process instead of the individual tasks makes cpuset_can_attach() have to deal with multiple tasks. # ps2 | grep DLN 1614 1615 140 0 - DLN thread0-0 1614 1616 140 0 - DLN thread0-1 1614 1617 140 0 - DLN thread0-2 # echo 1614 > /sys/fs/cgroup/cpuset/cs2/cgroup.procs
next prev parent reply other threads:[~2023-03-22 13:19 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-15 12:18 [RFC PATCH 0/3] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli 2023-03-15 12:18 ` Juri Lelli 2023-03-15 12:18 ` [RFC PATCH 1/3] sched/cpuset: Bring back cpuset_mutex Juri Lelli 2023-03-15 12:18 ` Juri Lelli 2023-03-15 12:18 ` [RFC PATCH 2/3] sched/cpuset: Keep track of SCHED_DEADLINE tasks in cpusets Juri Lelli 2023-03-15 12:18 ` Juri Lelli 2023-03-15 14:49 ` Qais Yousef 2023-03-15 14:49 ` Qais Yousef 2023-03-15 17:18 ` Juri Lelli 2023-03-15 17:18 ` Juri Lelli 2023-03-15 19:25 ` Qais Yousef 2023-03-15 19:25 ` Qais Yousef 2023-03-15 15:46 ` Waiman Long 2023-03-15 15:46 ` Waiman Long 2023-03-15 17:14 ` Juri Lelli 2023-03-15 17:14 ` Juri Lelli 2023-03-15 18:01 ` Waiman Long 2023-03-15 18:01 ` Waiman Long 2023-03-15 18:10 ` Waiman Long 2023-03-15 18:10 ` Waiman Long 2023-03-15 23:27 ` Waiman Long 2023-03-15 23:27 ` Waiman Long 2023-03-22 14:05 ` Dietmar Eggemann 2023-03-22 14:05 ` Dietmar Eggemann 2023-03-22 13:18 ` Dietmar Eggemann [this message] 2023-03-22 13:18 ` Dietmar Eggemann 2023-03-15 12:18 ` [RFC PATCH 3/3] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli 2023-03-15 12:18 ` Juri Lelli 2023-03-15 14:55 ` [RFC PATCH 0/3] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Qais Yousef 2023-03-15 14:55 ` Qais Yousef 2023-03-15 17:10 ` Juri Lelli 2023-03-15 17:10 ` Juri Lelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c77bc281-b6e1-1653-6bed-0249f85b7e94@arm.com \ --to=dietmar.eggemann@arm.com \ --cc=agordeev@linux.ibm.com \ --cc=bristot@redhat.com \ --cc=cgroups@vger.kernel.org \ --cc=claudio@evidence.eu.com \ --cc=gor@linux.ibm.com \ --cc=hannes@cmpxchg.org \ --cc=haoluo@google.com \ --cc=hca@linux.ibm.com \ --cc=juri.lelli@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan.x@bytedance.com \ --cc=longman@redhat.com \ --cc=luca.abeni@santannapisa.it \ --cc=mathieu.poirier@linaro.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=qperret@google.com \ --cc=qyousef@layalina.io \ --cc=rickyiu@google.com \ --cc=rostedt@goodmis.org \ --cc=sudeep.holla@arm.com \ --cc=tj@kernel.org \ --cc=tommaso.cucinotta@santannapisa.it \ --cc=vincent.guittot@linaro.org \ --cc=wvw@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.