From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: "Brett Rudley" <brudley@broadcom.com>,
"Arend van Spriel" <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Hante Meuleman" <meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: use kmemdup
Date: Fri, 20 May 2016 09:53:42 +0200 [thread overview]
Message-ID: <c7b2489d-8ae8-e1c5-ab85-ba88d27c9318@broadcom.com> (raw)
In-Reply-To: <1463666357-16719-1-git-send-email-falakreyaz@gmail.com>
On 19-5-2016 15:59, Muhammad Falak R Wani wrote:
> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index d0631b6..705adaa 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6699,11 +6699,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
> return NULL;
> }
>
> - ops = kzalloc(sizeof(*ops), GFP_KERNEL);
> + ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL);
> if (!ops)
> return NULL;
>
> - memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops));
> ifp = netdev_priv(ndev);
> #ifdef CONFIG_PM
> if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))
>
next prev parent reply other threads:[~2016-05-20 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 13:59 [PATCH] brcmfmac: use kmemdup Muhammad Falak R Wani
2016-05-19 13:59 ` Muhammad Falak R Wani
2016-05-20 7:53 ` Arend Van Spriel [this message]
2016-06-14 14:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7b2489d-8ae8-e1c5-ab85-ba88d27c9318@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=falakreyaz@gmail.com \
--cc=frankyl@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.