[PATCH] efi: EFI_DISABLE_RUNTIME should depend on EFI

[PATCH] efi: EFI_DISABLE_RUNTIME should depend on EFI

[Geert Uytterhoeven]

The EFI_DISABLE_RUNTIME config option controls the use of Extensible
Firmware Interface (EFI) runtime services, which matters only if EFI
support is enabled.

Hence add a dependency on EFI, to prevent asking the user about this
control knob when configuring a kernel with EFI support.

Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
 
 config EFI_DISABLE_RUNTIME
 	bool "Disable EFI runtime services support by default"
+	depends on EFI
 	default y if PREEMPT_RT
 	help
 	  Allow to disable the EFI runtime services support by default. This can
-- 
2.25.1

Re: [PATCH] efi: EFI_DISABLE_RUNTIME should depend on EFI

[Javier Martinez Canillas]

Hello Geert,

On 5/24/22 08:54, Geert Uytterhoeven wrote:
> The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> Firmware Interface (EFI) runtime services, which matters only if EFI
> support is enabled.
>

Indeed. Sorry for forgetting that dependency when adding the symbol.
 
> Hence add a dependency on EFI, to prevent asking the user about this
> control knob when configuring a kernel with EFI support.
>

I think you wanted to write here "without EFI support" ?
 
> Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---

Acked-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat

Re: [PATCH] efi: EFI_DISABLE_RUNTIME should depend on EFI

[Geert Uytterhoeven]

Hi Javier,

On Tue, May 24, 2022 at 9:22 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
> On 5/24/22 08:54, Geert Uytterhoeven wrote:
> > The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> > Firmware Interface (EFI) runtime services, which matters only if EFI
> > support is enabled.
> >
>
> Indeed. Sorry for forgetting that dependency when adding the symbol.
>
> > Hence add a dependency on EFI, to prevent asking the user about this
> > control knob when configuring a kernel with EFI support.
> >
>
> I think you wanted to write here "without EFI support" ?

Oops, sorry for that. Need... morning... coffee...

> > Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
>
> Acked-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds