* [syzbot] WARNING in ovs_dp_reset_user_features
@ 2022-10-12 17:43 ` syzbot
0 siblings, 0 replies; 8+ messages in thread
From: syzbot @ 2022-10-12 17:43 UTC (permalink / raw)
To: aahringo, ccaulfie, cluster-devel, davem, dev, edumazet, kuba,
linux-kernel, netdev, pabeni, pshelar, syzkaller-bugs, teigland
Hello,
syzbot found the following issue on:
HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
The issue was bisected to:
commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
Author: Alexander Aring <aahringo@redhat.com>
Date: Wed Jun 22 18:45:23 2022 +0000
fs: dlm: don't use deprecated timeout features by default
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com
Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
------------[ cut here ]------------
Dropping previously announced user features
WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619 ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
Modules linked in:
CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg net/socket.c:734 [inline]
____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
___sys_sendmsg net/socket.c:2536 [inline]
__sys_sendmsg+0x28e/0x390 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fc51f29de89
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cluster-devel] [syzbot] WARNING in ovs_dp_reset_user_features
@ 2022-10-12 17:43 ` syzbot
0 siblings, 0 replies; 8+ messages in thread
From: syzbot @ 2022-10-12 17:43 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hello,
syzbot found the following issue on:
HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
The issue was bisected to:
commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
Author: Alexander Aring <aahringo@redhat.com>
Date: Wed Jun 22 18:45:23 2022 +0000
fs: dlm: don't use deprecated timeout features by default
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+31cde0bef4bbf8ba2d86 at syzkaller.appspotmail.com
Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
------------[ cut here ]------------
Dropping previously announced user features
WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619 ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
Modules linked in:
CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg net/socket.c:734 [inline]
____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
___sys_sendmsg net/socket.c:2536 [inline]
__sys_sendmsg+0x28e/0x390 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fc51f29de89
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller at googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [syzbot] WARNING in ovs_dp_reset_user_features
2022-10-12 17:43 ` [Cluster-devel] " syzbot
@ 2022-10-13 8:12 ` Paolo Abeni
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2022-10-13 8:12 UTC (permalink / raw)
To: syzbot, aahringo, ccaulfie, cluster-devel, davem, dev, edumazet,
kuba, linux-kernel, netdev, pshelar, syzkaller-bugs, teigland
On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
> git tree: upstream
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
> kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
>
> The issue was bisected to:
>
> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> Author: Alexander Aring <aahringo@redhat.com>
> Date: Wed Jun 22 18:45:23 2022 +0000
>
> fs: dlm: don't use deprecated timeout features by default
This commit is not really relevant for the issue, but it makes the
reproducer fail, since it changes the genl_family registration order
and the repro hard-codes the ovs genl family id.
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com
> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
>
> ------------[ cut here ]------------
> Dropping previously announced user features
> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619 ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> Modules linked in:
> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
> RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
> RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
> RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
> R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
> R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
> FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
> genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
> genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
> genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
> netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
> genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
> netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
> netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
> sock_sendmsg_nosec net/socket.c:714 [inline]
> sock_sendmsg net/socket.c:734 [inline]
> ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
> ___sys_sendmsg net/socket.c:2536 [inline]
> __sys_sendmsg+0x28e/0x390 net/socket.c:2565
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
> RIP: 0033:0x7fc51f29de89
> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
> RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
> RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
> R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
> R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
> </TASK>
>
In this specific case it looks like the warning is caused by the fact
that ovs allows an 'outdated' datapath to set user_features (version is
not checked in ovs_dp_change()) but later complains if the same user-
space touch again the same datapath (version check in
ovs_dp_reset_user_features())
/P
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cluster-devel] [syzbot] WARNING in ovs_dp_reset_user_features
@ 2022-10-13 8:12 ` Paolo Abeni
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2022-10-13 8:12 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
> git tree: upstream
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
> kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
>
> The issue was bisected to:
>
> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> Author: Alexander Aring <aahringo@redhat.com>
> Date: Wed Jun 22 18:45:23 2022 +0000
>
> fs: dlm: don't use deprecated timeout features by default
This commit is not really relevant for the issue, but it makes the
reproducer fail, since it changes the genl_family registration order
and the repro hard-codes the ovs genl family id.
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+31cde0bef4bbf8ba2d86 at syzkaller.appspotmail.com
> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
>
> ------------[ cut here ]------------
> Dropping previously announced user features
> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619 ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> Modules linked in:
> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
> RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
> RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
> RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
> R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
> R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
> FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
> genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
> genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
> genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
> netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
> genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
> netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
> netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
> sock_sendmsg_nosec net/socket.c:714 [inline]
> sock_sendmsg net/socket.c:734 [inline]
> ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
> ___sys_sendmsg net/socket.c:2536 [inline]
> __sys_sendmsg+0x28e/0x390 net/socket.c:2565
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
> RIP: 0033:0x7fc51f29de89
> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
> RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
> RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
> R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
> R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
> </TASK>
>
In this specific case it looks like the warning is caused by the fact
that ovs allows an 'outdated' datapath to set user_features (version is
not checked in ovs_dp_change()) but later complains if the same user-
space touch again the same datapath (version check in
ovs_dp_reset_user_features())
/P
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features
2022-10-13 8:12 ` [Cluster-devel] " Paolo Abeni
@ 2022-10-17 13:26 ` Aaron Conole
-1 siblings, 0 replies; 8+ messages in thread
From: Aaron Conole @ 2022-10-17 13:26 UTC (permalink / raw)
To: Paolo Abeni
Cc: syzbot, aahringo, ccaulfie, cluster-devel, davem, dev, edumazet,
kuba, linux-kernel, netdev, pshelar, syzkaller-bugs, teigland
Paolo Abeni <pabeni@redhat.com> writes:
> On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
>> git tree: upstream
>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
>> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
>> compiler: Debian clang version
>> 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
>> ld (GNU Binutils for Debian) 2.35.2
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
>>
>> The issue was bisected to:
>>
>> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
>> Author: Alexander Aring <aahringo@redhat.com>
>> Date: Wed Jun 22 18:45:23 2022 +0000
>>
>> fs: dlm: don't use deprecated timeout features by default
>
> This commit is not really relevant for the issue, but it makes the
> reproducer fail, since it changes the genl_family registration order
> and the repro hard-codes the ovs genl family id.
I have an easy reproducer at:
http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e
(PS: I do plan to do some cleanup and then post this kselftest stuff)
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com
>> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
>>
>> ------------[ cut here ]------------
>> Dropping previously announced user features
>> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
>> ovs_dp_reset_user_features+0x1bc/0x240
>> net/openvswitch/datapath.c:1619
>> Modules linked in:
>> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
>> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
>> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
>> 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
>> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
>> RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
>> RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
>> RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
>> RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
>> R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
>> R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
>> FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>> Call Trace:
>> <TASK>
>> ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
>> genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
>> genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
>> genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
>> netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
>> genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
>> netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
>> netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
>> netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
>> sock_sendmsg_nosec net/socket.c:714 [inline]
>> sock_sendmsg net/socket.c:734 [inline]
>> ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
>> ___sys_sendmsg net/socket.c:2536 [inline]
>> __sys_sendmsg+0x28e/0x390 net/socket.c:2565
>> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>> do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
>> entry_SYSCALL_64_after_hwframe+0x63/0xcd
>> RIP: 0033:0x7fc51f29de89
>> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48
>> 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
>> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
>> RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
>> RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
>> RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
>> RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
>> R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
>> R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
>> </TASK>
>>
> In this specific case it looks like the warning is caused by the fact
> that ovs allows an 'outdated' datapath to set user_features (version is
> not checked in ovs_dp_change()) but later complains if the same user-
> space touch again the same datapath (version check in
> ovs_dp_reset_user_features())
Maybe this should be changed from WARN() to printk(KERN_NOTICE, ..) or
something similar? It can indicate an error condition that will make
the upcall interface unreachable, so I think we should alert the user.
> /P
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cluster-devel] [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features
@ 2022-10-17 13:26 ` Aaron Conole
0 siblings, 0 replies; 8+ messages in thread
From: Aaron Conole @ 2022-10-17 13:26 UTC (permalink / raw)
To: cluster-devel.redhat.com
Paolo Abeni <pabeni@redhat.com> writes:
> On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
>> git tree: upstream
>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
>> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
>> compiler: Debian clang version
>> 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
>> ld (GNU Binutils for Debian) 2.35.2
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
>>
>> The issue was bisected to:
>>
>> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
>> Author: Alexander Aring <aahringo@redhat.com>
>> Date: Wed Jun 22 18:45:23 2022 +0000
>>
>> fs: dlm: don't use deprecated timeout features by default
>
> This commit is not really relevant for the issue, but it makes the
> reproducer fail, since it changes the genl_family registration order
> and the repro hard-codes the ovs genl family id.
I have an easy reproducer at:
http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e
(PS: I do plan to do some cleanup and then post this kselftest stuff)
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+31cde0bef4bbf8ba2d86 at syzkaller.appspotmail.com
>> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
>>
>> ------------[ cut here ]------------
>> Dropping previously announced user features
>> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
>> ovs_dp_reset_user_features+0x1bc/0x240
>> net/openvswitch/datapath.c:1619
>> Modules linked in:
>> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
>> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
>> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
>> 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
>> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
>> RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
>> RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
>> RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
>> RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
>> R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
>> R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
>> FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>> Call Trace:
>> <TASK>
>> ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
>> genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
>> genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
>> genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
>> netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
>> genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
>> netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
>> netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
>> netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
>> sock_sendmsg_nosec net/socket.c:714 [inline]
>> sock_sendmsg net/socket.c:734 [inline]
>> ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
>> ___sys_sendmsg net/socket.c:2536 [inline]
>> __sys_sendmsg+0x28e/0x390 net/socket.c:2565
>> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>> do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
>> entry_SYSCALL_64_after_hwframe+0x63/0xcd
>> RIP: 0033:0x7fc51f29de89
>> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48
>> 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
>> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
>> RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
>> RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
>> RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
>> RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
>> R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
>> R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
>> </TASK>
>>
> In this specific case it looks like the warning is caused by the fact
> that ovs allows an 'outdated' datapath to set user_features (version is
> not checked in ovs_dp_change()) but later complains if the same user-
> space touch again the same datapath (version check in
> ovs_dp_reset_user_features())
Maybe this should be changed from WARN() to printk(KERN_NOTICE, ..) or
something similar? It can indicate an error condition that will make
the upcall interface unreachable, so I think we should alert the user.
> /P
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features
2022-10-17 13:26 ` [Cluster-devel] " Aaron Conole
@ 2022-10-17 17:15 ` Paolo Abeni
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2022-10-17 17:15 UTC (permalink / raw)
To: Aaron Conole
Cc: syzbot, aahringo, ccaulfie, cluster-devel, davem, dev, edumazet,
kuba, linux-kernel, netdev, pshelar, syzkaller-bugs, teigland
On Mon, 2022-10-17 at 09:26 -0400, Aaron Conole wrote:
> Paolo Abeni <pabeni@redhat.com> writes:
> > On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
> > > git tree: upstream
> > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> > > compiler: Debian clang version
> > > 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
> > > ld (GNU Binutils for Debian) 2.35.2
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
> > >
> > > Downloadable assets:
> > > disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> > > vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
> > >
> > > The issue was bisected to:
> > >
> > > commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> > > Author: Alexander Aring <aahringo@redhat.com>
> > > Date: Wed Jun 22 18:45:23 2022 +0000
> > >
> > > fs: dlm: don't use deprecated timeout features by default
> >
> > This commit is not really relevant for the issue, but it makes the
> > reproducer fail, since it changes the genl_family registration order
> > and the repro hard-codes the ovs genl family id.
>
> I have an easy reproducer at:
>
> http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e
>
> (PS: I do plan to do some cleanup and then post this kselftest stuff)
>
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
> > > final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
> > >
> > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com
> > > Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
> > >
> > > ------------[ cut here ]------------
> > > Dropping previously announced user features
> > > WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
> > > ovs_dp_reset_user_features+0x1bc/0x240
> > > net/openvswitch/datapath.c:1619
> > > Modules linked in:
> > > CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
> > > RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> > > Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
> > > 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
> > > 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> > > RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
> > > RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
> > > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
> > > RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
> > > R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
> > > R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
> > > FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
> > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
> > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> > > Call Trace:
> > > <TASK>
> > > ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
> > > genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
> > > genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
> > > genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
> > > netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
> > > genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
> > > netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> > > netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
> > > netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
> > > sock_sendmsg_nosec net/socket.c:714 [inline]
> > > sock_sendmsg net/socket.c:734 [inline]
> > > ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
> > > ___sys_sendmsg net/socket.c:2536 [inline]
> > > __sys_sendmsg+0x28e/0x390 net/socket.c:2565
> > > do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> > > do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
> > > entry_SYSCALL_64_after_hwframe+0x63/0xcd
> > > RIP: 0033:0x7fc51f29de89
> > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48
> > > 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
> > > 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
> > > RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> > > RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
> > > RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
> > > RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
> > > R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
> > > R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
> > > </TASK>
> > >
> > In this specific case it looks like the warning is caused by the fact
> > that ovs allows an 'outdated' datapath to set user_features (version is
> > not checked in ovs_dp_change()) but later complains if the same user-
> > space touch again the same datapath (version check in
> > ovs_dp_reset_user_features())
>
> Maybe this should be changed from WARN() to printk(KERN_NOTICE, ..) or
> something similar?
nowaday it's pr_notice() ;), but even pr_warn() could fit (it will not
trigger a calltrace splat). I think such kind of change it's the right
thing to do.
Adding constraints on user_features change is not going to fly, as
syzkaller could e.g. change the esposed version across different
netlink ops.
Cheers,
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Cluster-devel] [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features
@ 2022-10-17 17:15 ` Paolo Abeni
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Abeni @ 2022-10-17 17:15 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Mon, 2022-10-17 at 09:26 -0400, Aaron Conole wrote:
> Paolo Abeni <pabeni@redhat.com> writes:
> > On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit: e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
> > > git tree: upstream
> > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de042880000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> > > compiler: Debian clang version
> > > 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
> > > ld (GNU Binutils for Debian) 2.35.2
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12173a34880000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1792461a880000
> > >
> > > Downloadable assets:
> > > disk image: https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> > > vmlinux: https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
> > >
> > > The issue was bisected to:
> > >
> > > commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> > > Author: Alexander Aring <aahringo@redhat.com>
> > > Date: Wed Jun 22 18:45:23 2022 +0000
> > >
> > > fs: dlm: don't use deprecated timeout features by default
> >
> > This commit is not really relevant for the issue, but it makes the
> > reproducer fail, since it changes the genl_family registration order
> > and the repro hard-codes the ovs genl family id.
>
> I have an easy reproducer at:
>
> http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e
>
> (PS: I do plan to do some cleanup and then post this kselftest stuff)
>
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c880000
> > > final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c880000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c880000
> > >
> > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > Reported-by: syzbot+31cde0bef4bbf8ba2d86 at syzkaller.appspotmail.com
> > > Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by default")
> > >
> > > ------------[ cut here ]------------
> > > Dropping previously announced user features
> > > WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
> > > ovs_dp_reset_user_features+0x1bc/0x240
> > > net/openvswitch/datapath.c:1619
> > > Modules linked in:
> > > CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
> > > RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> > > Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
> > > 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
> > > 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> > > RSP: 0018:ffffc90003b8f370 EFLAGS: 00010246
> > > RAX: e794c0e413340e00 RBX: ffff8880175cae68 RCX: ffff88801c069d80
> > > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
> > > RBP: 0000000000000008 R08: ffffffff816c58ad R09: ffffed1017364f13
> > > R10: ffffed1017364f13 R11: 1ffff11017364f12 R12: dffffc0000000000
> > > R13: ffff8880175ca450 R14: 1ffff11002eb95cd R15: ffffc90003b8f6b0
> > > FS: 0000555557276300(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
> > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > CR2: 0000000020000916 CR3: 000000001ed81000 CR4: 00000000003506e0
> > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> > > Call Trace:
> > > <TASK>
> > > ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
> > > genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
> > > genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
> > > genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
> > > netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
> > > genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
> > > netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> > > netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
> > > netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
> > > sock_sendmsg_nosec net/socket.c:714 [inline]
> > > sock_sendmsg net/socket.c:734 [inline]
> > > ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
> > > ___sys_sendmsg net/socket.c:2536 [inline]
> > > __sys_sendmsg+0x28e/0x390 net/socket.c:2565
> > > do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> > > do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
> > > entry_SYSCALL_64_after_hwframe+0x63/0xcd
> > > RIP: 0033:0x7fc51f29de89
> > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48
> > > 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
> > > 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
> > > RSP: 002b:00007ffd99ec6ed8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> > > RAX: ffffffffffffffda RBX: 000000000000a2c4 RCX: 00007fc51f29de89
> > > RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003
> > > RBP: 0000000000000000 R08: 00007ffd99ec7078 R09: 00007ffd99ec7078
> > > R10: 00007ffd99ec6950 R11: 0000000000000246 R12: 00007ffd99ec6eec
> > > R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
> > > </TASK>
> > >
> > In this specific case it looks like the warning is caused by the fact
> > that ovs allows an 'outdated' datapath to set user_features (version is
> > not checked in ovs_dp_change()) but later complains if the same user-
> > space touch again the same datapath (version check in
> > ovs_dp_reset_user_features())
>
> Maybe this should be changed from WARN() to printk(KERN_NOTICE, ..) or
> something similar? ?
nowaday it's pr_notice() ;), but even pr_warn() could fit (it will not
trigger a calltrace splat). I think such kind of change it's the right
thing to do.
Adding constraints on user_features change is not going to fly, as
syzkaller could e.g. change the esposed version across different
netlink ops.
Cheers,
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-17 17:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 17:43 [syzbot] WARNING in ovs_dp_reset_user_features syzbot
2022-10-12 17:43 ` [Cluster-devel] " syzbot
2022-10-13 8:12 ` Paolo Abeni
2022-10-13 8:12 ` [Cluster-devel] " Paolo Abeni
2022-10-17 13:26 ` [ovs-dev] " Aaron Conole
2022-10-17 13:26 ` [Cluster-devel] " Aaron Conole
2022-10-17 17:15 ` Paolo Abeni
2022-10-17 17:15 ` [Cluster-devel] " Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.