From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" <longpeng2@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>,
<linux-crypto@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>
Cc: Arei Gonglei <arei.gonglei@huawei.com>,
Corentin Labbe <clabbe@baylibre.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
Date: Mon, 25 May 2020 16:03:00 +0800 [thread overview]
Message-ID: <c81e5d74-b664-8941-149f-8b916986e8cf@huawei.com> (raw)
In-Reply-To: <cbd8ab27-71c3-2fb0-2fa3-263901596773@web.de>
On 2020/5/25 15:36, Markus Elfring wrote:
>> Could you help me to make the sentence better?
>
> How do you think about a wording variant like the following?
>
> So the system will crash when this memory will be used again.
>
Uh, it's much better, thanks.
>
>>> * You proposed to move a call of the function “crypto_finalize_skcipher_request”.
>>> How does this change fit to the mentioned position?
>>>
>> The resources which need to be freed is not used anymore, but the pointers
>> of these resources may be changed in the function
>> "crypto_finalize_skcipher_request", so free these resources before call the
>> function is suitable.
>
> Another alternative:
> The resources which need to be cleaned up are not used any more.
> But the pointers of these resources may be changed in the
> function “crypto_finalize_skcipher_request”.
> Thus release specific resources before calling this function.
>
Oh great! Thanks.
> Regards,
> Markus
>
--
---
Regards,
Longpeng(Mike)
WARNING: multiple messages have this Message-ID (diff)
From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" <longpeng2@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>,
linux-crypto@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: Arei Gonglei <arei.gonglei@huawei.com>,
Corentin Labbe <clabbe@baylibre.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
Date: Mon, 25 May 2020 16:03:00 +0800 [thread overview]
Message-ID: <c81e5d74-b664-8941-149f-8b916986e8cf@huawei.com> (raw)
In-Reply-To: <cbd8ab27-71c3-2fb0-2fa3-263901596773@web.de>
On 2020/5/25 15:36, Markus Elfring wrote:
>> Could you help me to make the sentence better?
>
> How do you think about a wording variant like the following?
>
> So the system will crash when this memory will be used again.
>
Uh, it's much better, thanks.
>
>>> * You proposed to move a call of the function “crypto_finalize_skcipher_request”.
>>> How does this change fit to the mentioned position?
>>>
>> The resources which need to be freed is not used anymore, but the pointers
>> of these resources may be changed in the function
>> "crypto_finalize_skcipher_request", so free these resources before call the
>> function is suitable.
>
> Another alternative:
> The resources which need to be cleaned up are not used any more.
> But the pointers of these resources may be changed in the
> function “crypto_finalize_skcipher_request”.
> Thus release specific resources before calling this function.
>
Oh great! Thanks.
> Regards,
> Markus
>
--
---
Regards,
Longpeng(Mike)
next prev parent reply other threads:[~2020-05-25 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 6:30 [PATCH 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req() Markus Elfring
2020-05-25 7:13 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-25 7:13 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-25 7:36 ` [2/2] " Markus Elfring
2020-05-25 8:03 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.) [this message]
2020-05-25 8:03 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81e5d74-b664-8941-149f-8b916986e8cf@huawei.com \
--to=longpeng2@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=arei.gonglei@huawei.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.