From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, chaotian.jing@mediatek.com, cc.chou@mediatek.com, jiajie.hao@mediatek.com, alice.chao@mediatek.com Subject: Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL Date: Wed, 23 Dec 2020 12:41:08 +0800 [thread overview] Message-ID: <c83d34ca8b0338526f6440f1c4ee43dd@codeaurora.org> (raw) In-Reply-To: <1608697172.14045.5.camel@mtkswgap22> On 2020-12-23 12:19, Stanley Chu wrote: > Hi Can, > > On Tue, 2020-12-22 at 19:34 +0800, Can Guo wrote: >> On 2020-12-22 15:29, Stanley Chu wrote: >> > Flush during hibern8 is sufficient on MediaTek platforms, thus >> > enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL to skip enabling >> > fWriteBoosterBufferFlush during WriteBooster initialization. >> > >> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> >> > --- >> > drivers/scsi/ufs/ufs-mediatek.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/drivers/scsi/ufs/ufs-mediatek.c >> > b/drivers/scsi/ufs/ufs-mediatek.c >> > index 80618af7c872..c55202b92a43 100644 >> > --- a/drivers/scsi/ufs/ufs-mediatek.c >> > +++ b/drivers/scsi/ufs/ufs-mediatek.c >> > @@ -661,6 +661,7 @@ static int ufs_mtk_init(struct ufs_hba *hba) >> > >> > /* Enable WriteBooster */ >> > hba->caps |= UFSHCD_CAP_WB_EN; >> > + hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; >> > hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); >> > >> > if (host->caps & UFS_MTK_CAP_DISABLE_AH8) >> >> I guess we need it too... > > AHHA, if you decide to add this in your platform too later, maybe we > could change the way it does: Keep manual flush disabled by default and > remove this quirk. > Yeah... I will get back with an answer later. Thanks, Can Guo. > Thanks, > Stanley Chu >> >> Change LGTM. >> >> Regards, >> >> Can Guo.
WARNING: multiple messages have this Message-ID (diff)
From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, andy.teng@mediatek.com, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, cc.chou@mediatek.com, avri.altman@wdc.com, alice.chao@mediatek.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, asutoshd@codeaurora.org, chaotian.jing@mediatek.com, bvanassche@acm.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Subject: Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL Date: Wed, 23 Dec 2020 12:41:08 +0800 [thread overview] Message-ID: <c83d34ca8b0338526f6440f1c4ee43dd@codeaurora.org> (raw) In-Reply-To: <1608697172.14045.5.camel@mtkswgap22> On 2020-12-23 12:19, Stanley Chu wrote: > Hi Can, > > On Tue, 2020-12-22 at 19:34 +0800, Can Guo wrote: >> On 2020-12-22 15:29, Stanley Chu wrote: >> > Flush during hibern8 is sufficient on MediaTek platforms, thus >> > enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL to skip enabling >> > fWriteBoosterBufferFlush during WriteBooster initialization. >> > >> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> >> > --- >> > drivers/scsi/ufs/ufs-mediatek.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/drivers/scsi/ufs/ufs-mediatek.c >> > b/drivers/scsi/ufs/ufs-mediatek.c >> > index 80618af7c872..c55202b92a43 100644 >> > --- a/drivers/scsi/ufs/ufs-mediatek.c >> > +++ b/drivers/scsi/ufs/ufs-mediatek.c >> > @@ -661,6 +661,7 @@ static int ufs_mtk_init(struct ufs_hba *hba) >> > >> > /* Enable WriteBooster */ >> > hba->caps |= UFSHCD_CAP_WB_EN; >> > + hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; >> > hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); >> > >> > if (host->caps & UFS_MTK_CAP_DISABLE_AH8) >> >> I guess we need it too... > > AHHA, if you decide to add this in your platform too later, maybe we > could change the way it does: Keep manual flush disabled by default and > remove this quirk. > Yeah... I will get back with an answer later. Thanks, Can Guo. > Thanks, > Stanley Chu >> >> Change LGTM. >> >> Regards, >> >> Can Guo. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-12-23 4:42 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-22 7:29 [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL Stanley Chu 2020-12-22 7:29 ` Stanley Chu 2020-12-22 7:29 ` Stanley Chu 2020-12-22 11:34 ` Can Guo 2020-12-22 11:34 ` Can Guo 2020-12-23 4:19 ` Stanley Chu 2020-12-23 4:19 ` Stanley Chu 2020-12-23 4:19 ` Stanley Chu 2020-12-23 4:41 ` Can Guo [this message] 2020-12-23 4:41 ` Can Guo 2020-12-23 7:47 ` Avri Altman 2020-12-23 7:47 ` Avri Altman 2020-12-23 7:47 ` Avri Altman 2020-12-23 8:35 ` Bean Huo 2020-12-23 8:35 ` Bean Huo 2020-12-23 8:35 ` Bean Huo 2020-12-28 12:59 ` Avri Altman 2020-12-28 12:59 ` Avri Altman 2020-12-28 12:59 ` Avri Altman 2020-12-24 2:21 ` Can Guo 2020-12-24 2:21 ` Can Guo 2020-12-24 7:52 ` Stanley Chu 2020-12-24 7:52 ` Stanley Chu 2020-12-24 7:52 ` Stanley Chu 2020-12-24 11:03 ` Avri Altman 2020-12-24 11:03 ` Avri Altman 2020-12-24 11:03 ` Avri Altman 2020-12-24 12:01 ` Bean Huo 2020-12-24 12:01 ` Bean Huo 2020-12-24 12:01 ` Bean Huo 2020-12-24 13:47 ` Stanley Chu 2020-12-24 13:47 ` Stanley Chu 2020-12-24 13:47 ` Stanley Chu 2020-12-28 1:32 ` Asutosh Das (asd) 2020-12-28 1:32 ` Asutosh Das (asd) 2020-12-28 2:00 ` Stanley Chu 2020-12-28 2:00 ` Stanley Chu 2020-12-28 2:00 ` Stanley Chu 2020-12-28 1:33 ` Can Guo 2020-12-28 1:33 ` Can Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c83d34ca8b0338526f6440f1c4ee43dd@codeaurora.org \ --to=cang@codeaurora.org \ --cc=alice.chao@mediatek.com \ --cc=alim.akhtar@samsung.com \ --cc=andy.teng@mediatek.com \ --cc=asutoshd@codeaurora.org \ --cc=avri.altman@wdc.com \ --cc=beanhuo@micron.com \ --cc=bvanassche@acm.org \ --cc=cc.chou@mediatek.com \ --cc=chaotian.jing@mediatek.com \ --cc=chun-hung.wu@mediatek.com \ --cc=jejb@linux.ibm.com \ --cc=jiajie.hao@mediatek.com \ --cc=kuohong.wang@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matthias.bgg@gmail.com \ --cc=peter.wang@mediatek.com \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.