From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>, linux-usb@vger.kernel.org
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()
Date: Wed, 6 Dec 2017 14:25:01 +0100 [thread overview]
Message-ID: <c873917f-0264-f4c5-3753-dc6a588cfb51@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1712061312090.9552@hadrien>
>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
>> int result;
>> unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
>>
>> - if (!buffer) {
>> - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
>
> I guess the length information would not be so easy to find in the backtrace.
Why do you “guess”?
>> + if (!buffer)
>> return -ENOMEM;
>> - }
Would we like to achieve another consensus on the data which are provided by
a default Linux allocation failure report?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>, linux-usb@vger.kernel.org
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory(
Date: Wed, 06 Dec 2017 13:25:01 +0000 [thread overview]
Message-ID: <c873917f-0264-f4c5-3753-dc6a588cfb51@users.sourceforge.net> (raw)
In-Reply-To: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net>
>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
>> int result;
>> unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
>>
>> - if (!buffer) {
>> - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
>
> I guess the length information would not be so easy to find in the backtrace.
Why do you “guess”?
>> + if (!buffer)
>> return -ENOMEM;
>> - }
Would we like to achieve another consensus on the data which are provided by
a default Linux allocation failure report?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>, linux-usb@vger.kernel.org
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()
Date: Wed, 6 Dec 2017 14:25:01 +0100 [thread overview]
Message-ID: <c873917f-0264-f4c5-3753-dc6a588cfb51@users.sourceforge.net> (raw)
>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
>> int result;
>> unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
>>
>> - if (!buffer) {
>> - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
>
> I guess the length information would not be so easy to find in the backtrace.
Why do you “guess”?
>> + if (!buffer)
>> return -ENOMEM;
>> - }
Would we like to achieve another consensus on the data which are provided by
a default Linux allocation failure report?
Regards,
Markus
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-06 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 12:06 [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() SF Markus Elfring
2017-12-06 12:06 ` SF Markus Elfring
2017-12-06 12:06 ` [PATCH] " SF Markus Elfring
2017-12-06 12:12 ` Julia Lawall
2017-12-06 12:12 ` Julia Lawall
2017-12-06 12:12 ` [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory( Julia Lawall
2017-12-06 13:18 ` [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() Dan Carpenter
2017-12-06 13:18 ` Dan Carpenter
2017-12-06 13:18 ` [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory( Dan Carpenter
2017-12-06 13:25 ` SF Markus Elfring [this message]
2017-12-06 13:25 ` USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() SF Markus Elfring
2017-12-06 13:25 ` [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory( SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c873917f-0264-f4c5-3753-dc6a588cfb51@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.