* [PATCH net-next] net/mlx5: DR, Fix error return code in dr_domain_init_resources()
@ 2019-09-05 9:56 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2019-09-05 9:56 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Mark Bloch, Alex Vesker, Erez Shitrit
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 4ec9e7b02697 ("net/mlx5: DR, Expose steering domain functionality")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
index 3b9cf0bccf4d..461cc2c30538 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
@@ -66,6 +66,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
dmn->uar = mlx5_get_uars_page(dmn->mdev);
if (!dmn->uar) {
mlx5dr_err(dmn, "Couldn't allocate UAR\n");
+ ret = -ENOMEM;
goto clean_pd;
}
@@ -73,6 +74,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
if (!dmn->ste_icm_pool) {
mlx5dr_err(dmn, "Couldn't get icm memory for %s\n",
dev_name(dmn->mdev->device));
+ ret = -ENOMEM;
goto clean_uar;
}
@@ -80,6 +82,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
if (!dmn->action_icm_pool) {
mlx5dr_err(dmn, "Couldn't get action icm memory for %s\n",
dev_name(dmn->mdev->device));
+ ret = -ENOMEM;
goto free_ste_icm_pool;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next] net/mlx5: DR, Fix error return code in dr_domain_init_resources()
@ 2019-09-05 9:56 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2019-09-05 9:56 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Mark Bloch, Alex Vesker, Erez Shitrit
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 4ec9e7b02697 ("net/mlx5: DR, Expose steering domain functionality")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
index 3b9cf0bccf4d..461cc2c30538 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c
@@ -66,6 +66,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
dmn->uar = mlx5_get_uars_page(dmn->mdev);
if (!dmn->uar) {
mlx5dr_err(dmn, "Couldn't allocate UAR\n");
+ ret = -ENOMEM;
goto clean_pd;
}
@@ -73,6 +74,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
if (!dmn->ste_icm_pool) {
mlx5dr_err(dmn, "Couldn't get icm memory for %s\n",
dev_name(dmn->mdev->device));
+ ret = -ENOMEM;
goto clean_uar;
}
@@ -80,6 +82,7 @@ static int dr_domain_init_resources(struct mlx5dr_domain *dmn)
if (!dmn->action_icm_pool) {
mlx5dr_err(dmn, "Couldn't get action icm memory for %s\n",
dev_name(dmn->mdev->device));
+ ret = -ENOMEM;
goto free_ste_icm_pool;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: DR, Fix error return code in dr_domain_init_resources()
2019-09-05 9:56 ` Wei Yongjun
@ 2019-09-05 19:37 ` Saeed Mahameed
-1 siblings, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2019-09-05 19:37 UTC (permalink / raw)
To: Erez Shitrit, weiyongjun1, Mark Bloch, leon, Alex Vesker
Cc: kernel-janitors, netdev, linux-rdma
On Thu, 2019-09-05 at 09:56 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 4ec9e7b02697 ("net/mlx5: DR, Expose steering domain
> functionality")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
Applied to net-next-mlx5.
Thanks !
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: DR, Fix error return code in dr_domain_init_resources()
@ 2019-09-05 19:37 ` Saeed Mahameed
0 siblings, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2019-09-05 19:37 UTC (permalink / raw)
To: Erez Shitrit, weiyongjun1, Mark Bloch, leon, Alex Vesker
Cc: kernel-janitors, netdev, linux-rdma
T24gVGh1LCAyMDE5LTA5LTA1IGF0IDA5OjU2ICswMDAwLCBXZWkgWW9uZ2p1biB3cm90ZToNCj4g
Rml4IHRvIHJldHVybiBuZWdhdGl2ZSBlcnJvciBjb2RlIC1FTk9NRU0gZnJvbSB0aGUgZXJyb3Ig
aGFuZGxpbmcNCj4gY2FzZSBpbnN0ZWFkIG9mIDAsIGFzIGRvbmUgZWxzZXdoZXJlIGluIHRoaXMg
ZnVuY3Rpb24uDQo+IA0KPiBGaXhlczogNGVjOWU3YjAyNjk3ICgibmV0L21seDU6IERSLCBFeHBv
c2Ugc3RlZXJpbmcgZG9tYWluDQo+IGZ1bmN0aW9uYWxpdHkiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBX
ZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNvbT4NCj4gDQoNCkFwcGxpZWQgdG8gbmV0
LW5leHQtbWx4NS4NClRoYW5rcyAhDQoNCg=
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-05 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 9:56 [PATCH net-next] net/mlx5: DR, Fix error return code in dr_domain_init_resources() Wei Yongjun
2019-09-05 9:56 ` Wei Yongjun
2019-09-05 19:37 ` Saeed Mahameed
2019-09-05 19:37 ` Saeed Mahameed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.