* [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake
@ 2018-03-27 7:44 Valentin Korenblit
2018-03-30 21:01 ` Romain Naour
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Valentin Korenblit @ 2018-03-27 7:44 UTC (permalink / raw)
To: buildroot
When imake is installed on the host, it tries to include
freetype headers from host, so we must override ac_cv_path_IMAKE
to avoid this.
Extract from config.log:
configure:14803: checking if we should use imake to help
configure:14820: result: yes
configure:14829: checking for xmkmf
configure:14846: found /usr/bin/xmkmf
configure:14857: result: /usr/bin/xmkmf
configure:14920: testing Using /usr/bin/xmkmf ...
configure:15015: testing IMAKE_CFLAGS -I. -I/usr/include/freetype2
Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
---
package/xterm/xterm.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/xterm/xterm.mk b/package/xterm/xterm.mk
index 645de92e22..ff2b77459e 100644
--- a/package/xterm/xterm.mk
+++ b/package/xterm/xterm.mk
@@ -14,6 +14,9 @@ XTERM_CONF_OPTS = --enable-256-color \
--x-includes=$(STAGING_DIR)/usr/include \
--x-libraries=$(STAGING_DIR)/usr/lib
+# Avoid freetype2 path poisoning using imake
+XTERM_CONF_ENV = ac_cv_path_IMAKE=
+
ifeq ($(BR2_PACKAGE_XLIB_LIBXFT),y)
XTERM_DEPENDENCIES += xlib_libXft
XTERM_CONF_OPTS += --enable-freetype \
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake
2018-03-27 7:44 [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake Valentin Korenblit
@ 2018-03-30 21:01 ` Romain Naour
2018-03-31 20:57 ` Thomas Petazzoni
2018-04-11 15:48 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Romain Naour @ 2018-03-30 21:01 UTC (permalink / raw)
To: buildroot
Hi Valentin, All,
Le 27/03/2018 ? 09:44, Valentin Korenblit a ?crit?:
> When imake is installed on the host, it tries to include
> freetype headers from host, so we must override ac_cv_path_IMAKE
> to avoid this.
>
> Extract from config.log:
>
> configure:14803: checking if we should use imake to help
> configure:14820: result: yes
> configure:14829: checking for xmkmf
> configure:14846: found /usr/bin/xmkmf
> configure:14857: result: /usr/bin/xmkmf
> configure:14920: testing Using /usr/bin/xmkmf ...
> configure:15015: testing IMAKE_CFLAGS -I. -I/usr/include/freetype2
>
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> ---
> package/xterm/xterm.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/xterm/xterm.mk b/package/xterm/xterm.mk
> index 645de92e22..ff2b77459e 100644
> --- a/package/xterm/xterm.mk
> +++ b/package/xterm/xterm.mk
> @@ -14,6 +14,9 @@ XTERM_CONF_OPTS = --enable-256-color \
> --x-includes=$(STAGING_DIR)/usr/include \
> --x-libraries=$(STAGING_DIR)/usr/lib
>
> +# Avoid freetype2 path poisoning using imake
> +XTERM_CONF_ENV = ac_cv_path_IMAKE=
> +
If you look at other ac_cv_path_* override on other packages, the syntax should be:
XTERM_CONF_ENV = ac_cv_path_IMAKE=""
This can be fixed while commiting.
With that fixed:
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Best regards,
Romain
> ifeq ($(BR2_PACKAGE_XLIB_LIBXFT),y)
> XTERM_DEPENDENCIES += xlib_libXft
> XTERM_CONF_OPTS += --enable-freetype \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake
2018-03-27 7:44 [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake Valentin Korenblit
2018-03-30 21:01 ` Romain Naour
@ 2018-03-31 20:57 ` Thomas Petazzoni
2018-04-11 15:48 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-03-31 20:57 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 27 Mar 2018 09:44:34 +0200, Valentin Korenblit wrote:
> When imake is installed on the host, it tries to include
> freetype headers from host, so we must override ac_cv_path_IMAKE
> to avoid this.
>
> Extract from config.log:
>
> configure:14803: checking if we should use imake to help
> configure:14820: result: yes
> configure:14829: checking for xmkmf
> configure:14846: found /usr/bin/xmkmf
> configure:14857: result: /usr/bin/xmkmf
> configure:14920: testing Using /usr/bin/xmkmf ...
> configure:15015: testing IMAKE_CFLAGS -I. -I/usr/include/freetype2
>
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> ---
> package/xterm/xterm.mk | 3 +++
> 1 file changed, 3 insertions(+)
Applied to master after adjusting to ac_cv_path_IMAKE="" as suggested
by Romain.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake
2018-03-27 7:44 [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake Valentin Korenblit
2018-03-30 21:01 ` Romain Naour
2018-03-31 20:57 ` Thomas Petazzoni
@ 2018-04-11 15:48 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-04-11 15:48 UTC (permalink / raw)
To: buildroot
>>>>> "Valentin" == Valentin Korenblit <valentin.korenblit@smile.fr> writes:
> When imake is installed on the host, it tries to include
> freetype headers from host, so we must override ac_cv_path_IMAKE
> to avoid this.
> Extract from config.log:
> configure:14803: checking if we should use imake to help
> configure:14820: result: yes
> configure:14829: checking for xmkmf
> configure:14846: found /usr/bin/xmkmf
> configure:14857: result: /usr/bin/xmkmf
> configure:14920: testing Using /usr/bin/xmkmf ...
> configure:15015: testing IMAKE_CFLAGS -I. -I/usr/include/freetype2
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-11 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27 7:44 [Buildroot] [PATCH] package/xterm: Avoid freetype2 path poisoning using imake Valentin Korenblit
2018-03-30 21:01 ` Romain Naour
2018-03-31 20:57 ` Thomas Petazzoni
2018-04-11 15:48 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.