* [PATCH] drm: increase drm mmap_range size to 1TB
@ 2019-04-17 22:15 Yang, Philip
[not found] ` <20190417221507.933-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Yang, Philip @ 2019-04-17 22:15 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Yang, Philip
After patch "drm: Use the same mmap-range offset and size for GEM and
TTM", application failed to create bo of system memory because drm
mmap_range size decrease to 64GB from original 1TB. This is not big
enough for applications. Increase the drm mmap_range size to 1TB.
Change-Id: Id482af261f56f3289e8873f5985078da599a0998
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
include/drm/drm_vma_manager.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_vma_manager.h b/include/drm/drm_vma_manager.h
index f4f8ff1cdeec..76ac5e97a559 100644
--- a/include/drm/drm_vma_manager.h
+++ b/include/drm/drm_vma_manager.h
@@ -35,7 +35,7 @@
*/
#if BITS_PER_LONG == 64
#define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFFUL >> PAGE_SHIFT) + 1)
-#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 16)
+#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 256)
#else
#define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFUL >> PAGE_SHIFT) + 1)
#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFUL >> PAGE_SHIFT) * 16)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <20190417221507.933-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm: increase drm mmap_range size to 1TB [not found] ` <20190417221507.933-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org> @ 2019-04-17 22:16 ` Kuehling, Felix [not found] ` <c8d289ef-75dc-163e-bea5-cd0d429d8614-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Kuehling, Felix @ 2019-04-17 22:16 UTC (permalink / raw) To: Yang, Philip, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Maling list - DRI developers Adding dri-devel On 2019-04-17 6:15 p.m., Yang, Philip wrote: > After patch "drm: Use the same mmap-range offset and size for GEM and > TTM", application failed to create bo of system memory because drm > mmap_range size decrease to 64GB from original 1TB. This is not big > enough for applications. Increase the drm mmap_range size to 1TB. > > Change-Id: Id482af261f56f3289e8873f5985078da599a0998 > Signed-off-by: Philip Yang <Philip.Yang@amd.com> > --- > include/drm/drm_vma_manager.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_vma_manager.h b/include/drm/drm_vma_manager.h > index f4f8ff1cdeec..76ac5e97a559 100644 > --- a/include/drm/drm_vma_manager.h > +++ b/include/drm/drm_vma_manager.h > @@ -35,7 +35,7 @@ > */ > #if BITS_PER_LONG == 64 > #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFFUL >> PAGE_SHIFT) + 1) > -#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 16) > +#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 256) > #else > #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFUL >> PAGE_SHIFT) + 1) > #define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFUL >> PAGE_SHIFT) * 16) _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <c8d289ef-75dc-163e-bea5-cd0d429d8614-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm: increase drm mmap_range size to 1TB [not found] ` <c8d289ef-75dc-163e-bea5-cd0d429d8614-5C7GfCeVMHo@public.gmane.org> @ 2019-04-18 7:29 ` Thomas Zimmermann 2019-04-18 7:32 ` Chris Wilson 0 siblings, 1 reply; 5+ messages in thread From: Thomas Zimmermann @ 2019-04-18 7:29 UTC (permalink / raw) To: Kuehling, Felix, Yang, Philip, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Maling list - DRI developers [-- Attachment #1.1.1: Type: text/plain, Size: 1947 bytes --] Hi Am 18.04.19 um 00:16 schrieb Kuehling, Felix: > Adding dri-devel > > On 2019-04-17 6:15 p.m., Yang, Philip wrote: >> After patch "drm: Use the same mmap-range offset and size for GEM and >> TTM", application failed to create bo of system memory because drm >> mmap_range size decrease to 64GB from original 1TB. This is not big >> enough for applications. Increase the drm mmap_range size to 1TB. That change in size was accidental. Thanks for restoring the original value. The fix will affect GEM as well. If that is not a problem then Reviewed-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org> Best regards Thomas >> Change-Id: Id482af261f56f3289e8873f5985078da599a0998 >> Signed-off-by: Philip Yang <Philip.Yang-5C7GfCeVMHo@public.gmane.org> >> --- >> include/drm/drm_vma_manager.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/drm/drm_vma_manager.h b/include/drm/drm_vma_manager.h >> index f4f8ff1cdeec..76ac5e97a559 100644 >> --- a/include/drm/drm_vma_manager.h >> +++ b/include/drm/drm_vma_manager.h >> @@ -35,7 +35,7 @@ >> */ >> #if BITS_PER_LONG == 64 >> #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFFUL >> PAGE_SHIFT) + 1) >> -#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 16) >> +#define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 256) >> #else >> #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFUL >> PAGE_SHIFT) + 1) >> #define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFUL >> PAGE_SHIFT) * 16) > _______________________________________________ > dri-devel mailing list > dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: increase drm mmap_range size to 1TB 2019-04-18 7:29 ` Thomas Zimmermann @ 2019-04-18 7:32 ` Chris Wilson 2019-04-18 8:30 ` Christian König 0 siblings, 1 reply; 5+ messages in thread From: Chris Wilson @ 2019-04-18 7:32 UTC (permalink / raw) To: Kuehling, Felix, Yang, Philip, amd-gfx, Maling list - DRI developers, Thomas Zimmermann Quoting Thomas Zimmermann (2019-04-18 08:29:39) > Hi > > Am 18.04.19 um 00:16 schrieb Kuehling, Felix: > > Adding dri-devel > > > > On 2019-04-17 6:15 p.m., Yang, Philip wrote: > >> After patch "drm: Use the same mmap-range offset and size for GEM and > >> TTM", application failed to create bo of system memory because drm > >> mmap_range size decrease to 64GB from original 1TB. This is not big > >> enough for applications. Increase the drm mmap_range size to 1TB. > > That change in size was accidental. Thanks for restoring the original > value. The fix will affect GEM as well. If that is not a problem then > Why even have an artificial restriction? -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: increase drm mmap_range size to 1TB 2019-04-18 7:32 ` Chris Wilson @ 2019-04-18 8:30 ` Christian König 0 siblings, 0 replies; 5+ messages in thread From: Christian König @ 2019-04-18 8:30 UTC (permalink / raw) To: Chris Wilson, Kuehling, Felix, Yang, Philip, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Maling list - DRI developers, Thomas Zimmermann Am 18.04.19 um 09:32 schrieb Chris Wilson: > Quoting Thomas Zimmermann (2019-04-18 08:29:39) >> Hi >> >> Am 18.04.19 um 00:16 schrieb Kuehling, Felix: >>> Adding dri-devel >>> >>> On 2019-04-17 6:15 p.m., Yang, Philip wrote: >>>> After patch "drm: Use the same mmap-range offset and size for GEM and >>>> TTM", application failed to create bo of system memory because drm >>>> mmap_range size decrease to 64GB from original 1TB. This is not big >>>> enough for applications. Increase the drm mmap_range size to 1TB. >> That change in size was accidental. Thanks for restoring the original >> value. The fix will affect GEM as well. If that is not a problem then >> > Why even have an artificial restriction? Well one possible explanation is that we somewhere need to allocate memory to handle all that address space. E.g. when it is managed with a radix or similar. But as far as I remember there are only lists and r/b trees involved here, so yeah doesn't make to much sense. Anyway that is not the topic of this patch and it is Reviewed-by: Christian König <christian.koenig@amd.com> for now. Regards, Christian. > -Chris > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-18 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 22:15 [PATCH] drm: increase drm mmap_range size to 1TB Yang, Philip
[not found] ` <20190417221507.933-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org>
2019-04-17 22:16 ` Kuehling, Felix
[not found] ` <c8d289ef-75dc-163e-bea5-cd0d429d8614-5C7GfCeVMHo@public.gmane.org>
2019-04-18 7:29 ` Thomas Zimmermann
2019-04-18 7:32 ` Chris Wilson
2019-04-18 8:30 ` Christian König
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.