* [PATCH] kbuild: show the install image name and path
@ 2022-06-02 1:50 Keith Busch
2022-06-02 14:52 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Keith Busch @ 2022-06-02 1:50 UTC (permalink / raw)
To: linux-kbuild, linux-kernel; +Cc: Keith Busch, Masahiro Yamada
From: Keith Busch <kbusch@kernel.org>
Prior to commit f774f5bb87d13 ("kbuild: factor out the common
installation code into"), a 'make install' would print out the install
command like:
sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
arch/x86/boot/bzImage System.map "/boot"
This output was very useful for my workflow, so this patch prints it out
again. I'm not sure if there's a better way to do this than what's
implemented here, so any feedback is appreciated.
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
scripts/install.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/install.sh b/scripts/install.sh
index 9bb0fb44f04a..2989d25ef069 100755
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -33,6 +33,7 @@ do
# installkernel(8) says the parameters are like follows:
#
# installkernel version zImage System.map [directory]
+ echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
done
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: show the install image name and path
2022-06-02 1:50 [PATCH] kbuild: show the install image name and path Keith Busch
@ 2022-06-02 14:52 ` Masahiro Yamada
2022-06-02 15:04 ` Randy Dunlap
2022-06-02 16:26 ` Keith Busch
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2022-06-02 14:52 UTC (permalink / raw)
To: Keith Busch
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Keith Busch
On Thu, Jun 2, 2022 at 10:51 AM Keith Busch <kbusch@fb.com> wrote:
>
> From: Keith Busch <kbusch@kernel.org>
>
> Prior to commit f774f5bb87d13 ("kbuild: factor out the common
> installation code into"), a 'make install' would print out the install
> command like:
>
> sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
> arch/x86/boot/bzImage System.map "/boot"
>
> This output was very useful for my workflow, so this patch prints it out
> again. I'm not sure if there's a better way to do this than what's
> implemented here, so any feedback is appreciated.
>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> scripts/install.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/install.sh b/scripts/install.sh
> index 9bb0fb44f04a..2989d25ef069 100755
> --- a/scripts/install.sh
> +++ b/scripts/install.sh
> @@ -33,6 +33,7 @@ do
> # installkernel(8) says the parameters are like follows:
> #
> # installkernel version zImage System.map [directory]
> + echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
> exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
> done
>
> --
> 2.30.2
>
You said "useful for *my* flow",
so you can do whatever you think is useful in
${HOME}/bin/${INSTALLKERNEL}, can't you?
$ cat ~/bin/installkernel
#!/bin/sh
echo '== useful info for my workflow =='
echo "$@"
echo '================================='
exec /sbin/${INSTALLKERNEL} "$@"
$ chmod +x ~/bin/installkernel
$ make install
INSTALL /boot
== useful info for my workflow ==
5.17.0 arch/x86/boot/bzImage System.map /boot
=================================
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: show the install image name and path
2022-06-02 14:52 ` Masahiro Yamada
@ 2022-06-02 15:04 ` Randy Dunlap
2022-06-02 16:26 ` Keith Busch
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-06-02 15:04 UTC (permalink / raw)
To: Masahiro Yamada, Keith Busch
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Keith Busch
On 6/2/22 07:52, Masahiro Yamada wrote:
> On Thu, Jun 2, 2022 at 10:51 AM Keith Busch <kbusch@fb.com> wrote:
>>
>> From: Keith Busch <kbusch@kernel.org>
>>
>> Prior to commit f774f5bb87d13 ("kbuild: factor out the common
>> installation code into"), a 'make install' would print out the install
>> command like:
>>
>> sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
>> arch/x86/boot/bzImage System.map "/boot"
>>
>> This output was very useful for my workflow, so this patch prints it out
>> again. I'm not sure if there's a better way to do this than what's
>> implemented here, so any feedback is appreciated.
>>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Signed-off-by: Keith Busch <kbusch@kernel.org>
>> ---
>> scripts/install.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/install.sh b/scripts/install.sh
>> index 9bb0fb44f04a..2989d25ef069 100755
>> --- a/scripts/install.sh
>> +++ b/scripts/install.sh
>> @@ -33,6 +33,7 @@ do
>> # installkernel(8) says the parameters are like follows:
>> #
>> # installkernel version zImage System.map [directory]
>> + echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
>> exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
>> done
>>
>> --
>> 2.30.2
>>
>
> You said "useful for *my* flow",
> so you can do whatever you think is useful in
> ${HOME}/bin/${INSTALLKERNEL}, can't you?
>
>
True. E.g., my kernel installer also shows me
a) the modules install path (e.g., /lib/modules/$KERNEL_RELEASE)
b) the number of modules installed
>
>
> $ cat ~/bin/installkernel
> #!/bin/sh
>
> echo '== useful info for my workflow =='
> echo "$@"
> echo '================================='
>
> exec /sbin/${INSTALLKERNEL} "$@"
>
>
>
>
> $ chmod +x ~/bin/installkernel
>
> $ make install
> INSTALL /boot
> == useful info for my workflow ==
> 5.17.0 arch/x86/boot/bzImage System.map /boot
> =================================
>
>
>
>
>
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: show the install image name and path
2022-06-02 14:52 ` Masahiro Yamada
2022-06-02 15:04 ` Randy Dunlap
@ 2022-06-02 16:26 ` Keith Busch
1 sibling, 0 replies; 4+ messages in thread
From: Keith Busch @ 2022-06-02 16:26 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Keith Busch, Linux Kbuild mailing list, Linux Kernel Mailing List
On Thu, Jun 02, 2022 at 11:52:24PM +0900, Masahiro Yamada wrote:
>
> You said "useful for *my* flow",
> so you can do whatever you think is useful in
> ${HOME}/bin/${INSTALLKERNEL}, can't you?
Thanks for the suggestion, that works for me!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-02 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 1:50 [PATCH] kbuild: show the install image name and path Keith Busch
2022-06-02 14:52 ` Masahiro Yamada
2022-06-02 15:04 ` Randy Dunlap
2022-06-02 16:26 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.