All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/amdgpu: Modify sdma instance number
@ 2019-08-21 14:32 Gang Ba
       [not found] ` <1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Gang Ba @ 2019-08-21 14:32 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Ba, Gang

To upgrade performance in small bar mode, set sdma buffer function
ring and pte function ring to use different instance.

Change-Id: Ida6377914eb68a188f745e63409f344f0ce1a8c4
Signed-off-by: Gang Ba <gaba@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index 071d6c9..5aca9bb4a 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
 {
 	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
 	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
-		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
+		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
 	else
 		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
 }
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/amdgpu: Modify sdma instance number
       [not found] ` <1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org>
@ 2019-08-21 14:35   ` Christian König
  0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2019-08-21 14:35 UTC (permalink / raw)
  To: Gang Ba, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Ba, Gang

Am 21.08.19 um 16:32 schrieb Gang Ba:
> To upgrade performance in small bar mode, set sdma buffer function
> ring and pte function ring to use different instance.

NAK, we intentionally reserved the first paging queue here.

I wanted to revert that as well, but in this case you would need to 
revert the whole patch and not just this change.

Just look for the patch adding that line and completely revert it instead.

Regards,
Christian.

>
> Change-Id: Ida6377914eb68a188f745e63409f344f0ce1a8c4
> Signed-off-by: Gang Ba <gaba@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 071d6c9..5aca9bb4a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
>   {
>   	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
>   	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
> -		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
> +		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
>   	else
>   		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
>   }

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-21 14:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 14:32 [PATCH] drm/amd/amdgpu: Modify sdma instance number Gang Ba
     [not found] ` <1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org>
2019-08-21 14:35   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.