[PATCH] define rpi0w sdhci pinctrl state

[PATCH] define rpi0w sdhci pinctrl state

[Nick Hudson]

I'm still not sure where I should be sending this, but here goes.

Define thesdhci pinctrl state as "default" so it gets applied correctly
and to match all other RPis

Signed-off-by: Nick Hudson <skrll@netbsd.org>
---
Index: bcm2835-rpi-zero-w.dts
===================================================================
RCS file:
/cvsroot/src/sys/external/gpl2/dts/dist/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts,v
retrieving revision 1.1.1.4
diff -u -p -r1.1.1.4 bcm2835-rpi-zero-w.dts
--- bcm2835-rpi-zero-w.dts	3 Jan 2020 14:33:09 -0000	1.1.1.4
+++ bcm2835-rpi-zero-w.dts	19 Feb 2020 07:53:54 -0000
@@ -112,6 +112,7 @@
  &sdhci {
  	#address-cells = <1>;
  	#size-cells = <0>;
+	pinctrl-names = "default";
  	pinctrl-0 = <&emmc_gpio34 &gpclk2_gpio43>;
  	bus-width = <4>;
  	mmc-pwrseq = <&wifi_pwrseq>;

Re: [PATCH] define rpi0w sdhci pinctrl state

[Stefan Wahren]

Hi Nick,

Am 27.02.20 um 00:33 schrieb Nick Hudson:
> I'm still not sure where I should be sending this, but here goes.

the addresses are right. Please rebase your change against recent Linux
git tree and generate a git patch, otherwise we cannot apply your it.

I suggest the following subject:

ARM: bcm2835-rpi-zero-w: Add missing pinctrl name

Thanks
Stefan

>
> Define thesdhci pinctrl state as "default" so it gets applied correctly
> and to match all other RPis
>
> Signed-off-by: Nick Hudson <skrll@netbsd.org>
> ---
> Index: bcm2835-rpi-zero-w.dts
> ===================================================================
> RCS file:
> /cvsroot/src/sys/external/gpl2/dts/dist/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts,v
>
> retrieving revision 1.1.1.4
> diff -u -p -r1.1.1.4 bcm2835-rpi-zero-w.dts
> --- bcm2835-rpi-zero-w.dts    3 Jan 2020 14:33:09 -0000    1.1.1.4
> +++ bcm2835-rpi-zero-w.dts    19 Feb 2020 07:53:54 -0000
> @@ -112,6 +112,7 @@
>  &sdhci {
>      #address-cells = <1>;
>      #size-cells = <0>;
> +    pinctrl-names = "default";
>      pinctrl-0 = <&emmc_gpio34 &gpclk2_gpio43>;
>      bus-width = <4>;
>      mmc-pwrseq = <&wifi_pwrseq>;
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel

Re: [PATCH] define rpi0w sdhci pinctrl state

[Nick Hudson]

On 27/02/2020 17:53, Stefan Wahren wrote:
> Hi Nick,
>
> Am 27.02.20 um 00:33 schrieb Nick Hudson:
>> I'm still not sure where I should be sending this, but here goes.
>
> the addresses are right. Please rebase your change against recent Linux
> git tree and generate a git patch, otherwise we cannot apply your it.
Oops, I see I sent the comletely the wrong diff... will fix.

>
> I suggest the following subject:
>
> ARM: bcm2835-rpi-zero-w: Add missing pinctrl name

will do.

>
> Thanks
> Stefan

Thanks,
Nick

Re: [PATCH] define rpi0w sdhci pinctrl state

[Nick Hudson]

On 28/02/2020 11:52, Nick Hudson wrote:
>
>
> On 27/02/2020 17:53, Stefan Wahren wrote:
>> Hi Nick,
>>
>> Am 27.02.20 um 00:33 schrieb Nick Hudson:
>>> I'm still not sure where I should be sending this, but here goes.
>>
>> the addresses are right. Please rebase your change against recent Linux
>> git tree and generate a git patch, otherwise we cannot apply your it.
> Oops, I see I sent the comletely the wrong diff... will fix.
>
>>
>> I suggest the following subject:
>>
>> ARM: bcm2835-rpi-zero-w: Add missing pinctrl name

So, I did this, but it's stuck pending ML moderator approval :(
I sent it on Saturday.

Do I need to try again?

Thanks,
Nick

Re: [PATCH] define rpi0w sdhci pinctrl state

[Nicolas Saenz Julienne]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

Hi Nick,

On Wed, 2020-03-04 at 07:33 +0000, Nick Hudson wrote:
> 
> On 28/02/2020 11:52, Nick Hudson wrote:
> > 
> > On 27/02/2020 17:53, Stefan Wahren wrote:
> > > Hi Nick,
> > > 
> > > Am 27.02.20 um 00:33 schrieb Nick Hudson:
> > > > I'm still not sure where I should be sending this, but here goes.
> > > 
> > > the addresses are right. Please rebase your change against recent Linux
> > > git tree and generate a git patch, otherwise we cannot apply your it.
> > Oops, I see I sent the comletely the wrong diff... will fix.
> > 
> > > I suggest the following subject:
> > > 
> > > ARM: bcm2835-rpi-zero-w: Add missing pinctrl name
> 
> So, I did this, but it's stuck pending ML moderator approval :(
> I sent it on Saturday.
> 
> Do I need to try again?

I didn't receive anything myself, so I guess something went wrong.

I'd say try again :)

Regards,
Nicolas


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]