[PATCH] phy: bcm-ns-usb2: improve printing ref clk errors

[PATCH] phy: bcm-ns-usb2: improve printing ref clk errors

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

Print actual error number to help debugging issues but also avoid
printing -EPROBE_DEFER.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/phy/broadcom/phy-bcm-ns-usb2.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
index 98d32729a45d..4cb70785ccb4 100644
--- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
+++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
@@ -132,8 +132,12 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
 
 	usb2->ref_clk = devm_clk_get(dev, "phy-ref-clk");
 	if (IS_ERR(usb2->ref_clk)) {
-		dev_err(dev, "Clock not defined\n");
-		return PTR_ERR(usb2->ref_clk);
+		int err = PTR_ERR(usb2->ref_clk);
+
+		if (err != -EPROBE_DEFER)
+			dev_err(dev, "Failed to get ref clk: %d\n", err);
+
+		return err;
 	}
 
 	usb2->phy = devm_phy_create(dev, NULL, &ops);
-- 
2.31.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: bcm-ns-usb2: improve printing ref clk errors

[Florian Fainelli]

On 11/23/21 1:48 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Print actual error number to help debugging issues but also avoid
> printing -EPROBE_DEFER.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/phy/broadcom/phy-bcm-ns-usb2.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> index 98d32729a45d..4cb70785ccb4 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> @@ -132,8 +132,12 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
>  
>  	usb2->ref_clk = devm_clk_get(dev, "phy-ref-clk");
>  	if (IS_ERR(usb2->ref_clk)) {
> -		dev_err(dev, "Clock not defined\n");
> -		return PTR_ERR(usb2->ref_clk);
> +		int err = PTR_ERR(usb2->ref_clk);

dev_err_probe() should take care of that for you already.
-- 
Florian

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH V2] phy: bcm-ns-usb2: improve printing ref clk errors

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

Improve message & use dev_err_probe() helper which prints actual error
(helpful for debugging) and deals with -EPROBE_DEFER.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Use dev_err_probe() - thank you Florian!
---
 drivers/phy/broadcom/phy-bcm-ns-usb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
index 98d32729a45d..6a36e187d100 100644
--- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
+++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
@@ -132,7 +132,7 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
 
 	usb2->ref_clk = devm_clk_get(dev, "phy-ref-clk");
 	if (IS_ERR(usb2->ref_clk)) {
-		dev_err(dev, "Clock not defined\n");
+		dev_err_probe(dev, PTR_ERR(usb2->ref_clk), "failed to get ref clk\n");
 		return PTR_ERR(usb2->ref_clk);
 	}
 
-- 
2.31.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH V2] phy: bcm-ns-usb2: improve printing ref clk errors

[Florian Fainelli]

On 11/23/21 2:15 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Improve message & use dev_err_probe() helper which prints actual error
> (helpful for debugging) and deals with -EPROBE_DEFER.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH V2] phy: bcm-ns-usb2: improve printing ref clk errors

[Vinod Koul]

On 23-11-21, 23:15, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Improve message & use dev_err_probe() helper which prints actual error
> (helpful for debugging) and deals with -EPROBE_DEFER.

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy