All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH/RFC] dvb-core: drop stubs for llseek()
@ 2016-04-21 21:05 Dominic Chen
  0 siblings, 0 replies; only message in thread
From: Dominic Chen @ 2016-04-21 21:05 UTC (permalink / raw)
  To: linux-media

Since the default behavior in vfs_llseek() is now no_llseek(), and
filp->f_pos / ppos are not actually used anywhere in dvb, drop the
inconsistent llseek() stubs.

Signed-off-by: Dominic Chen <d.c.ddcc@gmail.com>
---
 drivers/media/dvb-core/dmxdev.c         | 2 --
 drivers/media/dvb-core/dvb_ca_en50221.c | 1 -
 drivers/media/dvb-core/dvb_frontend.c   | 1 -
 drivers/media/dvb-core/dvb_net.c        | 1 -
 drivers/media/dvb-core/dvbdev.c         | 1 -
 5 files changed, 6 deletions(-)

diff --git a/drivers/media/dvb-core/dmxdev.c
b/drivers/media/dvb-core/dmxdev.c
index a168cbe..25494bf 100644
--- a/drivers/media/dvb-core/dmxdev.c
+++ b/drivers/media/dvb-core/dmxdev.c
@@ -1135,7 +1135,6 @@ static const struct file_operations dvb_demux_fops = {
     .open = dvb_demux_open,
     .release = dvb_demux_release,
     .poll = dvb_demux_poll,
-    .llseek = default_llseek,
 };
 
 static const struct dvb_device dvbdev_demux = {
@@ -1211,7 +1210,6 @@ static const struct file_operations dvb_dvr_fops = {
     .open = dvb_dvr_open,
     .release = dvb_dvr_release,
     .poll = dvb_dvr_poll,
-    .llseek = default_llseek,
 };
 
 static const struct dvb_device dvbdev_dvr = {
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-core/dvb_ca_en50221.c
index f82cd1f..e736fb9 100644
--- a/drivers/media/dvb-core/dvb_ca_en50221.c
+++ b/drivers/media/dvb-core/dvb_ca_en50221.c
@@ -1636,7 +1636,6 @@ static const struct file_operations dvb_ca_fops = {
     .open = dvb_ca_en50221_io_open,
     .release = dvb_ca_en50221_io_release,
     .poll = dvb_ca_en50221_io_poll,
-    .llseek = noop_llseek,
 };
 
 static const struct dvb_device dvbdev_ca = {
diff --git a/drivers/media/dvb-core/dvb_frontend.c
b/drivers/media/dvb-core/dvb_frontend.c
index c014261..e29543c 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -2600,7 +2600,6 @@ static const struct file_operations
dvb_frontend_fops = {
     .poll        = dvb_frontend_poll,
     .open        = dvb_frontend_open,
     .release    = dvb_frontend_release,
-    .llseek        = noop_llseek,
 };
 
 int dvb_frontend_suspend(struct dvb_frontend *fe)
diff --git a/drivers/media/dvb-core/dvb_net.c
b/drivers/media/dvb-core/dvb_net.c
index ce6a711..d4af8d0 100644
--- a/drivers/media/dvb-core/dvb_net.c
+++ b/drivers/media/dvb-core/dvb_net.c
@@ -1457,7 +1457,6 @@ static const struct file_operations dvb_net_fops = {
     .unlocked_ioctl = dvb_net_ioctl,
     .open =    dvb_generic_open,
     .release = dvb_net_close,
-    .llseek = noop_llseek,
 };
 
 static const struct dvb_device dvbdev_net = {
diff --git a/drivers/media/dvb-core/dvbdev.c
b/drivers/media/dvb-core/dvbdev.c
index e1684c5..bc8086d 100644
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -101,7 +101,6 @@ static const struct file_operations dvb_device_fops =
 {
     .owner =    THIS_MODULE,
     .open =        dvb_device_open,
-    .llseek =    noop_llseek,
 };
 
 static struct cdev dvb_device_cdev;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-21 21:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 21:05 [PATCH/RFC] dvb-core: drop stubs for llseek() Dominic Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.