Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183

[Rex-BC Chen <rex-bc.chen@mediatek.com>]

On Wed, 2022-04-06 at 16:44 +0200, Krzysztof Kozlowski wrote:
> On 06/04/2022 11:46, Rex-BC Chen wrote:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> 
> Just because one feature is not supported, it does not mean they are
> incompatible, which you claim in the patch below. Are you sure they
> are
> really incompatible and MT8173 fallback cannot be used?
> 
> 
> Best regards,
> Krzysztof

Hello Krzysztof,

Thanks for your review.

The difference of disp_aal for each MediaTek SoCs is "has_gamma".
And we only control this variable for different MediaTek SoCs.

The value of has_gamma for MT8173 is true.
The value of has_gamma for MT8183 is false. (Moreover, the driver data
is null for MT8183)

From this situation, I think it's not compatible between MT8173 and
MT8183.

reference: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_disp_aal.c?h=v5.18-rc1#n153

BRs,
Rex