From: Robin Murphy <robin.murphy@arm.com> To: Sven Peter <sven@svenpeter.dev>, Srinath Mannam <srinath.mannam@broadcom.com>, Joerg Roedel <joro@8bytes.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, poza@codeaurora.org Cc: iommu <iommu@lists.linux-foundation.org>, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] iommu/dma: Fix IOVA reserve dma ranges Date: Thu, 3 Jun 2021 12:00:46 +0100 [thread overview] Message-ID: <c9b5900b-8212-35c1-c358-46158d34b253@arm.com> (raw) In-Reply-To: <c72a45e4-c156-4a62-bfd7-9cf8a31ff499@www.fastmail.com> On 2021-06-02 21:18, Sven Peter wrote: > Hi, > > I just ran into the exact same issue while working on the M1 DART IOMMU driver > and it was fixed by this commit. Thanks! > > Would be great if this could be picked up. Oops, apparently I was happy enough with this 9 months ago to forget about it, so if it helps, Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Tested-by: Sven Peter <sven@svenpeter.dev> > > > Best, > > > Sven > > > On Mon, Sep 14, 2020, at 09:23, Srinath Mannam via iommu wrote: >> Fix IOVA reserve failure in the case when address of first memory region >> listed in dma-ranges is equal to 0x0. >> >> Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible >> DMA address") >> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >> --- >> Changes from v2: >> Modify error message with useful information based on Bjorn's >> comments. >> >> Changes from v1: >> Removed unnecessary changes based on Robin's review comments. >> >> drivers/iommu/dma-iommu.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c >> index 5141d49a046b..5b9791f35c5e 100644 >> --- a/drivers/iommu/dma-iommu.c >> +++ b/drivers/iommu/dma-iommu.c >> @@ -217,9 +217,11 @@ static int iova_reserve_pci_windows(struct pci_dev *dev, >> lo = iova_pfn(iovad, start); >> hi = iova_pfn(iovad, end); >> reserve_iova(iovad, lo, hi); >> - } else { >> + } else if (end < start) { >> /* dma_ranges list should be sorted */ >> - dev_err(&dev->dev, "Failed to reserve IOVA\n"); >> + dev_err(&dev->dev, >> + "Failed to reserve IOVA [%#010llx-%#010llx]\n", >> + start, end); >> return -EINVAL; >> } >> >> -- >> 2.17.1 >> >> _______________________________________________ >> iommu mailing list >> iommu@lists.linux-foundation.org >> https://lists.linuxfoundation.org/mailman/listinfo/iommu >> >>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: Sven Peter <sven@svenpeter.dev>, Srinath Mannam <srinath.mannam@broadcom.com>, Joerg Roedel <joro@8bytes.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, poza@codeaurora.org Cc: iommu <iommu@lists.linux-foundation.org>, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] iommu/dma: Fix IOVA reserve dma ranges Date: Thu, 3 Jun 2021 12:00:46 +0100 [thread overview] Message-ID: <c9b5900b-8212-35c1-c358-46158d34b253@arm.com> (raw) In-Reply-To: <c72a45e4-c156-4a62-bfd7-9cf8a31ff499@www.fastmail.com> On 2021-06-02 21:18, Sven Peter wrote: > Hi, > > I just ran into the exact same issue while working on the M1 DART IOMMU driver > and it was fixed by this commit. Thanks! > > Would be great if this could be picked up. Oops, apparently I was happy enough with this 9 months ago to forget about it, so if it helps, Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Tested-by: Sven Peter <sven@svenpeter.dev> > > > Best, > > > Sven > > > On Mon, Sep 14, 2020, at 09:23, Srinath Mannam via iommu wrote: >> Fix IOVA reserve failure in the case when address of first memory region >> listed in dma-ranges is equal to 0x0. >> >> Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible >> DMA address") >> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >> --- >> Changes from v2: >> Modify error message with useful information based on Bjorn's >> comments. >> >> Changes from v1: >> Removed unnecessary changes based on Robin's review comments. >> >> drivers/iommu/dma-iommu.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c >> index 5141d49a046b..5b9791f35c5e 100644 >> --- a/drivers/iommu/dma-iommu.c >> +++ b/drivers/iommu/dma-iommu.c >> @@ -217,9 +217,11 @@ static int iova_reserve_pci_windows(struct pci_dev *dev, >> lo = iova_pfn(iovad, start); >> hi = iova_pfn(iovad, end); >> reserve_iova(iovad, lo, hi); >> - } else { >> + } else if (end < start) { >> /* dma_ranges list should be sorted */ >> - dev_err(&dev->dev, "Failed to reserve IOVA\n"); >> + dev_err(&dev->dev, >> + "Failed to reserve IOVA [%#010llx-%#010llx]\n", >> + start, end); >> return -EINVAL; >> } >> >> -- >> 2.17.1 >> >> _______________________________________________ >> iommu mailing list >> iommu@lists.linux-foundation.org >> https://lists.linuxfoundation.org/mailman/listinfo/iommu >> >> _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-03 11:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-14 7:23 [PATCH v3] iommu/dma: Fix IOVA reserve dma ranges Srinath Mannam 2020-09-14 7:23 ` Srinath Mannam via iommu 2021-06-02 20:18 ` Sven Peter 2021-06-02 20:18 ` Sven Peter via iommu 2021-06-03 11:00 ` Robin Murphy [this message] 2021-06-03 11:00 ` Robin Murphy 2021-06-04 15:33 ` Joerg Roedel 2021-06-04 15:33 ` Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c9b5900b-8212-35c1-c358-46158d34b253@arm.com \ --to=robin.murphy@arm.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bhelgaas@google.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=poza@codeaurora.org \ --cc=srinath.mannam@broadcom.com \ --cc=sven@svenpeter.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.