All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikhil M Jain <n-jain1@ti.com>
To: Simon Glass <sjg@chromium.org>
Cc: <u-boot@lists.denx.de>, <agust@denx.de>, <devarsht@ti.com>,
	<trini@konsulko.com>, <vigneshr@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH 0/9] Enable splash screen
Date: Wed, 15 Mar 2023 11:36:54 +0530	[thread overview]
Message-ID: <c9c8f7fc-514d-80ac-1df2-a8a920ccc9c6@ti.com> (raw)
In-Reply-To: <CAPnjgZ2RZkX-Msz=ZGTa_t6xkT-aCG5q8+S2b8BjAR89jiKRzw@mail.gmail.com>

Hi Simon,

On 15/03/23 03:38, Simon Glass wrote:
> Hi Nikhil,
> 
> On Mon, 13 Mar 2023 at 04:15, Nikhil M Jain <n-jain1@ti.com> wrote:
>>
>> To enable splash screen at SPL stage move video driver and splash screen
>> framework at SPL, which will bring up image on display very quickly and
>> thus have early display support in SPL.
>>
>> Nikhil M Jain (9):
>>    drivers: video: Kconfig: Necessary configs for video at SPL
>>    drivers: video: tidss: Kconfig: Configs to enable TIDSS at SPL
>>    cmd: Kconfig: Add necessary configs for splash screen at SPL
>>    drivers: video: Makefile: Compile video driver files at SPL
>>    drivers: video: tidss: Makefile: Add condition to compile TIDSS at SPL
>>    cmd: Makefile: Add rules to build bmp.c and read.c at SPL
>>    common: splash: Enable splash_display at SPL stage
>>    drivers: video: video-uclass: Disable u-boot logo at SPL
>>    board: ti: am62x: evm: OSPI support for splash screen
>>
>>   board/ti/am62x/evm.c         |  6 ++++++
>>   cmd/Kconfig                  | 17 +++++++++++++++++
>>   cmd/Makefile                 |  2 ++
>>   common/splash.c              |  2 +-
>>   drivers/video/Kconfig        | 32 ++++++++++++++++++++++++++++----
>>   drivers/video/Makefile       |  6 ++++++
>>   drivers/video/tidss/Kconfig  |  6 ++++++
>>   drivers/video/tidss/Makefile |  1 +
>>   drivers/video/video-uclass.c |  2 +-
>>   include/splash.h             |  2 +-
>>   10 files changed, 69 insertions(+), 7 deletions(-)
> 
> I'm not necessarily arguing against this, but what is the need for
> this? How many milliseconds earlier does the image appear with this
> patch? What is the bottleneck? We should be able to get to U-Boot
> proper very quickly.
> 
There is a significant difference in time, by adding support in SPL 
splash screen comes up by approx 650ms and at u-boot proper it comes at 
2.6s, measured from first print in console as seen on AM62x. Also we 
plan to skip u-boot proper and load kernel directly.

> Regards,
> Simon

Regards,
Nikhil

  reply	other threads:[~2023-03-15  6:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 10:14 [PATCH 0/9] Enable splash screen Nikhil M Jain
2023-03-13 10:14 ` [PATCH 1/9] drivers: video: Kconfig: Necessary configs for video at SPL Nikhil M Jain
2023-03-13 10:14 ` [PATCH 2/9] drivers: video: tidss: Kconfig: Configs to enable TIDSS " Nikhil M Jain
2023-03-13 10:14 ` [PATCH 3/9] cmd: Kconfig: Add necessary configs for splash screen " Nikhil M Jain
2023-03-13 10:14 ` [PATCH 4/9] drivers: video: Makefile: Compile video driver files " Nikhil M Jain
2023-03-13 10:14 ` [PATCH 5/9] drivers: video: tidss: Makefile: Add condition to compile TIDSS " Nikhil M Jain
2023-03-13 10:51   ` Peter Robinson
2023-03-13 10:14 ` [PATCH 6/9] cmd: Makefile: Add rules to build bmp.c and read.c " Nikhil M Jain
2023-03-13 10:14 ` [PATCH 7/9] common: splash: Enable splash_display at SPL stage Nikhil M Jain
2023-03-13 10:14 ` [PATCH 8/9] drivers: video: video-uclass: Disable u-boot logo at SPL Nikhil M Jain
2023-03-13 10:14 ` [PATCH 9/9] board: ti: am62x: evm: OSPI support for splash screen Nikhil M Jain
2023-03-14 22:08 ` [PATCH 0/9] Enable " Simon Glass
2023-03-15  6:06   ` Nikhil M Jain [this message]
2023-03-15 14:08     ` Simon Glass
2023-03-16  4:40       ` Nikhil M Jain
2023-03-17  8:13         ` Nikhil M Jain
2023-03-18 20:20           ` Simon Glass
2023-03-14  4:50 Nikhil M Jain
2023-03-14  5:54 ` Devarsh Thakkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9c8f7fc-514d-80ac-1df2-a8a920ccc9c6@ti.com \
    --to=n-jain1@ti.com \
    --cc=agust@denx.de \
    --cc=devarsht@ti.com \
    --cc=nsekhar@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.