All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] board: ti: am57xx: enable input on mmc clock
@ 2017-02-08 13:13 Sekhar Nori
  2017-02-08 13:37 ` Lokesh Vutla
  2017-04-09  1:14 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Sekhar Nori @ 2017-02-08 13:13 UTC (permalink / raw)
  To: u-boot

As per the latest pinmux data available for AM572x EVM,
rev A3, input should be enabled on MMC clock lines for
MMC2/2/3 for stable operation.

Further, AM572x TRM, SPRUHZ6, Revised June 2016, in
section 18.4.6.1.1 "Pad Configuration Registers" states
that input should be enabled for MMC 2/3/4 clock lines.

Enable input on MMC1 and MMC3 clock to match the latest
pinmux data. Input is already enabled on MMC2 clock for
BeagleBoard x15. Further, input is already enabled on all
MMCx clocks for other AM57xx boards (AM572x and AM571x
IDK).

Tested with HS and UHS SD card on AM572x EVM Rev A3.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 board/ti/am57xx/mux_data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/ti/am57xx/mux_data.h b/board/ti/am57xx/mux_data.h
index 2f5243ee7ad9..42150b0401cf 100644
--- a/board/ti/am57xx/mux_data.h
+++ b/board/ti/am57xx/mux_data.h
@@ -212,7 +212,7 @@ const struct pad_conf_entry core_padconf_array_essential_x15[] = {
 	{MCASP5_FSX, (M3 | PIN_OUTPUT_PULLDOWN)},	/* mcasp5_fsx.uart9_txd */
 	{MCASP5_AXR0, (M3 | PIN_INPUT_PULLDOWN)},	/* mcasp5_axr0.uart9_ctsn */
 	{MCASP5_AXR1, (M3 | PIN_OUTPUT_PULLUP)},	/* mcasp5_axr1.uart9_rtsn */
-	{MMC1_CLK, (M0 | PIN_OUTPUT_PULLUP)},	/* mmc1_clk.mmc1_clk */
+	{MMC1_CLK, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_clk.mmc1_clk */
 	{MMC1_CMD, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_cmd.mmc1_cmd */
 	{MMC1_DAT0, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_dat0.mmc1_dat0 */
 	{MMC1_DAT1, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_dat1.mmc1_dat1 */
@@ -221,7 +221,7 @@ const struct pad_conf_entry core_padconf_array_essential_x15[] = {
 	{MMC1_SDCD, (M14 | PIN_INPUT_PULLUP)},	/* mmc1_sdcd.gpio6_27 */
 	{GPIO6_10, (M10 | PIN_OUTPUT_PULLDOWN)},	/* gpio6_10.ehrpwm2A */
 	{GPIO6_11, (M0 | PIN_INPUT_PULLUP)},	/* gpio6_11.gpio6_11 */
-	{MMC3_CLK, (M0 | PIN_OUTPUT_PULLUP | MANUAL_MODE)},	/* mmc3_clk.mmc3_clk */
+	{MMC3_CLK, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_clk.mmc3_clk */
 	{MMC3_CMD, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_cmd.mmc3_cmd */
 	{MMC3_DAT0, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_dat0.mmc3_dat0 */
 	{MMC3_DAT1, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_dat1.mmc3_dat1 */
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] board: ti: am57xx: enable input on mmc clock
  2017-02-08 13:13 [U-Boot] [PATCH] board: ti: am57xx: enable input on mmc clock Sekhar Nori
@ 2017-02-08 13:37 ` Lokesh Vutla
  2017-04-09  1:14 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Lokesh Vutla @ 2017-02-08 13:37 UTC (permalink / raw)
  To: u-boot



On Wednesday 08 February 2017 06:43 PM, Sekhar Nori wrote:
> As per the latest pinmux data available for AM572x EVM,
> rev A3, input should be enabled on MMC clock lines for
> MMC2/2/3 for stable operation.
> 
> Further, AM572x TRM, SPRUHZ6, Revised June 2016, in
> section 18.4.6.1.1 "Pad Configuration Registers" states
> that input should be enabled for MMC 2/3/4 clock lines.
> 
> Enable input on MMC1 and MMC3 clock to match the latest
> pinmux data. Input is already enabled on MMC2 clock for
> BeagleBoard x15. Further, input is already enabled on all
> MMCx clocks for other AM57xx boards (AM572x and AM571x
> IDK).
> 
> Tested with HS and UHS SD card on AM572x EVM Rev A3.
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] board: ti: am57xx: enable input on mmc clock
  2017-02-08 13:13 [U-Boot] [PATCH] board: ti: am57xx: enable input on mmc clock Sekhar Nori
  2017-02-08 13:37 ` Lokesh Vutla
@ 2017-04-09  1:14 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-09  1:14 UTC (permalink / raw)
  To: u-boot

On Wed, Feb 08, 2017 at 06:43:59PM +0530, Sekhar Nori wrote:

> As per the latest pinmux data available for AM572x EVM,
> rev A3, input should be enabled on MMC clock lines for
> MMC2/2/3 for stable operation.
> 
> Further, AM572x TRM, SPRUHZ6, Revised June 2016, in
> section 18.4.6.1.1 "Pad Configuration Registers" states
> that input should be enabled for MMC 2/3/4 clock lines.
> 
> Enable input on MMC1 and MMC3 clock to match the latest
> pinmux data. Input is already enabled on MMC2 clock for
> BeagleBoard x15. Further, input is already enabled on all
> MMCx clocks for other AM57xx boards (AM572x and AM571x
> IDK).
> 
> Tested with HS and UHS SD card on AM572x EVM Rev A3.
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/443cd2f1/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-09  1:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-08 13:13 [U-Boot] [PATCH] board: ti: am57xx: enable input on mmc clock Sekhar Nori
2017-02-08 13:37 ` Lokesh Vutla
2017-04-09  1:14 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.